Skip to content

Commit f7a8013

Browse files
authored
🥢 Reduce lines (ethereum#635)
1 parent fda55ef commit f7a8013

File tree

2 files changed

+11
-13
lines changed

2 files changed

+11
-13
lines changed

‎.gas-snapshot

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -508,7 +508,7 @@ LibCloneTest:testDeployDeterministicERC1967RevertsIfAddressAlreadyUsed() (gas: 9
508508
LibCloneTest:testDeployERC1967() (gas: 99367)
509509
LibCloneTest:testDeployERC1967(uint256) (runs: 256, μ: 99418, ~: 99418)
510510
LibCloneTest:testInitialDeposit() (gas: 323861)
511-
LibCloneTest:testStartsWithCaller(uint256) (runs: 256, μ: 28133, ~: 28405)
511+
LibCloneTest:testStartsWithCaller(uint256) (runs: 256, μ: 28164, ~: 28405)
512512
LibCloneTest:test__codesize() (gas: 17564)
513513
LibMapTest:testFoundStatementDifferential(uint256,uint256,uint256) (runs: 256, μ: 499, ~: 499)
514514
LibMapTest:testGeneralMapFunctionsGas() (gas: 3304775)
@@ -712,17 +712,17 @@ LibStringTest:testToStringZeroBrutalized() (gas: 613803)
712712
LibStringTest:testToStringZeroRightPadded(uint256) (runs: 256, μ: 718269, ~: 613726)
713713
LibStringTest:test__codesize() (gas: 40236)
714714
LibZipTest:testCdCompress() (gas: 166411)
715-
LibZipTest:testCdCompressDecompress(bytes) (runs: 256, μ: 736755, ~: 651126)
716-
LibZipTest:testCdCompressDecompress(uint256) (runs: 256, μ: 792317, ~: 709500)
715+
LibZipTest:testCdCompressDecompress(bytes) (runs: 256, μ: 743852, ~: 651409)
716+
LibZipTest:testCdCompressDecompress(uint256) (runs: 256, μ: 778453, ~: 708367)
717717
LibZipTest:testCdDecompressOnInvalidInput() (gas: 34920)
718718
LibZipTest:testCdFallback() (gas: 5684348)
719-
LibZipTest:testCdFallback(bytes,uint256) (runs: 256, μ: 1198868, ~: 1044779)
720-
LibZipTest:testCdFallbackDecompressor(bytes) (runs: 256, μ: 121307, ~: 117716)
721-
LibZipTest:testCdFallbackDecompressor(uint256) (runs: 256, μ: 169962, ~: 156242)
722-
LibZipTest:testCdFallbackMaskTrick(uint256,uint256) (runs: 256, μ: 687, ~: 663)
723-
LibZipTest:testDecompressWontRevert(bytes) (runs: 256, μ: 743856, ~: 631132)
719+
LibZipTest:testCdFallback(bytes,uint256) (runs: 256, μ: 1171447, ~: 1044485)
720+
LibZipTest:testCdFallbackDecompressor(bytes) (runs: 256, μ: 121234, ~: 117102)
721+
LibZipTest:testCdFallbackDecompressor(uint256) (runs: 256, μ: 161781, ~: 152007)
722+
LibZipTest:testCdFallbackMaskTrick(uint256,uint256) (runs: 256, μ: 686, ~: 663)
723+
LibZipTest:testDecompressWontRevert(bytes) (runs: 256, μ: 751136, ~: 631259)
724724
LibZipTest:testFlzCompressDecompress() (gas: 2162941)
725-
LibZipTest:testFlzCompressDecompress(bytes) (runs: 256, μ: 851386, ~: 683566)
725+
LibZipTest:testFlzCompressDecompress(bytes) (runs: 256, μ: 835799, ~: 686117)
726726
LibZipTest:testFlzCompressDecompress2() (gas: 1015228)
727727
LibZipTest:test__codesize() (gas: 21762)
728728
MerkleProofLibTest:testEmptyCalldataHelpers() (gas: 1086)

‎src/utils/LibClone.sol

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -543,10 +543,8 @@ library LibClone {
543543
// +2 bytes for telling how much data there is appended to the call.
544544
let extraLength := add(dataLength, 2)
545545

546-
// Write the bytecode before the data.
547-
mstore(data, 0x5af43d3d93803e606057fd5bf3)
548-
// Write the address of the implementation.
549-
mstore(sub(data, 0x0d), implementation)
546+
mstore(data, 0x5af43d3d93803e606057fd5bf3) // Write the bytecode before the data.
547+
mstore(sub(data, 0x0d), implementation) // Write the address of the implementation.
550548
// Write the rest of the bytecode.
551549
mstore(
552550
sub(data, 0x21),

0 commit comments

Comments
 (0)