Merge pull request #2 from iscai-msft/update_my_main

Author: iscai-msft

.coveragerc

@@ -23,4 +23,5 @@ exclude_lines =
 omit =
 	*/test*
 	env*
-	*/_serialization.py
+	*/_serialization.py
+	*/sms/_shared/*

.devcontainer/devcontainer.json

@@ -13,22 +13,11 @@
 		"go.gopath": "/go",
 		"go.goroot": "/usr/local/go",
 		"go.toolsGopath": "/go/bin",
-		"python.pythonPath": "/opt/python/latest/bin/python",
-		"python.linting.enabled": true,
-		"python.linting.pylintEnabled": true,
-		"python.formatting.autopep8Path": "/usr/local/py-utils/bin/autopep8",
-		"python.formatting.blackPath": "/usr/local/py-utils/bin/black",
-		"python.formatting.yapfPath": "/usr/local/py-utils/bin/yapf",
-		"python.linting.banditPath": "/usr/local/py-utils/bin/bandit",
-		"python.linting.flake8Path": "/usr/local/py-utils/bin/flake8",
-		"python.linting.mypyPath": "/usr/local/py-utils/bin/mypy",
-		"python.linting.pycodestylePath": "/usr/local/py-utils/bin/pycodestyle",
-		"python.linting.pydocstylePath": "/usr/local/py-utils/bin/pydocstyle",
-		"python.linting.pylintPath": "/usr/local/py-utils/bin/pylint",
+		"python.defaultInterpreterPath": "/opt/python/latest/bin/python",
 		"lldb.executable": "/usr/bin/lldb",
 		"files.watcherExclude": {
 			"**/target/**": true
-		}
+		} 
 	},
 	"remoteUser": "codespace",
 	"overrideCommand": false,

.github/CODEOWNERS

@@ -0,0 +1,66 @@
+name: learn.microsoft.com feedback control
+description: |
+  ⛔ Don't use this template directly. Instead, click the feedback option at the bottom of a learn.microsoft.com page. ⛔
+body:
+  - type: markdown
+    attributes:
+      value: "## Issue information"
+  - type: markdown
+    attributes:
+      value: Select the issue type, and describe the issue in the text box below. Add as much detail as needed to help us resolve the issue.
+  - type: dropdown
+    id: issue-type
+    attributes:
+      label: Type of issue
+      options:
+        - Typo
+        - Code doesn't work
+        - Missing information
+        - Outdated article
+        - Other (describe below)
+    validations:
+      required: true
+  - type: textarea
+    id: feedback
+    validations:
+      required: true
+    attributes:
+      label: Description
+  - type: markdown
+    attributes:
+      value: "## 🚧 Article information 🚧"
+  - type: markdown
+    attributes:
+      value: "*Don't modify the following fields*. They are automatically filled in for you. Doing so will disconnect your issue from the affected article."
+  - type: input
+    id: pageUrl
+    validations:
+      required: true
+    attributes:
+      label: Page URL
+  - type: input
+    id: contentSourceUrl
+    validations:
+      required: true
+    attributes:
+      label: Content source URL
+  - type: input
+    id: documentVersionIndependentId
+    validations:
+      required: true
+    attributes:
+      label: Document Version Independent Id
+  - type: input
+    id: author
+    validations:
+      required: true
+    attributes:
+      label: Article author
+  - type: textarea
+    id: metadata
+    validations:
+      required: false
+    attributes:
+      label: Metadata
+      description: >-
+        Documentation metadata will be applied here for the PRMerger tool

.github/CODEOWNERS_baseline_errors.txt

@@ -21,5 +21,6 @@
   "IdentifyStaleIssues": "On",
   "IdentifyStalePullRequests": "On",
   "CloseAddressedIssues": "On",
-  "LockClosedIssues": "On"
+  "LockClosedIssues": "On",
+  "EnforceMaxLifeOfIssues": "On"
 }

.github/ISSUE_TEMPLATE/z-learn-feedback.yml

@@ -17,26 +17,29 @@ on:
 permissions: {}
 
 jobs:
-  event-handler:
+  # This event requires the Azure CLI to get the LABEL_SERVICE_API_KEY from the vault.
+  # Because the azure/login step adds time costly pre/post Az CLI commands to any every job
+  # it's used in, split this into its own job so only the event that needs the Az CLI pays
+  # the cost.
+  event-handler-with-azure:
     permissions:
       issues: write
       pull-requests: write
       # For OIDC auth
       id-token: write
       contents: read
-    name: Handle ${{ github.event_name }} ${{ github.event.action }} event
+    name: Handle ${{ github.event_name }} ${{ github.event.action }} event with azure login
     runs-on: ubuntu-latest
+    if: ${{ github.event_name == 'issues' && github.event.action == 'opened' }}
     steps:
       - name: 'Az CLI login'
-        if: ${{ github.event_name == 'issues' && github.event.action == 'opened' }}
-        uses: azure/login@v1
+        uses: azure/login@v2
         with:
             client-id: ${{ secrets.AZURE_CLIENT_ID }}
             tenant-id: ${{ secrets.AZURE_TENANT_ID }}
             subscription-id: ${{ secrets.AZURE_SUBSCRIPTION_ID }}
 
       - name: 'Run Azure CLI commands'
-        if: ${{ github.event_name == 'issues' && github.event.action == 'opened' }}
         run: |
           LABEL_SERVICE_API_KEY=$(az keyvault secret show \
             --vault-name issue-labeler \
@@ -55,7 +58,7 @@ jobs:
         run: >
           dotnet tool install
           Azure.Sdk.Tools.GitHubEventProcessor
-          --version 1.0.0-dev.20231010.2
+          --version 1.0.0-dev.20240909.2
           --add-source https://pkgs.dev.azure.com/azure-sdk/public/_packaging/azure-sdk-for-net/nuget/v3/index.json
           --global
         shell: bash
@@ -94,3 +97,58 @@ jobs:
           # https://docs.github.com/en/actions/security-guides/automatic-token-authentication#about-the-github_token-secret
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           LABEL_SERVICE_API_KEY: ${{ env.LABEL_SERVICE_API_KEY }}
+
+  event-handler:
+    permissions:
+      issues: write
+      pull-requests: write
+    name: Handle ${{ github.event_name }} ${{ github.event.action }} event
+    runs-on: ubuntu-latest
+    if: ${{ github.event_name != 'issues' || github.event.action != 'opened' }}
+    steps:
+      # To run github-event-processor built from source, for testing purposes, uncomment everything
+      # in between the Start/End-Build From Source comments and comment everything in between the
+      # Start/End-Install comments
+      # Start-Install
+      - name: Install GitHub Event Processor
+        run: >
+          dotnet tool install
+          Azure.Sdk.Tools.GitHubEventProcessor
+          --version 1.0.0-dev.20240909.2
+          --add-source https://pkgs.dev.azure.com/azure-sdk/public/_packaging/azure-sdk-for-net/nuget/v3/index.json
+          --global
+        shell: bash
+      # End-Install
+
+      # Testing checkout of sources from the Azure/azure-sdk-tools repository
+      # The ref: is the SHA from the pull request in that repository or the
+      # refs/pull/<PRNumber>/merge for the latest on any given PR. If the repository
+      # is a fork eg. <User>/azure-sdk-tools then the repository down below will
+      # need to point to that fork
+      # Start-Build
+      # - name: Checkout tools repo for GitHub Event Processor sources
+      #   uses: actions/checkout@v3
+      #   with:
+      #     repository: Azure/azure-sdk-tools
+      #     path: azure-sdk-tools
+      #     ref: <refs/pull/<PRNumber>/merge> or <sha>
+
+      # - name: Build and install GitHubEventProcessor from sources
+      #   run: |
+      #     dotnet pack
+      #     dotnet tool install --global --prerelease --add-source ../../../artifacts/packages/Debug Azure.Sdk.Tools.GitHubEventProcessor
+      #   shell: bash
+      #   working-directory: azure-sdk-tools/tools/github-event-processor/Azure.Sdk.Tools.GitHubEventProcessor
+      # End-Build
+
+      - name: Process Action Event
+        run: |
+          cat > payload.json << 'EOF'
+          ${{ toJson(github.event) }}
+          EOF
+          github-event-processor ${{ github.event_name }} payload.json
+        shell: bash
+        env:
+          # This is a temporary secret generated by github
+          # https://docs.github.com/en/actions/security-guides/automatic-token-authentication#about-the-github_token-secret
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/event-processor.config

@@ -18,7 +18,7 @@ jobs:
       pull-requests: write # to read pull requests and write comments (azure/azure-sdk-actions)
       checks: read # to read check status (azure/azure-sdk-actions)
     name: Handle ${{ github.event_name }} ${{ github.event.action }} event
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-latest # This image is intentionally set to "latest", and not to a specific version
     steps:
       - uses: azure/azure-sdk-actions@main
         with:

.github/workflows/event-processor.yml

@@ -2,6 +2,7 @@ name: GitHub Scheduled Event Processor
 
 on:
   schedule:
+    # These are generated/confirmed using https://crontab.cronhub.io/
     # Close stale issues, runs every day at 1am - CloseStaleIssues
     - cron: '0 1 * * *'
     # Identify stale pull requests, every Friday at 5am - IdentifyStalePullRequests
@@ -14,6 +15,10 @@ on:
     - cron: '30 4,10,16,22 * * *'
     # Lock closed issues, every 6 hours at 05:30 AM, 11:30 AM, 05:30 PM and 11:30 PM - LockClosedIssues
     - cron: '30 5,11,17,23 * * *'
+    # Enforce max life of issues, every M,W,F at 10:00 AM PST - EnforceMaxLifeOfIssues
+    # Note: GitHub uses UTC, to run at 10am PST, the cron task needs to be 6pm (1800 hours) UTC
+    #       When scheduling for multiple days the numeric days 0-6 (0=Sunday) must be used.
+    - cron: '0 18 * * 1,3,5'
 # This removes all unnecessary permissions, the ones needed will be set below.
 # https://docs.github.com/en/actions/security-guides/automatic-token-authentication#permissions-for-the-github_token
 permissions: {}
@@ -34,7 +39,7 @@ jobs:
         run: >
           dotnet tool install
           Azure.Sdk.Tools.GitHubEventProcessor
-          --version 1.0.0-dev.20231010.2
+          --version 1.0.0-dev.20240909.2
           --add-source https://pkgs.dev.azure.com/azure-sdk/public/_packaging/azure-sdk-for-net/nuget/v3/index.json
           --global
         shell: bash
@@ -126,3 +131,14 @@ jobs:
         shell: bash
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+
+      - name: Enforce Max Life of Issues Scheduled Event
+        if: github.event.schedule == '0 18 * * 1,3,5'
+        run: |
+          cat > payload.json << 'EOF'
+          ${{ toJson(github.event) }}
+          EOF
+          github-event-processor ${{ github.event_name }} payload.json EnforceMaxLifeOfIssues
+        shell: bash
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/event.yml

@@ -3,7 +3,7 @@
 
 # Python cache
 __pycache__/
-*.pyc
+*.py[cod]
 .pytest_cache
 .mypy_cache
 .cache
@@ -59,6 +59,7 @@ conda/assembly/
 conda/assembled/
 conda/downloaded/
 conda/conda-env/
+scenario_*.txt
 
 # tox environment folders
 .tox/