Skip to content

Commit 6448005

Browse files
committed
check api version and whether include_pending is passed
1 parent aa3f86e commit 6448005

File tree

2 files changed

+23
-2
lines changed

2 files changed

+23
-2
lines changed

sdk/keyvault/azure-keyvault-certificates/azure/keyvault/certificates/_client.py

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -554,6 +554,11 @@ def list_deleted_certificates(self, **kwargs):
554554
"""
555555
max_page_size = kwargs.pop("max_page_size", None)
556556

557+
if self.api_version == "2016-10-01" and kwargs.get("include_pending"):
558+
raise NotImplementedError(
559+
"The 'include_pending' parameter to `list_deleted_certificates` "
560+
"is only available for API versions v7.0 and up"
561+
)
557562
return self._client.get_deleted_certificates(
558563
vault_base_url=self._vault_url,
559564
maxresults=max_page_size,
@@ -588,6 +593,12 @@ def list_properties_of_certificates(self, **kwargs):
588593
"""
589594
max_page_size = kwargs.pop("max_page_size", None)
590595

596+
if self.api_version == "2016-10-01" and kwargs.get("include_pending"):
597+
raise NotImplementedError(
598+
"The 'include_pending' parameter to `list_properties_of_certificates` "
599+
"is only available for API versions v7.0 and up"
600+
)
601+
591602
return self._client.get_certificates(
592603
vault_base_url=self._vault_url,
593604
maxresults=max_page_size,

sdk/keyvault/azure-keyvault-certificates/azure/keyvault/certificates/aio/_client.py

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -512,7 +512,7 @@ def list_deleted_certificates(self, **kwargs: "Any") -> AsyncIterable[DeletedCer
512512
deletion-specific information.
513513
514514
:keyword bool include_pending: Specifies whether to include certificates which are
515-
not completely deleted.
515+
not completely deleted. Only available for API versions v7.0 and up
516516
:return: An iterator like instance of DeletedCertificate
517517
:rtype:
518518
~azure.core.paging.ItemPaged[~azure.keyvault.certificates.DeletedCertificate]
@@ -528,6 +528,11 @@ def list_deleted_certificates(self, **kwargs: "Any") -> AsyncIterable[DeletedCer
528528
"""
529529
max_page_size = kwargs.pop("max_page_size", None)
530530

531+
if self.api_version == "2016-10-01" and kwargs.get("include_pending"):
532+
raise NotImplementedError(
533+
"The 'include_pending' parameter to `list_deleted_certificates` "
534+
"is only available for API versions v7.0 and up"
535+
)
531536
return self._client.get_deleted_certificates(
532537
vault_base_url=self._vault_url,
533538
maxresults=max_page_size,
@@ -542,7 +547,7 @@ def list_properties_of_certificates(self, **kwargs: "Any") -> AsyncIterable[Cert
542547
Requires certificates/list permission.
543548
544549
:keyword bool include_pending: Specifies whether to include certificates which are not
545-
completely provisioned.
550+
completely provisioned. Only available for API versions v7.0 and up
546551
:returns: An iterator like instance of CertificateProperties
547552
:rtype:
548553
~azure.core.paging.ItemPaged[~azure.keyvault.certificates.CertificateProperties]
@@ -558,6 +563,11 @@ def list_properties_of_certificates(self, **kwargs: "Any") -> AsyncIterable[Cert
558563
"""
559564
max_page_size = kwargs.pop("max_page_size", None)
560565

566+
if self.api_version == "2016-10-01" and kwargs.get("include_pending"):
567+
raise NotImplementedError(
568+
"The 'include_pending' parameter to `list_properties_of_certificates` "
569+
"is only available for API versions v7.0 and up"
570+
)
561571
return self._client.get_certificates(
562572
vault_base_url=self._vault_url,
563573
maxresults=max_page_size,

0 commit comments

Comments
 (0)