Merge branch 'device-update' of https://github.com/dpokluda/azure-sdk-for-python into device-update

* 'device-update' of https://github.com/dpokluda/azure-sdk-for-python:
  Updated readme links.
  update artifact names for ALL packages to align with the actual package name
  Create azure-iot-nspkg (Azure#17026)
  [Communication]: SMS 1:N Messages, Custom Tags, and Idempotence (Azure#16836)
  Fixing credentials to use AAD (Azure#16885)
  T2 deviceupdate 2021 03 02 (Azure#17016)
  T2 cosmosdb 2021 02 23 (Azure#16875)
  T2 datadog 2021 03 02 (Azure#17004)
  Fixed STG76 GA setup.py classifier (Azure#17007)
  Resolve Installation Failure in AggregateReports job by updating pip install params (Azure#16999)

Author: iscai-msft

eng/pipelines/aggregate-reports.yml

@@ -14,7 +14,8 @@ jobs:
   - template: ./templates/variables/globals.yml
 
   pool:
-    vmImage: 'windows-2019'
+    name: azsdk-pool-mms-win-2019-general
+    vmImage: MMS2019
 
   steps:
   - template: /eng/pipelines/templates/steps/analyze_dependency.yml

eng/pipelines/templates/steps/analyze_dependency.yml

@@ -4,8 +4,8 @@ steps:
     inputs:
      versionSpec: '$(PythonVersion)'
 
-  - script: |
-     pip install -r eng/ci_tools.txt
+  - pwsh: |
+     pip install -r eng/ci_tools.txt $(if($IsWindows) {"--user" })
      ward scan -d $(Build.SourcesDirectory) -c $(Build.SourcesDirectory)/eng/.docsettings.yml
     displayName: 'Verify Readmes'
 

sdk/advisor/ci.yml

@@ -30,5 +30,5 @@ extends:
   parameters:
     ServiceDirectory: advisor
     Artifacts:
-    - name: azure_mgmt_advisor
+    - name: azure-mgmt-advisor
       safeName: azuremgmtadvisor

sdk/aks/ci.yml

@@ -30,5 +30,5 @@ extends:
   parameters:
     ServiceDirectory: aks
     Artifacts:
-    - name: azure_mgmt_devspaces
+    - name: azure-mgmt-devspaces
       safeName: azuremgmtdevspaces

sdk/alertsmanagement/ci.yml

@@ -30,5 +30,5 @@ extends:
   parameters:
     ServiceDirectory: alertsmanagement
     Artifacts:
-    - name: azure_mgmt_alertsmanagement
+    - name: azure-mgmt-alertsmanagement
       safeName: azuremgmtalertsmanagement

sdk/anomalydetector/ci.yml

@@ -33,6 +33,6 @@ extends:
   parameters:
     ServiceDirectory: anomalydetector
     Artifacts:
-    - name: azure_ai_anomalydetector
+    - name: azure-ai-anomalydetector
       safeName: azureaianomalydetector
 

sdk/apimanagement/ci.yml

@@ -30,5 +30,5 @@ extends:
   parameters:
     ServiceDirectory: apimanagement
     Artifacts:
-    - name: azure_mgmt_apimanagement
+    - name: azure-mgmt-apimanagement
       safeName: azuremgmtapimanagement

sdk/appconfiguration/azure-appconfiguration/tests/async_wrapper.py

@@ -6,14 +6,9 @@
 # --------------------------------------------------------------------------
 from devtools_testutils import PowerShellPreparer
 
-from azure.appconfiguration import (
-    ResourceReadOnlyError,
-    ConfigurationSetting,
-)
+from azure.appconfiguration import ConfigurationSetting
 from azure.appconfiguration.aio import AzureAppConfigurationClient
-from azure.core.exceptions import (
-    AzureError,
-)
+from azure.core.exceptions import AzureError
 from consts import (
     KEY,
     LABEL,
@@ -67,7 +62,6 @@ def trim_kwargs_from_test_function(fn, kwargs):
             for key in [k for k in kwargs if k not in args]:
                 del kwargs[key]
 
-
 def app_config_decorator(func, **kwargs):
 
     @AppConfigPreparer()

sdk/appconfiguration/azure-appconfiguration/tests/test_azure_configuration_client.py

@@ -4,7 +4,7 @@
 # license information.
 # --------------------------------------------------------------------------
 from azure.core import MatchConditions
-from devtools_testutils import AzureMgmtTestCase, PowerShellPreparer
+from devtools_testutils import AzureTestCase, PowerShellPreparer
 from azure.core.exceptions import (
     ResourceModifiedError,
     ResourceNotFoundError,
@@ -35,7 +35,7 @@
 import re
 import functools
 
-class AppConfigurationClientTest(AzureMgmtTestCase):
+class AppConfigurationClientTest(AzureTestCase):
     def __init__(self, method_name):
         super(AppConfigurationClientTest, self).__init__(method_name)
         self.vcr.match_on = ["path", "method", "query"]

sdk/appconfiguration/azure-appconfiguration/tests/test_azure_configuration_client_aad.py

@@ -4,7 +4,7 @@
 # license information.
 # --------------------------------------------------------------------------
 from azure.core import MatchConditions
-from devtools_testutils import AzureMgmtTestCase, PowerShellPreparer
+from devtools_testutils import AzureTestCase, PowerShellPreparer
 from azure.core.exceptions import (
     ResourceModifiedError,
     ResourceNotFoundError,
@@ -35,7 +35,7 @@
 
 from async_wrapper import app_config_decorator
 
-class AppConfigurationClientTest(AzureMgmtTestCase):
+class AppConfigurationClientTest(AzureTestCase):
     def __init__(self, method_name):
         super(AppConfigurationClientTest, self).__init__(method_name)
         self.vcr.match_on = ["path", "method", "query"]

sdk/appconfiguration/azure-appconfiguration/tests/test_azure_configuration_client_aad_async.py

@@ -9,9 +9,7 @@
     AzureAppConfigurationClient,
     ConfigurationSetting,
 )
-from azure.core.exceptions import (
-    AzureError,
-)
+from azure.core.exceptions import AzureError
 from consts import (
     KEY,
     LABEL,
@@ -21,7 +19,6 @@
     PAGE_SIZE,
     KEY_UUID,
 )
-import os
 import functools
 import inspect
 
@@ -65,7 +62,6 @@ def trim_kwargs_from_test_function(fn, kwargs):
             for key in [k for k in kwargs if k not in args]:
                 del kwargs[key]
 
-
 def app_config_decorator(func, **kwargs):
 
     @AppConfigPreparer()
@@ -113,52 +109,3 @@ def wrapper(*args, **kwargs):
             )
 
     return wrapper
-
-def async_app_config_decorator(func, **kwargs):
-
-    @AppConfigPreparer()
-    def wrapper(*args, **kwargs):
-        appconfiguration_connection_string = kwargs.pop("appconfiguration_connection_string")
-        client = AzureAppConfigurationClient.from_connection_string(appconfiguration_connection_string)
-
-        kwargs['client'] = client
-        kwargs['appconfiguration_connection_string'] = appconfiguration_connection_string
-
-        # Do setUp on client
-        test_config_setting = _add_for_test(
-            client,
-            ConfigurationSetting(
-                key=KEY,
-                label=LABEL,
-                value=TEST_VALUE,
-                content_type=TEST_CONTENT_TYPE,
-                tags={"tag1": "tag1", "tag2": "tag2"},
-            )
-        )
-        test_config_setting_no_label = _add_for_test(
-            client,
-            ConfigurationSetting(
-                key=KEY,
-                label=None,
-                value=TEST_VALUE,
-                content_type=TEST_CONTENT_TYPE,
-                tags={"tag1": "tag1", "tag2": "tag2"},
-            )
-        )
-        to_delete = [test_config_setting, test_config_setting_no_label]
-
-        kwargs['test_config_setting'] = test_config_setting
-        kwargs['test_config_setting_no_label'] = test_config_setting_no_label
-
-        trimmed_kwargs = {k:v for k, v in kwargs.items()}
-        trim_kwargs_from_test_function(func, trimmed_kwargs)
-
-        func(*args, **trimmed_kwargs)
-
-        # do tearDown on client
-        for item in to_delete:
-            client.delete_configuration_setting(
-                key=item.key, label=item.label
-            )
-
-    return wrapper

sdk/appconfiguration/azure-appconfiguration/tests/test_azure_configuration_client_async.py

@@ -36,7 +36,7 @@ extends:
   parameters:
     ServiceDirectory: appconfiguration
     Artifacts:
-    - name: azure_appconfiguration
+    - name: azure-appconfiguration
       safeName: azureappconfiguration
-    - name: azure_mgmt_appconfiguration
+    - name: azure-mgmt-appconfiguration
       safeName: azuremgmtappconfiguration

sdk/appconfiguration/azure-appconfiguration/tests/wrapper.py

@@ -30,7 +30,7 @@ extends:
   parameters:
     ServiceDirectory: applicationinsights
     Artifacts:
-    - name: azure_mgmt_applicationinsights
+    - name: azure-mgmt-applicationinsights
       safeName: azuremgmtapplicationinsights
-    - name: azure_applicationinsights
+    - name: azure-applicationinsights
       safeName: azureapplicationinsights

sdk/appconfiguration/ci.yml

@@ -31,5 +31,5 @@ extends:
   parameters:
     ServiceDirectory: appplatform
     Artifacts:
-    - name: azure_mgmt_appplatform
+    - name: azure-mgmt-appplatform
       safeName: azuremgmtappplatform

sdk/applicationinsights/ci.yml

@@ -30,5 +30,5 @@ extends:
   parameters:
     ServiceDirectory: appservice
     Artifacts:
-    - name: azure_mgmt_web
+    - name: azure-mgmt-web
       safeName: azuremgmtweb

sdk/appplatform/ci.yml

@@ -30,7 +30,7 @@ extends:
   parameters:
     ServiceDirectory: attestation
     Artifacts:
-    - name: azure_mgmt_attestation
+    - name: azure-mgmt-attestation
       safeName: azuremgmtattestation
-    - name: azure_security_attestation
+    - name: azure-security-attestation
       safeName: azuresecurityattestation

sdk/appservice/ci.yml

@@ -30,5 +30,5 @@ extends:
   parameters:
     ServiceDirectory: authorization
     Artifacts:
-    - name: azure_mgmt_authorization
+    - name: azure-mgmt-authorization
       safeName: azuremgmtauthorization

sdk/attestation/ci.yml

@@ -30,5 +30,5 @@ extends:
   parameters:
     ServiceDirectory: automanage
     Artifacts:
-    - name: azure_mgmt_automanage
+    - name: azure-mgmt-automanage
       safeName: azuremgmtautomanage

sdk/authorization/ci.yml

@@ -30,5 +30,5 @@ extends:
   parameters:
     ServiceDirectory: automation
     Artifacts:
-    - name: azure_mgmt_automation
+    - name: azure-mgmt-automation
       safeName: azuremgmtautomation

sdk/automanage/ci.yml

@@ -30,5 +30,5 @@ extends:
   parameters:
     ServiceDirectory: azureadb2c
     Artifacts:
-    - name: azure_mgmt_azureadb2c
+    - name: azure-mgmt-azureadb2c
       safeName: azuremgmtazureadb2c

sdk/automation/ci.yml

@@ -30,5 +30,5 @@ extends:
   parameters:
     ServiceDirectory: azurestack
     Artifacts:
-    - name: azure_mgmt_azurestack
+    - name: azure-mgmt-azurestack
       safeName: azuremgmtazurestack

sdk/azureadb2c/ci.yml

@@ -30,5 +30,5 @@ extends:
   parameters:
     ServiceDirectory: azurestackhci
     Artifacts:
-    - name: azure_mgmt_azurestackhci
+    - name: azure-mgmt-azurestackhci
       safeName: azuremgmtazurestackhci

sdk/azurestack/ci.yml

@@ -30,5 +30,5 @@ extends:
   parameters:
     ServiceDirectory: baremetalinfrastructure
     Artifacts:
-    - name: azure_mgmt_baremetalinfrastructure
+    - name: azure-mgmt-baremetalinfrastructure
       safeName: azuremgmtbaremetalinfrastructure

sdk/azurestackhci/ci.yml

@@ -30,7 +30,7 @@ extends:
   parameters:
     ServiceDirectory: batch
     Artifacts:
-    - name: azure_mgmt_batch
+    - name: azure-mgmt-batch
       safeName: azuremgmtbatch
-    - name: azure_batch
+    - name: azure-batch
       safeName: azurebatch

sdk/baremetalinfrastructure/ci.yml

@@ -30,5 +30,5 @@ extends:
   parameters:
     ServiceDirectory: billing
     Artifacts:
-    - name: azure_mgmt_billing
+    - name: azure-mgmt-billing
       safeName: azuremgmtbilling

sdk/batch/ci.yml

@@ -30,5 +30,5 @@ extends:
   parameters:
     ServiceDirectory: botservice
     Artifacts:
-    - name: azure_mgmt_botservice
+    - name: azure-mgmt-botservice
       safeName: azuremgmtbotservice

sdk/billing/ci.yml

@@ -30,5 +30,5 @@ extends:
   parameters:
     ServiceDirectory: cdn
     Artifacts:
-    - name: azure_mgmt_cdn
+    - name: azure-mgmt-cdn
       safeName: azuremgmtcdn

sdk/botservice/ci.yml

@@ -30,49 +30,49 @@ extends:
   parameters:
     ServiceDirectory: cognitiveservices
     Artifacts:
-    - name: azure_cognitiveservices_anomalydetector
+    - name: azure-cognitiveservices-anomalydetector
       safeName: azurecognitiveservicesanomalydetector
-    - name: azure_cognitiveservices_knowledge_nspkg
+    - name: azure-cognitiveservices-knowledge-nspkg
       safeName: azurecognitiveservicesknowledgenspkg
-    - name: azure_cognitiveservices_knowledge_qnamaker
+    - name: azure-cognitiveservices-knowledge-qnamaker
       safeName: azurecognitiveservicesknowledgeqnamaker
-    - name: azure_cognitiveservices_language_luis
+    - name: azure-cognitiveservices-language-luis
       safeName: azurecognitiveserviceslanguageluis
-    - name: azure_cognitiveservices_language_nspkg
+    - name: azure-cognitiveservices-language-nspkg
       safeName: azurecognitiveserviceslanguagenspkg
-    - name: azure_cognitiveservices_language_spellcheck
+    - name: azure-cognitiveservices-language-spellcheck
       safeName: azurecognitiveserviceslanguagespellcheck
-    - name: azure_cognitiveservices_language_textanalytics
+    - name: azure-cognitiveservices-language-textanalytics
       safeName: azurecognitiveserviceslanguagetextanalytics
-    - name: azure_cognitiveservices_nspkg
+    - name: azure-cognitiveservices-nspkg
       safeName: azurecognitiveservicesnspkg
-    - name: azure_cognitiveservices_personalizer
+    - name: azure-cognitiveservices-personalizer
       safeName: azurecognitiveservicespersonalizer
-    - name: azure_cognitiveservices_search_autosuggest
+    - name: azure-cognitiveservices-search-autosuggest
       safeName: azurecognitiveservicessearchautosuggest
-    - name: azure_cognitiveservices_search_customimagesearch
+    - name: azure-cognitiveservices-search-customimagesearch
       safeName: azurecognitiveservicessearchcustomimagesearch
-    - name: azure_cognitiveservices_search_customsearch
+    - name: azure-cognitiveservices-search-customsearch
       safeName: azurecognitiveservicessearchcustomsearch
-    - name: azure_cognitiveservices_search_entitysearch
+    - name: azure-cognitiveservices-search-entitysearch
       safeName: azurecognitiveservicessearchentitysearch
-    - name: azure_cognitiveservices_search_imagesearch
+    - name: azure-cognitiveservices-search-imagesearch
       safeName: azurecognitiveservicessearchimagesearch
-    - name: azure_cognitiveservices_search_newssearch
+    - name: azure-cognitiveservices-search-newssearch
       safeName: azurecognitiveservicessearchnewssearch
-    - name: azure_cognitiveservices_search_videosearch
+    - name: azure-cognitiveservices-search-videosearch
       safeName: azurecognitiveservicessearchvideosearch
-    - name: azure_cognitiveservices_search_visualsearch
+    - name: azure-cognitiveservices-search-visualsearch
       safeName: azurecognitiveservicessearchvisualsearch
-    - name: azure_cognitiveservices_search_websearch
+    - name: azure-cognitiveservices-search-websearch
       safeName: azurecognitiveservicessearchwebsearch
-    - name: azure_cognitiveservices_vision_computervision
+    - name: azure-cognitiveservices-vision-computervision
       safeName: azurecognitiveservicesvisioncomputervision
-    - name: azure_cognitiveservices_vision_contentmoderator
+    - name: azure-cognitiveservices-vision-contentmoderator
       safeName: azurecognitiveservicesvisioncontentmoderator
-    - name: azure_cognitiveservices_vision_customvision
+    - name: azure-cognitiveservices-vision-customvision
       safeName: azurecognitiveservicesvisioncustomvision
-    - name: azure_cognitiveservices_vision_face
+    - name: azure-cognitiveservices-vision-face
       safeName: azurecognitiveservicesvisionface
-    - name: azure_mgmt_cognitiveservices
+    - name: azure-mgmt-cognitiveservices
       safeName: azuremgmtcognitiveservices