Skip to content

Commit 1cbbbe0

Browse files
committed
Remove targetRef from ProxyConfig
Signed-off-by: Jackie Elliott <[email protected]>
1 parent 1fd00a3 commit 1cbbbe0

File tree

5 files changed

+51
-221
lines changed

5 files changed

+51
-221
lines changed

kubernetes/customresourcedefinitions.gen.yaml

Lines changed: 0 additions & 27 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

networking/v1beta1/proxy_config.pb.go

Lines changed: 46 additions & 119 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

networking/v1beta1/proxy_config.pb.html

Lines changed: 2 additions & 35 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

networking/v1beta1/proxy_config.proto

Lines changed: 3 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -80,27 +80,6 @@ import "type/v1beta1/selector.proto";
8080
// imageType: debug
8181
// ```
8282
//
83-
// For waypoint proxy configuration, set the `targetRef` field on the `ProxyConfig` resource.
84-
// If the `targetRef` field in the `ProxyConfig` is set, the resource will be ignored by sidecars.
85-
//
86-
// ```yaml
87-
// apiVersion: networking.istio.io/v1beta1
88-
// kind: ProxyConfig
89-
// metadata:
90-
// name: per-workload-proxyconfig
91-
// namespace: example
92-
// spec:
93-
// concurrency: 0
94-
// targetRef:
95-
// - kind: Gateway
96-
// name: waypoint
97-
// group: gateway.networking.k8s.io
98-
// ```
99-
//
100-
// If a `ProxyConfig` CR is defined that matches a workload it will merge with its `proxy.istio.io/config` annotation if present,
101-
// with the CR taking precedence over the annotation for overlapping fields. Similarly, if a mesh wide `ProxyConfig` CR is defined and
102-
// `meshConfig.DefaultConfig` is set, the two resources will be merged with the CR taking precedence for overlapping fields.
103-
//
10483
package istio.networking.v1beta1;
10584

10685
option go_package= "istio.io/api/networking/v1beta1";
@@ -126,20 +105,9 @@ option go_package= "istio.io/api/networking/v1beta1";
126105
// +k8s:deepcopy-gen=true
127106
// -->
128107
message ProxyConfig {
129-
oneof type_selector {
130-
// Optional. Selectors specify the set of pods/VMs on which this `ProxyConfig` resource should be applied.
131-
// If not set, the `ProxyConfig` resource will be applied to all workloads in the namespace where this resource is defined.
132-
istio.type.v1beta1.WorkloadSelector selector = 1;
133-
134-
// Optional. The targetRef specifies the resource the policy should be
135-
// applied to. The targeted resource specified will determine which
136-
// workloads the authorization policy applies to. If the authorization policy
137-
// is in the root namespace and the target ref is set, the namespace must be
138-
// set on the targetRef.
139-
//
140-
// If not set, the policy is applied as defined by the selector.
141-
istio.type.v1beta1.PolicyTargetReference targetRef = 5;
142-
}
108+
// Optional. Selectors specify the set of pods/VMs on which this `ProxyConfig` resource should be applied.
109+
// If not set, the `ProxyConfig` resource will be applied to all workloads in the namespace where this resource is defined.
110+
istio.type.v1beta1.WorkloadSelector selector = 1;
143111

144112
// The number of worker threads to run.
145113
// If unset, defaults to 2. If set to 0, this will be configured to use all cores on the machine using

0 commit comments

Comments
 (0)