Skip to content

Commit 7144031

Browse files
committed
clarify in targetRef description only waypoint is supported as a
targeted resource Signed-off-by: Jackie Elliott <[email protected]>
1 parent 33a355a commit 7144031

12 files changed

+54
-36
lines changed

extensions/v1alpha1/wasm.pb.go

Lines changed: 4 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

extensions/v1alpha1/wasm.proto

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -245,13 +245,14 @@ message WasmPlugin {
245245
istio.type.v1beta1.WorkloadSelector selector = 1;
246246

247247
// $hide_from_docs
248-
// Optional. The targetRef specifies the resource the policy should be
248+
// Optional. The targetRef specifies the waypoint the policy should be
249249
// applied to. The targeted resource specified will determine which
250-
// workloads the WasmPlugin applies to. The resource must be in the
251-
// same namespace as the policy.
250+
// workloads the WasmPlugin applies to. The targeted resource must be
251+
// a waypoint. The waypoint must be in the same namespace as the policy.
252252
//
253253
// If the targetRef is not set, the policy is applied as defined by the selector.
254254
// At most one of the selector and targetRef can be set.
255+
// Waypoint proxies will not respect selectors even if they match.
255256
istio.type.v1beta1.PolicyTargetReference targetRef = 15;
256257

257258
// URL of a Wasm module or OCI container. If no scheme is present,

security/v1/authorization_policy.pb.go

Lines changed: 4 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

security/v1/authorization_policy.proto

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -472,10 +472,11 @@ message AuthorizationPolicy {
472472
istio.type.v1beta1.WorkloadSelector selector = 1;
473473

474474
// $hide_from_docs
475-
// Optional. The targetRef specifies the resource the policy should be
475+
// Optional. The targetRef specifies the waypoint the policy should be
476476
// applied to. The targeted resource specified will determine which
477-
// workloads the authorization policy applies to. The resource must
478-
// be in the same namespace as the authorization policy.
477+
// workloads the authorization policy applies to. The targeted resource
478+
// must be a waypoint. The waypoint must be in the same namespace as
479+
// the authorization policy.
479480
//
480481
// If not set, the policy is applied as defined by the selector.
481482
// At most one of the selector and targetRef can be set.

security/v1/request_authentication.pb.go

Lines changed: 5 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

security/v1/request_authentication.proto

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -447,13 +447,15 @@ message RequestAuthentication {
447447
istio.type.v1beta1.WorkloadSelector selector = 1;
448448

449449
// $hide_from_docs
450-
// Optional. The targetRef specifies the resource the policy should be
450+
// Optional. The targetRef specifies the waypoint the policy should be
451451
// applied to. The targeted resource specified will determine which
452-
// workloads the request authentication policy to. The resource must
453-
// be in the same namespace as the request authentication policy.
452+
// workloads the request authentication policy to. The targeted resource
453+
// must be a waypoint. The waypoint must be in the same namespace as the
454+
// request authentication policy.
454455
//
455456
// If not set, the policy is applied as defined by the selector.
456457
// At most one of the selector and targetRef can be set.
458+
// Waypoint proxies will not respect selectors even if they match.
457459
istio.type.v1beta1.PolicyTargetReference targetRef = 3;
458460

459461
// Define the list of JWTs that can be validated at the selected workloads' proxy. A valid token

security/v1beta1/authorization_policy.pb.go

Lines changed: 4 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

security/v1beta1/authorization_policy.proto

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -472,10 +472,11 @@ message AuthorizationPolicy {
472472
istio.type.v1beta1.WorkloadSelector selector = 1;
473473

474474
// $hide_from_docs
475-
// Optional. The targetRef specifies the resource the policy should be
475+
// Optional. The targetRef specifies the waypoint the policy should be
476476
// applied to. The targeted resource specified will determine which
477-
// workloads the authorization policy applies to. The resource must
478-
// be in the same namespace as the authorization policy.
477+
// workloads the authorization policy applies to. The targeted resource
478+
// must be a waypoint. The waypoint must be in the same namespace as
479+
// the authorization policy.
479480
//
480481
// If not set, the policy is applied as defined by the selector.
481482
// At most one of the selector and targetRef can be set.

security/v1beta1/request_authentication.pb.go

Lines changed: 5 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

security/v1beta1/request_authentication.proto

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -446,13 +446,15 @@ message RequestAuthentication {
446446
istio.type.v1beta1.WorkloadSelector selector = 1;
447447

448448
// $hide_from_docs
449-
// Optional. The targetRef specifies the resource the policy should be
449+
// Optional. The targetRef specifies the waypoint the policy should be
450450
// applied to. The targeted resource specified will determine which
451-
// workloads the request authentication policy to. The resource must
452-
// be in the same namespace as the request authentication policy.
451+
// workloads the request authentication policy to. The targeted resource
452+
// must be a waypoint. The waypoint must be in the same namespace as the
453+
// request authentication policy.
453454
//
454455
// If not set, the policy is applied as defined by the selector.
455456
// At most one of the selector and targetRef can be set.
457+
// Waypoint proxies will not respect selectors even if they match.
456458
istio.type.v1beta1.PolicyTargetReference targetRef = 3;
457459

458460
// Define the list of JWTs that can be validated at the selected workloads' proxy. A valid token

telemetry/v1alpha1/telemetry.pb.go

Lines changed: 5 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

telemetry/v1alpha1/telemetry.proto

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -253,13 +253,15 @@ message Telemetry {
253253
istio.type.v1beta1.WorkloadSelector selector = 1;
254254

255255
// $hide_from_docs
256-
// Optional. The targetRef specifies the resource the policy should be
256+
// Optional. The targetRef specifies the waypoint the policy should be
257257
// applied to. The targeted resource specified will determine which
258-
// workloads the telemetry policy applies to. The resource must be in the
259-
// same namespace as the Telemetry policy.
258+
// workloads the telemetry policy applies to. The targeted resource
259+
// must be a waypoint. The resource must be in the same namespace as
260+
// the Telemetry policy.
260261
//
261262
// If not set, the policy is applied as defined by the selector.
262263
// At most one of the selector and targetRef can be set.
264+
// Waypoint proxies will not respect selectors even if they match.
263265
istio.type.v1beta1.PolicyTargetReference targetRef = 5;
264266

265267
// Optional. Tracing configures the tracing behavior for all

0 commit comments

Comments
 (0)