Skip to content

Commit f5dff36

Browse files
committed
updated comments
1 parent afd4951 commit f5dff36

6 files changed

+104
-143
lines changed

kubernetes/customresourcedefinitions.gen.yaml

+64-88
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

networking/v1alpha3/destination_rule.pb.go

+8-11
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

networking/v1alpha3/destination_rule.pb.html

+8-11
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

networking/v1alpha3/destination_rule.proto

+8-11
Original file line numberDiff line numberDiff line change
@@ -963,12 +963,10 @@ message OutlierDetection {
963963
// applicable in k8s environments with few pods per service.
964964
int32 min_health_percent = 5;
965965

966-
// FailurePercent Algorithm for Grpc-xds proxyless for deciding
967-
// if the host is an outlier or not.
966+
// FailurePercent Algorithm for deciding if the host is an outlier or not.
968967
FailurePercentageEjection failure_percentage_ejection = 10;
969968

970-
// SuccessRateEjection Algorithm for Grpc-xds proxyless for deciding
971-
// if the host is an outlier or not.
969+
// SuccessRateEjection Algorithm for deciding if the host is an outlier or not.
972970
SuccessRateEjection success_rate_ejection = 11;
973971
}
974972

@@ -992,8 +990,8 @@ message FailurePercentageEjection {
992990
// ejection will not be performed.
993991
google.protobuf.UInt32Value minimum_hosts = 3;
994992

995-
// The minimum number of total requests that must be collected in one interval (as defined by the
996-
// interval duration above) to perform failure percentage-based ejection for this address. If the
993+
// The minimum number of total requests that must be collected in one interval
994+
// to perform failure percentage-based ejection for this address. If the
997995
// volume is lower than this setting, failure percentage-based ejection will not be performed for
998996
// this host.
999997
google.protobuf.UInt32Value request_volume = 4;
@@ -1025,10 +1023,9 @@ message SuccessRateEjection {
10251023
google.protobuf.UInt32Value minimum_hosts = 3;
10261024

10271025
// The minimum number of total requests that must be collected in one
1028-
// interval (as defined by the interval duration above) to include this address
1029-
// in success rate based outlier detection. If the volume is lower than this
1030-
// setting, outlier detection via success rate statistics is not performed
1031-
// for that address.
1026+
// interval to include this address in success rate based outlier detection.
1027+
// If the volume is lower than this setting, outlier detection via success
1028+
// rate statistics is not performed for that address.
10321029
google.protobuf.UInt32Value request_volume = 4;
10331030
}
10341031

@@ -1040,7 +1037,7 @@ message SuccessRateEjection {
10401037
// for connections to upstream database cluster.
10411038
//
10421039
// {{<tabset category-name="example">}}
1043-
// {{<tab name="v1alpha3" category-value="v1alpha3">}}
1040+
// {{<tab name="v1alpha3" category-value="v1lpha3">}}
10441041
// ```yaml
10451042
// apiVersion: networking.istio.io/v1alpha3
10461043
// kind: DestinationRule

networking/v1beta1/destination_rule.pb.go

+8-11
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

networking/v1beta1/destination_rule.proto

+8-11
Original file line numberDiff line numberDiff line change
@@ -912,12 +912,10 @@ message OutlierDetection {
912912
// applicable in k8s environments with few pods per service.
913913
int32 min_health_percent = 5;
914914

915-
// FailurePercent Algorithm for Grpc-xds proxyless for deciding
916-
// if the host is an outlier or not.
915+
// FailurePercent Algorithm for deciding if the host is an outlier or not.
917916
FailurePercentageEjection failure_percentage_ejection = 10;
918917

919-
// SuccessRateEjection Algorithm for Grpc-xds proxyless for deciding
920-
// if the host is an outlier or not.
918+
// SuccessRateEjection Algorithm for deciding if the host is an outlier or not.
921919
SuccessRateEjection success_rate_ejection = 11;
922920
}
923921

@@ -941,8 +939,8 @@ message FailurePercentageEjection {
941939
// ejection will not be performed.
942940
google.protobuf.UInt32Value minimum_hosts = 3;
943941

944-
// The minimum number of total requests that must be collected in one interval (as defined by the
945-
// interval duration above) to perform failure percentage-based ejection for this address. If the
942+
// The minimum number of total requests that must be collected in one interval
943+
// to perform failure percentage-based ejection for this address. If the
946944
// volume is lower than this setting, failure percentage-based ejection will not be performed for
947945
// this host.
948946
google.protobuf.UInt32Value request_volume = 4;
@@ -974,10 +972,9 @@ message SuccessRateEjection {
974972
google.protobuf.UInt32Value minimum_hosts = 3;
975973

976974
// The minimum number of total requests that must be collected in one
977-
// interval (as defined by the interval duration above) to include this address
978-
// in success rate based outlier detection. If the volume is lower than this
979-
// setting, outlier detection via success rate statistics is not performed
980-
// for that address.
975+
// interval to include this address in success rate based outlier detection.
976+
// If the volume is lower than this setting, outlier detection via success
977+
// rate statistics is not performed for that address.
981978
google.protobuf.UInt32Value request_volume = 4;
982979
}
983980

@@ -989,7 +986,7 @@ message SuccessRateEjection {
989986
// for connections to upstream database cluster.
990987
//
991988
// {{<tabset category-name="example">}}
992-
// {{<tab name="v1alpha3" category-value="v1alpha3">}}
989+
// {{<tab name="v1alpha3" category-value="v1lpha3">}}
993990
// ```yaml
994991
// apiVersion: networking.istio.io/v1alpha3
995992
// kind: DestinationRule

0 commit comments

Comments
 (0)