Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lint to the API repo #3450

Open
craigbox opened this issue Mar 4, 2025 · 0 comments
Open

Add lint to the API repo #3450

craigbox opened this issue Mar 4, 2025 · 0 comments

Comments

@craigbox
Copy link
Contributor

craigbox commented Mar 4, 2025

If you introduce curly unicode quotes (““ instead of ""), you will eventually break the linter on istio.io.

For example #3426

// For text format, the output of the empty operator is changed from “-“ to an empty string.

leads to istio/istio.io#16281 (prow)

./content/en/docs/reference/config/istio.mesh.v1alpha1/index.html:1707:For text format, the output of the empty operator is changed from “-“ to an empty string.
Ensure content only uses standard quotation marks and not “

Could we please introduce some light linting to PRs here for this use case, which has now happened at least enough times that i remember it?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@craigbox