Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wasm: add wasm plugin fail strategy reload #3471

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

wasm: add wasm plugin fail strategy reload #3471

wants to merge 1 commit into from
+27 −5

Conversation

adam-cattermole
Copy link

@adam-cattermole adam-cattermole commented Mar 20, 2025 •
edited
Loading

Add support for envoy's FailurePolicy FAIL_RELOAD

Resolves #3470

@istio-testing istio-testing added the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Mar 20, 2025
@istio-policy-bot
Copy link

😊 Welcome @adam-cattermole! This is either your first contribution to the Istio api repo, or it's been
a while since you've been here.

You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Mar 20, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: adam-cattermole / name: Adam Cattermole (2b3708e)

@istio-testing istio-testing added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test labels Mar 20, 2025
@istio-testing
Copy link
Collaborator

Hi @adam-cattermole. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@adam-cattermole adam-cattermole marked this pull request as ready for review March 20, 2025 15:39
@adam-cattermole adam-cattermole requested a review from a team as a code owner March 20, 2025 15:39
@istio-testing istio-testing removed the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Mar 20, 2025
@adam-cattermole adam-cattermole mentioned this pull request Mar 20, 2025
Draft
@zirain
Copy link
Member

zirain commented Mar 29, 2025

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Mar 29, 2025
@zirain zirain added the release-notes-none Indicates a PR that does not require release notes. label Mar 29, 2025
@zirain
Copy link
Member

zirain commented Mar 29, 2025

LGTM

@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Apr 1, 2025
@istio-testing istio-testing removed the needs-rebase Indicates a PR needs to be rebased before being merged label Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. release-notes-none Indicates a PR that does not require release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wasm: add fail_reload failure policy
4 participants
@adam-cattermole @istio-policy-bot @istio-testing @zirain