+aggression |
+DoubleValue |
+
+ This parameter controls the speed of traffic increase over the warmup duration. Defaults to 1.0, so that endpoints would
+get linearly increasing amount of traffic. When increasing the value for this parameter,
+the speed of traffic ramp-up increases non-linearly.
+
|
No
diff --git a/networking/v1alpha3/destination_rule.proto b/networking/v1alpha3/destination_rule.proto
index 522d376c835..7fb0e229939 100644
--- a/networking/v1alpha3/destination_rule.proto
+++ b/networking/v1alpha3/destination_rule.proto
@@ -377,6 +377,7 @@ message Subset {
// ```
//
message LoadBalancerSettings {
+ // +kubebuilder:validation:XValidation:message="only one of warmupDurationSecs or warmup can be set",rule="(has(self.warmupDurationSecs)?1:0)+(has(self.warmup)?1:0)<=1"
// Standard load balancing algorithms that require no tuning.
enum SimpleLB {
// No load balancing algorithm has been specified by the user. Istio
@@ -506,7 +507,10 @@ message LoadBalancerSettings {
// between this object and the object one in MeshConfig
LocalityLoadBalancerSetting locality_lb_setting = 3;
- // Represents the warmup duration of Service. If set, the newly created endpoint of service
+ // Deprecated: use `warmup` instead.
+ google.protobuf.Duration warmup_duration_secs = 4;
+
+ // Represents the warmup configuration of Service. If set, the newly created endpoint of service
// remains in warmup mode starting from its creation time for the duration of this window and
// Istio progressively increases amount of traffic for that endpoint instead of sending proportional amount of traffic.
// This should be enabled for services that require warm up time to serve full production load with reasonable latency.
@@ -514,9 +518,25 @@ message LoadBalancerSettings {
// endpoints are relatively new like new deployment, this is not very effective as all endpoints end up getting same
// amount of requests.
// Currently this is only supported for ROUND_ROBIN and LEAST_REQUEST load balancers.
- google.protobuf.Duration warmup_duration_secs = 4;
+ WarmupConfiguration warmup = 5;
}
+message WarmupConfiguration {
+ // Duration of warmup mode
+ google.protobuf.Duration duration = 1 [(google.api.field_behavior) = REQUIRED];
+
+ // Configures the minimum percentage of origin weight
+ // If unspecified, defaults to 10
+ // +kubebuilder:validation:Maximum=100
+ // +kubebuilder:validation:Minimum=0
+ google.protobuf.DoubleValue minimum_percent = 2;
+
+ // This parameter controls the speed of traffic increase over the warmup duration. Defaults to 1.0, so that endpoints would
+ // get linearly increasing amount of traffic. When increasing the value for this parameter,
+ // the speed of traffic ramp-up increases non-linearly.
+ // +kubebuilder:validation:Minimum=1
+ google.protobuf.DoubleValue aggression = 3;
+}
// Connection pool settings for an upstream host. The settings apply to
// each individual host in the upstream service. See Envoy's [circuit
// breaker](https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/upstream/circuit_breaking)
diff --git a/networking/v1alpha3/destination_rule_deepcopy.gen.go b/networking/v1alpha3/destination_rule_deepcopy.gen.go
index 597753faf14..0f61ea8d3ae 100644
--- a/networking/v1alpha3/destination_rule_deepcopy.gen.go
+++ b/networking/v1alpha3/destination_rule_deepcopy.gen.go
@@ -236,6 +236,27 @@ func (in *LoadBalancerSettings_ConsistentHashLB_HTTPCookie) DeepCopyInterface()
return in.DeepCopy()
}
+// DeepCopyInto supports using WarmupConfiguration within kubernetes types, where deepcopy-gen is used.
+func (in *WarmupConfiguration) DeepCopyInto(out *WarmupConfiguration) {
+ p := proto.Clone(in).(*WarmupConfiguration)
+ *out = *p
+}
+
+// DeepCopy is an autogenerated deepcopy function, copying the receiver, creating a new WarmupConfiguration. Required by controller-gen.
+func (in *WarmupConfiguration) DeepCopy() *WarmupConfiguration {
+ if in == nil {
+ return nil
+ }
+ out := new(WarmupConfiguration)
+ in.DeepCopyInto(out)
+ return out
+}
+
+// DeepCopyInterface is an autogenerated deepcopy function, copying the receiver, creating a new WarmupConfiguration. Required by controller-gen.
+func (in *WarmupConfiguration) DeepCopyInterface() interface{} {
+ return in.DeepCopy()
+}
+
// DeepCopyInto supports using ConnectionPoolSettings within kubernetes types, where deepcopy-gen is used.
func (in *ConnectionPoolSettings) DeepCopyInto(out *ConnectionPoolSettings) {
p := proto.Clone(in).(*ConnectionPoolSettings)
diff --git a/networking/v1alpha3/destination_rule_json.gen.go b/networking/v1alpha3/destination_rule_json.gen.go
index 377644a0f1c..4e65aa9c891 100644
--- a/networking/v1alpha3/destination_rule_json.gen.go
+++ b/networking/v1alpha3/destination_rule_json.gen.go
@@ -127,6 +127,17 @@ func (this *LoadBalancerSettings_ConsistentHashLB_HTTPCookie) UnmarshalJSON(b []
return DestinationRuleUnmarshaler.Unmarshal(bytes.NewReader(b), this)
}
+// MarshalJSON is a custom marshaler for WarmupConfiguration
+func (this *WarmupConfiguration) MarshalJSON() ([]byte, error) {
+ str, err := DestinationRuleMarshaler.MarshalToString(this)
+ return []byte(str), err
+}
+
+// UnmarshalJSON is a custom unmarshaler for WarmupConfiguration
+func (this *WarmupConfiguration) UnmarshalJSON(b []byte) error {
+ return DestinationRuleUnmarshaler.Unmarshal(bytes.NewReader(b), this)
+}
+
// MarshalJSON is a custom marshaler for ConnectionPoolSettings
func (this *ConnectionPoolSettings) MarshalJSON() ([]byte, error) {
str, err := DestinationRuleMarshaler.MarshalToString(this)
diff --git a/networking/v1beta1/destination_rule_alias.gen.go b/networking/v1beta1/destination_rule_alias.gen.go
index 46de656f5e6..931e2eb9d40 100644
--- a/networking/v1beta1/destination_rule_alias.gen.go
+++ b/networking/v1beta1/destination_rule_alias.gen.go
@@ -179,6 +179,7 @@ type LoadBalancerSettings_ConsistentHashLB_RingHash_ = v1alpha3.LoadBalancerSett
// The Maglev load balancer implements consistent hashing to backend hosts.
type LoadBalancerSettings_ConsistentHashLB_Maglev = v1alpha3.LoadBalancerSettings_ConsistentHashLB_Maglev
+// +kubebuilder:validation:XValidation:message="only one of warmupDurationSecs or warmup can be set",rule="(has(self.warmupDurationSecs)?1:0)+(has(self.warmup)?1:0)<=1"
// Standard load balancing algorithms that require no tuning.
type LoadBalancerSettings_SimpleLB = v1alpha3.LoadBalancerSettings_SimpleLB
@@ -215,6 +216,7 @@ const LoadBalancerSettings_LEAST_REQUEST LoadBalancerSettings_SimpleLB = v1alpha
type LoadBalancerSettings_Simple = v1alpha3.LoadBalancerSettings_Simple
type LoadBalancerSettings_ConsistentHash = v1alpha3.LoadBalancerSettings_ConsistentHash
+type WarmupConfiguration = v1alpha3.WarmupConfiguration
// Connection pool settings for an upstream host. The settings apply to
// each individual host in the upstream service. See Envoy's [circuit
diff --git a/releasenotes/notes/slow-start-aggression-minimum-percent-parameters.yaml b/releasenotes/notes/slow-start-aggression-minimum-percent-parameters.yaml
new file mode 100644
index 00000000000..7422738c805
--- /dev/null
+++ b/releasenotes/notes/slow-start-aggression-minimum-percent-parameters.yaml
@@ -0,0 +1,13 @@
+apiVersion: release-notes/v2
+
+kind: feature
+area: traffic-management
+issue:
+- 3215
+
+releaseNotes:
+- |
+ **Added** aggression and minimum_percent parameters
+
+docs:
+ - https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/upstream/load_balancing/slow_start
\ No newline at end of file
diff --git a/tests/testdata/destinationrule-invalid.yaml b/tests/testdata/destinationrule-invalid.yaml
new file mode 100644
index 00000000000..7c61b6260d5
--- /dev/null
+++ b/tests/testdata/destinationrule-invalid.yaml
@@ -0,0 +1,37 @@
+_err: 'spec.trafficPolicy.loadBalancer.warmup.minimumPercent: Invalid value'
+apiVersion: networking.istio.io/v1
+kind: DestinationRule
+metadata:
+ name: bookinfo-ratings
+spec:
+ host: ratings.prod.svc.cluster.local
+ trafficPolicy:
+ loadBalancer:
+ warmup:
+ duration: 300s
+ minimumPercent: 150.0
+---
+_err: 'spec.trafficPolicy.loadBalancer.warmup.duration: Required value'
+apiVersion: networking.istio.io/v1
+kind: DestinationRule
+metadata:
+ name: bookinfo-ratings
+spec:
+ host: ratings.prod.svc.cluster.local
+ trafficPolicy:
+ loadBalancer:
+ warmup:
+ minimumPercent: 5.0
+---
+_err: 'spec.trafficPolicy.loadBalancer.warmup.aggression: Invalid value'
+apiVersion: networking.istio.io/v1
+kind: DestinationRule
+metadata:
+ name: bookinfo-ratings
+spec:
+ host: ratings.prod.svc.cluster.local
+ trafficPolicy:
+ loadBalancer:
+ warmup:
+ duration: 300s
+ aggression: 0.3
\ No newline at end of file
diff --git a/tests/testdata/destinationrule-valid.yaml b/tests/testdata/destinationrule-valid.yaml
new file mode 100644
index 00000000000..9441b649979
--- /dev/null
+++ b/tests/testdata/destinationrule-valid.yaml
@@ -0,0 +1,35 @@
+apiVersion: networking.istio.io/v1
+kind: DestinationRule
+metadata:
+ name: bookinfo-ratings
+spec:
+ host: ratings.prod.svc.cluster.local
+ trafficPolicy:
+ loadBalancer:
+ warmup:
+ duration: 300s
+---
+apiVersion: networking.istio.io/v1
+kind: DestinationRule
+metadata:
+ name: bookinfo-ratings
+spec:
+ host: ratings.prod.svc.cluster.local
+ trafficPolicy:
+ loadBalancer:
+ warmup:
+ duration: 300s
+ minimumPercent: 5.0
+---
+apiVersion: networking.istio.io/v1
+kind: DestinationRule
+metadata:
+ name: bookinfo-ratings
+spec:
+ host: ratings.prod.svc.cluster.local
+ trafficPolicy:
+ loadBalancer:
+ warmup:
+ duration: 300s
+ minimumPercent: 5.0
+ aggression: 5.0
\ No newline at end of file
|