Cleanup obsolete image pushing (#4748)

Two parts:
* Cleanup DOCKER_REPOSITORY, which is strictly dead code
* Cleanup WASM_REPOSITORY, which is used to push WASM images. This has
  moved to istio-ecosystem

Author: howardjohn

Makefile.core.mk

@@ -17,11 +17,7 @@ TOP := $(shell dirname $(realpath $(lastword $(MAKEFILE_LIST))))
 SHELL := /bin/bash
 BAZEL_STARTUP_ARGS ?=
 BAZEL_BUILD_ARGS ?=
-BAZEL_TARGETS ?= //... \
-                 -extensions:metadata_exchange.wasm \
-                 -extensions:push_wasm_image_metadata_exchange \
-                 -extensions:wasm_image_metadata_exchange \
-                 -extensions:copy_original_file_metadata_exchange
+BAZEL_TARGETS ?= //... -extensions:metadata_exchange.wasm
 # Don't build Debian packages and Docker images in tests.
 BAZEL_TEST_TARGETS ?= ${BAZEL_TARGETS}
 E2E_TEST_TARGETS ?= $$(go list ./...)

bazel/bazel_get_workspace_status

@@ -35,5 +35,3 @@ fi
 echo "BUILD_SCM_REVISION ${BUILD_SCM_REVISION}"
 echo "BUILD_SCM_STATUS ${BUILD_SCM_STATUS}"
 echo "BUILD_CONFIG ${BUILD_CONFIG:-default}"
-echo "DOCKER_REPOSITORY ${DOCKER_REPOSITORY:-istio-testing/envoy}"
-echo "WASM_REPOSITORY ${WASM_REPOSITORY:-istio-testing/wasm}"

bazel/wasm.bzl

@@ -16,12 +16,6 @@
 #
 
 load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive", "http_file")
-load("@bazel_skylib//rules:copy_file.bzl", "copy_file")
-load(
-    "@io_bazel_rules_docker//container:container.bzl",
-    "container_image",
-    "container_push",
-)
 
 def wasm_dependencies():
     FLAT_BUFFERS_SHA = "a83caf5910644ba1c421c002ef68e42f21c15f9f"
@@ -40,20 +34,3 @@ def wasm_dependencies():
             "https://github.com/nlohmann/json/releases/download/v3.7.3/json.hpp",
         ],
     )
-
-def declare_wasm_image_targets(name, wasm_file, docker_registry, tag, pkg):
-    tmpdir = "tmp-" + name
-    plugin_file = tmpdir + "/plugin.wasm"
-    copy_file("copy_original_file_" + name, wasm_file, plugin_file)
-    container_image(
-        name = "wasm_image_" + name,
-        files = [pkg + ":" + plugin_file],
-    )
-    container_push(
-        name = "push_wasm_image_" + name,
-        format = "OCI",
-        image = ":wasm_image_" + name,
-        registry = "gcr.io",
-        repository = docker_registry + "/" + name,
-        tag = tag,
-    )

extensions/BUILD

@@ -23,7 +23,6 @@ load(
     "@envoy//bazel:envoy_build_system.bzl",
     "envoy_package",
 )
-load("//bazel:wasm.bzl", "declare_wasm_image_targets")
 
 envoy_package()
 
@@ -57,11 +56,3 @@ envoy_wasm_cc_binary(
         "@proxy_wasm_cpp_sdk//contrib:contrib_lib",
     ],
 )
-
-declare_wasm_image_targets(
-    name = "metadata_exchange",
-    docker_registry = "{WASM_REPOSITORY}",
-    pkg = "//extensions",
-    tag = "{BUILD_SCM_REVISION}",
-    wasm_file = ":metadata_exchange.wasm",
-)

scripts/release-binary.sh

@@ -54,9 +54,6 @@ BASE_BINARY_NAME="${BASE_BINARY_NAME:-"envoy"}"
 # If enabled, we will just build the Envoy binary rather than wasm, etc
 BUILD_ENVOY_BINARY_ONLY="${BUILD_ENVOY_BINARY_ONLY:-0}"
 
-# Push envoy docker image.
-PUSH_DOCKER_IMAGE=0
-
 # Support CentOS builds
 BUILD_FOR_CENTOS=0
 
@@ -65,17 +62,14 @@ function usage() {
     -d  The bucket name to store proxy binary (optional).
         If not provided, both envoy binary push and docker image push are skipped.
     -i  Skip Ubuntu Xenial check. DO NOT USE THIS FOR RELEASED BINARIES.
-    -c  Build for CentOS releases. This will disable the Ubuntu Xenial check.
-    -p  Push wasm oci image.
-        Registry is hard coded to gcr.io and repository is controlled via DOCKER_REPOSITORY and WASM_REPOSITORY env var."
+    -c  Build for CentOS releases. This will disable the Ubuntu Xenial check."
   exit 1
 }
 
 while getopts d:ipc arg ; do
   case "${arg}" in
     d) DST="${OPTARG}";;
     i) CHECK=0;;
-    p) PUSH_DOCKER_IMAGE=1;;
     c) BUILD_FOR_CENTOS=1;;
     *) usage;;
   esac
@@ -190,11 +184,6 @@ trap 'rm -rf ${TMP_WASM}' EXIT
 make build_wasm
 if [ -n "${DST}" ]; then
   for extension in "${extensions[@]}"; do
-    if [ "${PUSH_DOCKER_IMAGE}" -eq 1 ]; then
-      echo "Pushing Wasm OCI image for ${extension}"
-      # shellcheck disable=SC2086
-      bazel run ${BAZEL_BUILD_ARGS} ${CONFIG_PARAMS} //extensions:push_wasm_image_${extension}
-    fi
     # Rename the plugin file and generate sha256 for it
     WASM_NAME="${extension}-${SHA}.wasm"
     WASM_COMPILED_NAME="${extension}-${SHA}.compiled.wasm"