Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Runner faster termination #1021

Merged
merged 8 commits into from
May 29, 2022
Merged

Runner faster termination #1021

merged 8 commits into from
May 29, 2022

Conversation

DavidGOrtega
Copy link
Contributor

@DavidGOrtega DavidGOrtega commented May 25, 2022 •
edited
Loading

The intention of this PR is:

  • avoid having to wait X secs prior to destroy in every scenario. Only if it needs to cleanup TF resources
  • Unregister the runner prior to try to kill the underlying CI runner to not accept more jobs.
  • Fixes runner error logs, destructure id of undefined #990 with a proper message

@DavidGOrtega DavidGOrtega temporarily deployed to internal May 25, 2022 16:33 Inactive
@DavidGOrtega DavidGOrtega marked this pull request as draft May 25, 2022 16:33
@DavidGOrtega DavidGOrtega temporarily deployed to internal May 26, 2022 12:51 Inactive
@DavidGOrtega DavidGOrtega temporarily deployed to internal May 29, 2022 09:46 Inactive
@DavidGOrtega DavidGOrtega temporarily deployed to internal May 29, 2022 09:47 Inactive
@DavidGOrtega DavidGOrtega marked this pull request as ready for review May 29, 2022 09:48
@DavidGOrtega DavidGOrtega temporarily deployed to internal May 29, 2022 09:56 Inactive
@DavidGOrtega DavidGOrtega temporarily deployed to internal May 29, 2022 13:44 Inactive
@DavidGOrtega DavidGOrtega requested a review from a team May 29, 2022 16:24
@DavidGOrtega DavidGOrtega self-assigned this May 29, 2022
@DavidGOrtega DavidGOrtega temporarily deployed to internal May 29, 2022 16:35 Inactive
@0x2b3bfa0 0x2b3bfa0 enabled auto-merge (squash) May 29, 2022 16:38
@0x2b3bfa0 0x2b3bfa0 disabled auto-merge May 29, 2022 16:40
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal May 29, 2022 16:41 Inactive
0x2b3bfa0
0x2b3bfa0 approved these changes May 29, 2022
View reviewed changes
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal May 29, 2022 16:53 Inactive
@0x2b3bfa0 0x2b3bfa0 merged commit 3c9e3b5 into master May 29, 2022
@0x2b3bfa0 0x2b3bfa0 deleted the runner-faster-termination branch May 29, 2022 16:58
@0x2b3bfa0 0x2b3bfa0 added bug Something isn't working enhancement New feature or request technical-debt Refactoring, linting & tidying labels May 29, 2022
@0x2b3bfa0 0x2b3bfa0 added the cml-runner Subcommand label May 29, 2022
@casperdcl casperdcl mentioned this pull request Jun 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x2b3bfa0 0x2b3bfa0 0x2b3bfa0 approved these changes

Assignees

@DavidGOrtega DavidGOrtega

Labels
bug Something isn't working cml-runner Subcommand enhancement New feature or request technical-debt Refactoring, linting & tidying
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

runner error logs, destructure id of undefined
2 participants
@DavidGOrtega @0x2b3bfa0