Skip to content

Dulwich fails when there's no GCC #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
IWillPull opened this issue May 19, 2022 · 3 comments
Closed

Dulwich fails when there's no GCC #73

IWillPull opened this issue May 19, 2022 · 3 comments

Comments

@IWillPull
Copy link

Basically, this issue is back again in DVC: iterative/dvc#2010

@efiop
Copy link
Contributor

efiop commented May 19, 2022

Looks like dulwich broke wheel build again 🙁 jelmer/dulwich#968 Thanks @dtrifiro for a quick fix.

Looks like we need to set an upper bound on dulwich in scmrepo for now and think about how we can help dulwich releases not break so often.

@efiop
Copy link
Contributor

efiop commented May 19, 2022

For the record:

let's put an upper bound on dulwich and make sure when we test scmrepo we install using --bin-only(or whatever that pip flag is called) to make sure that all wheels are available. That will also help us catch such problems during dependabot's PRs for bumbing dulwich version.

@skshetry
Copy link
Collaborator

I am against putting any upper bound. This is a packaging issue, and these mistakes/bugs happen, which will automatically get fixed with time.

Pinning the dependencies will make it painful for users if other packages also depend in dulwich.
It is also going to be painful for us, since DVC pins scmrepo, so to bump version, we need to also make a release in DVC.

@pmrowla pmrowla closed this as completed Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants