Skip to content

docs: task requirements 2 #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
14 of 21 tasks
casperdcl opened this issue Jan 12, 2022 · 11 comments
Open
14 of 21 tasks

docs: task requirements 2 #363

casperdcl opened this issue Jan 12, 2022 · 11 comments
Labels
documentation Markdown files epic Collection of sub-issues p1-important High priority resource-task iterative_task TF resource

Comments

@casperdcl
Copy link
Contributor

casperdcl commented Jan 12, 2022

p2

p1

@casperdcl casperdcl added documentation Markdown files epic Collection of sub-issues resource-task iterative_task TF resource labels Jan 12, 2022
@DavidGOrtega
Copy link
Contributor

what permissions are required (e.g. port 22 open)?

This is needed for runner. task is not enforced right now to use ssh, we use the cloud storage

@DavidGOrtega
Copy link
Contributor

This are my pics @casperdcl

As far as I see you already have some

README

Automatically destroy unused cloud resources (never forget to turn your GPU off again)

This is not true at current status unless you use runner

TERRAFORM DOCS

  • Why generic machine types are in Development section?
  • Missing specific cloud permissions
  • Missing complete spot instances survival lifecycle (which is the best effort in tgi)
  • CI restart workflow lifecicle and explain also the environment propagation

Create a directory named shared to store input data and output artefacts.

I do not fully undestand this example. Why should the user modify the project structure? If someone is telling me to modify my project to use a tool I would say... F*#$@ U

The script argument can take any string, including a heredoc or the contents of a file returned by the file function.

Is better if we setup an example instead (terraform docs are not great).
Also is very nice the idea of using python scripting as an example

Status and events don't produce a stable output between cloud providers and are intended for human consumption only.

Right now the status is normalised

@0x2b3bfa0
Copy link
Member

This is not true at current status unless you use runner[citation needed]

As far as I can tell, iterative_task terminates all the instances as soon as the script finishes running. 🤔

@0x2b3bfa0
Copy link
Member

Add to the list #258 (comment), “add a documentation footnote that after the task completes its instance is auto destroyed”

@casperdcl
Copy link
Contributor Author

casperdcl commented Feb 15, 2022

Added an item to the p1 checklist here #397 instead :)

@casperdcl casperdcl changed the title docs: task requirements docs: task requirements 2 Feb 15, 2022
@casperdcl casperdcl removed their assignment Feb 15, 2022
@DavidGOrtega
Copy link
Contributor

@casperdcl can you please add these two?

  • Complete spot instances survival lifecycle (which is the best effort in tpi)
  • CI restart workflow lifecycle and explain also the environment propagation

This was referenced Mar 11, 2022
@casperdcl casperdcl added the p1-important High priority label Mar 18, 2022
@omesser
Copy link
Contributor

omesser commented Mar 29, 2022

@casperdcl - suggest to add here the fix to the banner being broken here
Missing banner-terraform.png

@casperdcl
Copy link
Contributor Author

thx added to #450 :)

@casperdcl casperdcl mentioned this issue Apr 19, 2022
17 tasks
@0x2b3bfa0
Copy link
Member

Don't forget this pearl:

@casperdcl
Copy link
Contributor Author

Already done https://registry.terraform.io/providers/iterative/iterative/latest/docs/guides/getting-started#debugging

@0x2b3bfa0
Copy link
Member

🙈 The sad part is that I reviewed that change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Markdown files epic Collection of sub-issues p1-important High priority resource-task iterative_task TF resource
Projects
None yet
Development

No branches or pull requests

4 participants