Skip to content

Commit 213bc5c

Browse files
ivanmorozov333ivanmorozov333
committed
Split ttl tasks by rw address of storages read/write (ydb-platform#2644)
1 parent cc69d3c commit 213bc5c

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

50 files changed

+1255
-492
lines changed

‎ydb/core/tx/columnshard/background_controller.cpp

-5
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,6 @@
33

44
namespace NKikimr::NColumnShard {
55

6-
void TBackgroundController::StartTtl() {
7-
Y_ABORT_UNLESS(!TtlStarted);
8-
TtlStarted = true;
9-
}
10-
116
bool TBackgroundController::StartCompaction(const NOlap::TPlanCompactionInfo& info) {
127
Y_ABORT_UNLESS(ActiveCompactionInfo.emplace(info.GetPathId(), info).second);
138
return true;

‎ydb/core/tx/columnshard/background_controller.h

-10
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,6 @@ class TBackgroundController {
5252
TCurrentCompaction ActiveCompactionInfo;
5353

5454
bool ActiveCleanup = false;
55-
bool TtlStarted = false;
5655
YDB_READONLY(TMonotonic, LastIndexationInstant, TMonotonic::Zero());
5756
public:
5857
THashSet<NOlap::TPortionAddress> GetConflictTTLPortions() const;
@@ -90,15 +89,6 @@ class TBackgroundController {
9089
bool IsCleanupActive() const {
9190
return ActiveCleanup;
9291
}
93-
94-
void StartTtl();
95-
void FinishTtl() {
96-
Y_ABORT_UNLESS(TtlStarted);
97-
TtlStarted = false;
98-
}
99-
bool IsTtlActive() const {
100-
return TtlStarted;
101-
}
10292
};
10393

10494
}

‎ydb/core/tx/columnshard/blobs_action/transaction/tx_write_index.cpp

+3-3
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,10 @@ bool TTxWriteIndex::Execute(TTransactionContext& txc, const TActorContext& ctx)
1313
Y_ABORT_UNLESS(Self->TablesManager.HasPrimaryIndex());
1414
txc.DB.NoMoreReadsForTx();
1515

16-
ACFL_DEBUG("event", "TTxWriteIndex::Execute")("change_type", changes->TypeString())("details", *changes);
16+
ACFL_DEBUG("event", "TTxWriteIndex::Execute")("change_type", changes->TypeString())("details", changes->DebugString());
1717
if (Ev->Get()->GetPutStatus() == NKikimrProto::OK) {
1818
NOlap::TSnapshot snapshot(Self->LastPlannedStep, Self->LastPlannedTxId);
19-
Y_ABORT_UNLESS(Ev->Get()->IndexInfo.GetLastSchema()->GetSnapshot() <= snapshot);
19+
Y_ABORT_UNLESS(Ev->Get()->IndexInfo->GetLastSchema()->GetSnapshot() <= snapshot);
2020

2121
TBlobGroupSelector dsGroupSelector(Self->Info());
2222
NOlap::TDbWrapper dbWrap(txc.DB, &dsGroupSelector);
@@ -51,7 +51,7 @@ void TTxWriteIndex::Complete(const TActorContext& ctx) {
5151
TLogContextGuard gLogging(NActors::TLogContextBuilder::Build(NKikimrServices::TX_COLUMNSHARD)("tablet_id", Self->TabletID()));
5252
CompleteReady = true;
5353
auto changes = Ev->Get()->IndexChanges;
54-
ACFL_DEBUG("event", "TTxWriteIndex::Complete")("change_type", changes->TypeString())("details", *changes);
54+
ACFL_DEBUG("event", "TTxWriteIndex::Complete")("change_type", changes->TypeString())("details", changes->DebugString());
5555

5656
const ui64 blobsWritten = changes->GetBlobsAction().GetWritingBlobsCount();
5757
const ui64 bytesWritten = changes->GetBlobsAction().GetWritingTotalSize();

‎ydb/core/tx/columnshard/columnshard__stats_scan.cpp

+2-2
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ void TStatsIterator::AppendStats(const std::vector<std::unique_ptr<arrow::ArrayB
8383
NArrow::Append<arrow::StringType>(*builders[9], blobIdString);
8484
NArrow::Append<arrow::UInt64Type>(*builders[10], r->BlobRange.Offset);
8585
NArrow::Append<arrow::UInt64Type>(*builders[11], r->BlobRange.Size);
86-
NArrow::Append<arrow::BooleanType>(*builders[12], !portion.HasRemoveSnapshot() || ReadMetadata->GetRequestSnapshot() < portion.GetRemoveSnapshot());
86+
NArrow::Append<arrow::BooleanType>(*builders[12], !portion.IsRemovedFor(ReadMetadata->GetRequestSnapshot()));
8787

8888
const auto tierName = portionSchema->GetIndexInfo().GetEntityStorageId(r->GetColumnId(), portion.GetMeta().GetTierName());
8989
std::string strTierName(tierName.data(), tierName.size());
@@ -114,7 +114,7 @@ void TStatsIterator::AppendStats(const std::vector<std::unique_ptr<arrow::ArrayB
114114
NArrow::Append<arrow::StringType>(*builders[9], blobIdString);
115115
NArrow::Append<arrow::UInt64Type>(*builders[10], r->GetBlobRange().Offset);
116116
NArrow::Append<arrow::UInt64Type>(*builders[11], r->GetBlobRange().Size);
117-
NArrow::Append<arrow::BooleanType>(*builders[12], !portion.HasRemoveSnapshot() || ReadMetadata->GetRequestSnapshot() < portion.GetRemoveSnapshot());
117+
NArrow::Append<arrow::BooleanType>(*builders[12], !portion.IsRemovedFor(ReadMetadata->GetRequestSnapshot()));
118118
const auto tierName = portionSchema->GetIndexInfo().GetEntityStorageId(r->GetIndexId(), portion.GetMeta().GetTierName());
119119
std::string strTierName(tierName.data(), tierName.size());
120120
NArrow::Append<arrow::StringType>(*builders[13], strTierName);

‎ydb/core/tx/columnshard/columnshard_impl.cpp

+27-32
Original file line numberDiff line numberDiff line change
@@ -553,7 +553,7 @@ class TChangesTask: public NConveyor::ITask {
553553
virtual bool DoExecute() override {
554554
NActors::TLogContextGuard g(NActors::TLogContextBuilder::Build(NKikimrServices::TX_COLUMNSHARD)("tablet_id", TabletId)("parent_id", ParentActorId));
555555
{
556-
NOlap::TConstructionContext context(TxEvent->IndexInfo, Counters);
556+
NOlap::TConstructionContext context(*TxEvent->IndexInfo, Counters);
557557
Y_ABORT_UNLESS(TxEvent->IndexChanges->ConstructBlobs(context).Ok());
558558
if (!TxEvent->IndexChanges->GetWritePortionsCount()) {
559559
TxEvent->SetPutStatus(NKikimrProto::OK);
@@ -600,7 +600,8 @@ class TChangesReadTask: public NOlap::NBlobOperations::NRead::ITask {
600600
}
601601
virtual bool DoOnError(const TString& storageId, const NOlap::TBlobRange& range, const NOlap::IBlobsReadingAction::TErrorStatus& status) override {
602602
AFL_DEBUG(NKikimrServices::TX_COLUMNSHARD)("event", "DoOnError")("storage_id", storageId)("blob_id", range)("status", status.GetErrorMessage())("status_code", status.GetStatus());
603-
AFL_VERIFY(false)("blob_id", range)("status", status.GetStatus());
603+
AFL_VERIFY(false)("blob_id", range)("status", status.GetStatus())("error", status.GetErrorMessage())("type", TxEvent->IndexChanges->TypeString())("task_id", TxEvent->IndexChanges->GetTaskIdentifier())
604+
("debug", TxEvent->IndexChanges->DebugString());
604605
TxEvent->SetPutStatus(NKikimrProto::ERROR);
605606
TActorContext::AsActorContext().Send(ParentActorId, std::move(TxEvent));
606607
return false;
@@ -630,9 +631,9 @@ void TColumnShard::StartIndexTask(std::vector<const NOlap::TInsertedData*>&& dat
630631
auto indexChanges = TablesManager.MutablePrimaryIndex().StartInsert(std::move(data));
631632
Y_ABORT_UNLESS(indexChanges);
632633

633-
auto actualIndexInfo = TablesManager.GetPrimaryIndex()->GetVersionedIndex();
634+
auto actualIndexInfo = std::make_shared<NOlap::TVersionedIndex>(TablesManager.GetPrimaryIndex()->GetVersionedIndex());
634635
indexChanges->Start(*this);
635-
auto ev = std::make_unique<TEvPrivate::TEvWriteIndex>(std::move(actualIndexInfo), indexChanges, Settings.CacheDataAfterIndexing);
636+
auto ev = std::make_unique<TEvPrivate::TEvWriteIndex>(actualIndexInfo, indexChanges, Settings.CacheDataAfterIndexing);
636637

637638
const TString externalTaskId = indexChanges->GetTaskIdentifier();
638639
AFL_DEBUG(NKikimrServices::TX_COLUMNSHARD)("event", "indexation")("bytes", bytesToIndex)("blobs_count", dataToIndex.size())("max_limit", (i64)Limits.MaxInsertBytes)
@@ -711,8 +712,8 @@ void TColumnShard::SetupCompaction() {
711712

712713
indexChanges->Start(*this);
713714

714-
auto actualIndexInfo = TablesManager.GetPrimaryIndex()->GetVersionedIndex();
715-
auto ev = std::make_unique<TEvPrivate::TEvWriteIndex>(std::move(actualIndexInfo), indexChanges, Settings.CacheDataAfterCompaction);
715+
auto actualIndexInfo = std::make_shared<NOlap::TVersionedIndex>(TablesManager.GetPrimaryIndex()->GetVersionedIndex());
716+
auto ev = std::make_unique<TEvPrivate::TEvWriteIndex>(actualIndexInfo, indexChanges, Settings.CacheDataAfterCompaction);
716717
const TString externalTaskId = indexChanges->GetTaskIdentifier();
717718
AFL_DEBUG(NKikimrServices::TX_COLUMNSHARD)("event", "compaction")("external_task_id", externalTaskId);
718719

@@ -730,40 +731,34 @@ bool TColumnShard::SetupTtl(const THashMap<ui64, NOlap::TTiering>& pathTtls, con
730731
return false;
731732
}
732733
CSCounters.OnSetupTtl();
733-
if (BackgroundController.IsTtlActive()) {
734-
ACFL_DEBUG("background", "ttl")("skip_reason", "in_progress");
735-
return false;
736-
}
737-
if (force) {
738-
TablesManager.MutablePrimaryIndex().OnTieringModified(Tiers, TablesManager.GetTtl());
739-
}
740734
THashMap<ui64, NOlap::TTiering> eviction = pathTtls;
741735
for (auto&& i : eviction) {
742736
ACFL_DEBUG("background", "ttl")("path", i.first)("info", i.second.GetDebugString());
743737
}
744738

745-
auto actualIndexInfo = TablesManager.GetPrimaryIndex()->GetVersionedIndex();
739+
auto actualIndexInfo = std::make_shared<NOlap::TVersionedIndex>(TablesManager.GetPrimaryIndex()->GetVersionedIndex());
746740
const ui64 memoryUsageLimit = HasAppData() ? AppDataVerified().ColumnShardConfig.GetTieringsMemoryLimit() : ((ui64)512 * 1024 * 1024);
747-
std::shared_ptr<NOlap::TTTLColumnEngineChanges> indexChanges = TablesManager.MutablePrimaryIndex().StartTtl(eviction, DataLocksManager, memoryUsageLimit);
741+
std::vector<std::shared_ptr<NOlap::TTTLColumnEngineChanges>> indexChanges = TablesManager.MutablePrimaryIndex().StartTtl(eviction, DataLocksManager, memoryUsageLimit);
748742

749-
if (!indexChanges) {
743+
if (indexChanges.empty()) {
750744
ACFL_DEBUG("background", "ttl")("skip_reason", "no_changes");
751745
return false;
752746
}
753-
const TString externalTaskId = indexChanges->GetTaskIdentifier();
754-
const bool needWrites = indexChanges->NeedConstruction();
755-
ACFL_DEBUG("background", "ttl")("need_writes", needWrites);
756-
757-
indexChanges->Start(*this);
758-
auto ev = std::make_unique<TEvPrivate::TEvWriteIndex>(std::move(actualIndexInfo), indexChanges, false);
759-
NYDBTest::TControllers::GetColumnShardController()->OnWriteIndexStart(TabletID(), indexChanges->TypeString());
760-
if (needWrites) {
761-
NOlap::NResourceBroker::NSubscribe::ITask::StartResourceSubscription(
762-
ResourceSubscribeActor, std::make_shared<NOlap::NBlobOperations::NRead::ITask::TReadSubscriber>(
763-
std::make_shared<TChangesReadTask>(std::move(ev), SelfId(), TabletID(), CompactionCounters), 0, indexChanges->CalcMemoryForUsage(), externalTaskId, TTLTaskSubscription));
764-
} else {
765-
ev->SetPutStatus(NKikimrProto::OK);
766-
ActorContext().Send(SelfId(), std::move(ev));
747+
for (auto&& i : indexChanges) {
748+
const TString externalTaskId = i->GetTaskIdentifier();
749+
const bool needWrites = i->NeedConstruction();
750+
ACFL_DEBUG("background", "ttl")("need_writes", needWrites);
751+
i->Start(*this);
752+
auto ev = std::make_unique<TEvPrivate::TEvWriteIndex>(actualIndexInfo, i, false);
753+
NYDBTest::TControllers::GetColumnShardController()->OnWriteIndexStart(TabletID(), i->TypeString());
754+
if (needWrites) {
755+
NOlap::NResourceBroker::NSubscribe::ITask::StartResourceSubscription(
756+
ResourceSubscribeActor, std::make_shared<NOlap::NBlobOperations::NRead::ITask::TReadSubscriber>(
757+
std::make_shared<TChangesReadTask>(std::move(ev), SelfId(), TabletID(), CompactionCounters), 0, i->CalcMemoryForUsage(), externalTaskId, TTLTaskSubscription));
758+
} else {
759+
ev->SetPutStatus(NKikimrProto::OK);
760+
ActorContext().Send(SelfId(), std::move(ev));
761+
}
767762
}
768763
return true;
769764
}
@@ -784,8 +779,8 @@ void TColumnShard::SetupCleanup() {
784779
}
785780

786781
ACFL_DEBUG("background", "cleanup")("changes_info", changes->DebugString());
787-
auto actualIndexInfo = TablesManager.GetPrimaryIndex()->GetVersionedIndex();
788-
auto ev = std::make_unique<TEvPrivate::TEvWriteIndex>(std::move(actualIndexInfo), changes, false);
782+
auto actualIndexInfo = std::make_shared<NOlap::TVersionedIndex>(TablesManager.GetPrimaryIndex()->GetVersionedIndex());
783+
auto ev = std::make_unique<TEvPrivate::TEvWriteIndex>(actualIndexInfo, changes, false);
789784
ev->SetPutStatus(NKikimrProto::OK); // No new blobs to write
790785

791786
changes->Start(*this);

‎ydb/core/tx/columnshard/columnshard_private_events.h

+3-3
Original file line numberDiff line numberDiff line change
@@ -75,18 +75,18 @@ struct TEvPrivate {
7575

7676
/// Common event for Indexing and GranuleCompaction: write index data in TTxWriteIndex transaction.
7777
struct TEvWriteIndex : public TEventLocal<TEvWriteIndex, EvWriteIndex> {
78-
NOlap::TVersionedIndex IndexInfo;
78+
std::shared_ptr<NOlap::TVersionedIndex> IndexInfo;
7979
std::shared_ptr<NOlap::TColumnEngineChanges> IndexChanges;
8080
bool GranuleCompaction{false};
8181
TUsage ResourceUsage;
8282
bool CacheData{false};
8383
TDuration Duration;
8484
TBlobPutResult::TPtr PutResult;
8585

86-
TEvWriteIndex(NOlap::TVersionedIndex&& indexInfo,
86+
TEvWriteIndex(const std::shared_ptr<NOlap::TVersionedIndex>& indexInfo,
8787
std::shared_ptr<NOlap::TColumnEngineChanges> indexChanges,
8888
bool cacheData)
89-
: IndexInfo(std::move(indexInfo))
89+
: IndexInfo(indexInfo)
9090
, IndexChanges(indexChanges)
9191
, CacheData(cacheData)
9292
{

‎ydb/core/tx/columnshard/counters/engine_logs.cpp

+22
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,21 @@ TEngineLogsCounters::TEngineLogsCounters()
3838

3939
PortionToDropCount = TBase::GetDeriviative("Ttl/PortionToDrop/Count");
4040
PortionToDropBytes = TBase::GetDeriviative("Ttl/PortionToDrop/Bytes");
41+
PortionToDropLag = TBase::GetHistogram("Ttl/PortionToDrop/Lag/Duration", NMonitoring::ExponentialHistogram(18, 2, 5));
42+
SkipDeleteWithProcessMemory = TBase::GetHistogram("Ttl/PortionToDrop/Skip/ProcessMemory/Lag/Duration", NMonitoring::ExponentialHistogram(18, 2, 5));
43+
SkipDeleteWithTxLimit = TBase::GetHistogram("Ttl/PortionToDrop/Skip/TxLimit/Lag/Duration", NMonitoring::ExponentialHistogram(18, 2, 5));
4144

4245
PortionToEvictCount = TBase::GetDeriviative("Ttl/PortionToEvict/Count");
4346
PortionToEvictBytes = TBase::GetDeriviative("Ttl/PortionToEvict/Bytes");
47+
PortionToEvictLag = TBase::GetHistogram("Ttl/PortionToEvict/Lag/Duration", NMonitoring::ExponentialHistogram(18, 2, 5));
48+
SkipEvictionWithProcessMemory = TBase::GetHistogram("Ttl/PortionToEvict/Skip/ProcessMemory/Lag/Duration", NMonitoring::ExponentialHistogram(18, 2, 5));
49+
SkipEvictionWithTxLimit = TBase::GetHistogram("Ttl/PortionToEvict/Skip/TxLimit/Lag/Duration", NMonitoring::ExponentialHistogram(18, 2, 5));
50+
51+
ActualizationTaskSizeRemove = TBase::GetHistogram("Actualization/RemoveTasks/Size", NMonitoring::ExponentialHistogram(18, 2));
52+
ActualizationTaskSizeEvict = TBase::GetHistogram("Actualization/EvictTasks/Size", NMonitoring::ExponentialHistogram(18, 2));
53+
54+
ActualizationSkipRWProgressCount = TBase::GetDeriviative("Actualization/Skip/RWProgress/Count");
55+
ActualizationSkipTooFreshPortion = TBase::GetHistogram("Actualization//Skip/TooFresh/Duration", NMonitoring::LinearHistogram(12, 0, 360));
4456

4557
PortionNoTtlColumnCount = TBase::GetDeriviative("Ttl/PortionNoTtlColumn/Count");
4658
PortionNoTtlColumnBytes = TBase::GetDeriviative("Ttl/PortionNoTtlColumn/Bytes");
@@ -52,6 +64,16 @@ TEngineLogsCounters::TEngineLogsCounters()
5264
ChunkUsageForTTLCount = TBase::GetDeriviative("Ttl/ChunkUsageForTTLCount/Count");
5365
}
5466

67+
void TEngineLogsCounters::OnActualizationTask(const ui32 evictCount, const ui32 removeCount) const {
68+
AFL_VERIFY(evictCount * removeCount == 0)("evict", evictCount)("remove", removeCount);
69+
AFL_VERIFY(evictCount + removeCount);
70+
if (evictCount) {
71+
ActualizationTaskSizeEvict->Collect(evictCount);
72+
} else {
73+
ActualizationTaskSizeRemove->Collect(removeCount);
74+
}
75+
}
76+
5577
void TEngineLogsCounters::TPortionsInfoGuard::OnNewPortion(const std::shared_ptr<NOlap::TPortionInfo>& portion) const {
5678
const ui32 producedId = (ui32)(portion->HasRemoveSnapshot() ? NOlap::NPortion::EProduced::INACTIVE : portion->GetMeta().Produced);
5779
Y_ABORT_UNLESS(producedId < BlobGuards.size());

‎ydb/core/tx/columnshard/counters/engine_logs.h

+43-2
Original file line numberDiff line numberDiff line change
@@ -236,9 +236,21 @@ class TEngineLogsCounters: public TCommonCountersOwner {
236236
using TBase = TCommonCountersOwner;
237237
NMonitoring::TDynamicCounters::TCounterPtr PortionToDropCount;
238238
NMonitoring::TDynamicCounters::TCounterPtr PortionToDropBytes;
239+
NMonitoring::THistogramPtr PortionToDropLag;
240+
NMonitoring::THistogramPtr SkipDeleteWithProcessMemory;
241+
NMonitoring::THistogramPtr SkipDeleteWithTxLimit;
239242

240243
NMonitoring::TDynamicCounters::TCounterPtr PortionToEvictCount;
241244
NMonitoring::TDynamicCounters::TCounterPtr PortionToEvictBytes;
245+
NMonitoring::THistogramPtr PortionToEvictLag;
246+
NMonitoring::THistogramPtr SkipEvictionWithProcessMemory;
247+
NMonitoring::THistogramPtr SkipEvictionWithTxLimit;
248+
249+
NMonitoring::THistogramPtr ActualizationTaskSizeRemove;
250+
NMonitoring::THistogramPtr ActualizationTaskSizeEvict;
251+
252+
NMonitoring::TDynamicCounters::TCounterPtr ActualizationSkipRWProgressCount;
253+
NMonitoring::THistogramPtr ActualizationSkipTooFreshPortion;
242254

243255
NMonitoring::TDynamicCounters::TCounterPtr PortionNoTtlColumnCount;
244256
NMonitoring::TDynamicCounters::TCounterPtr PortionNoTtlColumnBytes;
@@ -253,6 +265,7 @@ class TEngineLogsCounters: public TCommonCountersOwner {
253265
std::vector<std::shared_ptr<TIncrementalHistogram>> BlobSizeDistribution;
254266
std::vector<std::shared_ptr<TIncrementalHistogram>> PortionSizeDistribution;
255267
std::vector<std::shared_ptr<TIncrementalHistogram>> PortionRecordsDistribution;
268+
256269
public:
257270

258271
class TPortionsInfoGuard {
@@ -282,6 +295,8 @@ class TEngineLogsCounters: public TCommonCountersOwner {
282295

283296
};
284297

298+
void OnActualizationTask(const ui32 evictCount, const ui32 removeCount) const;
299+
285300
TPortionsInfoGuard BuildPortionBlobsGuard() const {
286301
return TPortionsInfoGuard(BlobSizeDistribution, PortionSizeDistribution, PortionRecordsDistribution);
287302
}
@@ -290,14 +305,40 @@ class TEngineLogsCounters: public TCommonCountersOwner {
290305
return GranuleDataAgent.RegisterClient();
291306
}
292307

293-
void OnPortionToEvict(const ui64 size) const {
308+
void OnActualizationSkipRWProgress() const {
309+
ActualizationSkipRWProgressCount->Add(1);
310+
}
311+
312+
void OnActualizationSkipTooFreshPortion(const TDuration dWait) const {
313+
ActualizationSkipTooFreshPortion->Collect(dWait.Seconds());
314+
}
315+
316+
void OnSkipDeleteWithProcessMemory(const TDuration lag) const {
317+
SkipDeleteWithProcessMemory->Collect(lag.Seconds());
318+
}
319+
320+
void OnSkipDeleteWithTxLimit(const TDuration lag) const {
321+
SkipDeleteWithTxLimit->Collect(lag.Seconds());
322+
}
323+
324+
void OnSkipEvictionWithProcessMemory(const TDuration lag) const {
325+
SkipEvictionWithProcessMemory->Collect(lag.Seconds());
326+
}
327+
328+
void OnSkipEvictionWithTxLimit(const TDuration lag) const {
329+
SkipEvictionWithTxLimit->Collect(lag.Seconds());
330+
}
331+
332+
void OnPortionToEvict(const ui64 size, const TDuration lag) const {
294333
PortionToEvictCount->Add(1);
295334
PortionToEvictBytes->Add(size);
335+
PortionToEvictLag->Collect(lag.Seconds());
296336
}
297337

298-
void OnPortionToDrop(const ui64 size) const {
338+
void OnPortionToDrop(const ui64 size, const TDuration lag) const {
299339
PortionToDropCount->Add(1);
300340
PortionToDropBytes->Add(size);
341+
PortionToDropLag->Collect(lag.Seconds());
301342
}
302343

303344
void OnPortionNoTtlColumn(const ui64 size) const {

0 commit comments

Comments
 (0)