Skip to content

Commit bcca769

Browse files
gabalafouivanov
authored andcommitted
Move CSS block out of SCSS vars file (pydata#1832)
I think files like `variables.scss` should probably only contain Sass variables and not CSS variables. At least, that's what Bootstrap's variables.scss (https://github.com/twbs/bootstrap/blob/main/scss/_variables.scss) file does, as far as I can tell.
1 parent ef1978f commit bcca769

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

src/pydata_sphinx_theme/assets/styles/extensions/_bootstrap.scss

+4
Original file line numberDiff line numberDiff line change
@@ -13,3 +13,7 @@
1313
max-width: unset;
1414
width: unset;
1515
}
16+
17+
.btn {
18+
--bs-btn-focus-box-shadow: #{$btn-focus-box-shadow};
19+
}

src/pydata_sphinx_theme/assets/styles/variables/_bootstrap.scss

-4
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,3 @@ $focus-ring-box-shadow: 0 0 $focus-ring-blur $focus-ring-width $focus-ring-color
3131
// outline creates the same style of focus ring, it just uses CSS outline instead of box shadow
3232
$focus-ring-outline: $focus-ring-color solid $focus-ring-width;
3333
$btn-focus-box-shadow: $focus-ring-box-shadow;
34-
35-
.btn {
36-
--bs-btn-focus-box-shadow: #{$btn-focus-box-shadow};
37-
}

0 commit comments

Comments
 (0)