Skip to content

implement 'realpath' in Host to properly resolve symlinks #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vladima opened this issue May 17, 2016 · 3 comments
Closed

implement 'realpath' in Host to properly resolve symlinks #349

vladima opened this issue May 17, 2016 · 3 comments
Labels

Comments

@vladima
Copy link
Contributor

vladima commented May 17, 2016

With microsoft/TypeScript#8486 it is now possible to follow symlinks obtained as a result of module resolution to its actual location. In order to support this custom implementations of CompilerHost should expose realpath function which will be called by the compiler as an epilogue of node module resolution.

@ivogabe ivogabe added the Bug label May 17, 2016
@octogonz
Copy link

For context, the realpath function is a fix for a real bug that my project encountered when using the "npm link" command. For a repro, try running build.cmd from this archive:

NpmLinkRepro2.tar.gz

@kruncher
Copy link

I am experiencing the symlink issue whilst using TypeScript with gulp-typescript.

I tried following the following advise from the readme of this project:

npm install typescript@next
...
Or in combination with a tsconfig file:

var tsProject = ts.createProject('tsconfig.json', {
    typescript: require('typescript')
});

However the issue still persists and I am not entirely sure whether gulp-typescript is using the latest development build or the older one that still exhibits this issue.

Many thanks

@ivogabe
Copy link
Owner

ivogabe commented May 26, 2016

@kruncher symlinks were not supported yet when you wrote that, that was what this issue was tracking. You can now try the latest version, which should support them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants