Skip to content

Commit b639560

Browse files
j-c-cookj-c-cookzariiii9003
authored
Modify file_size help doc string (hardbyte#1401)
* Modify `file_size` help doc string * Add note to BLFWriter * Revert "Add note to BLFWriter" This reverts commit 18241ac. * Add in a note about the nuanced file size in help statement based on input from @zariiii9003 * Modify help statement to clarify consistency * Minor tweak * Control BLFWriter max container size * Fix formatting * Update can/logger.py Co-authored-by: zariiii9003 <[email protected]> * Revert "Fix formatting" This reverts commit 3afb140. * Revert "Control BLFWriter max container size" This reverts commit c39719c. Co-authored-by: j-c-cook <[email protected]> Co-authored-by: zariiii9003 <[email protected]>
1 parent a144f25 commit b639560

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

can/logger.py

+4-3
Original file line numberDiff line numberDiff line change
@@ -193,9 +193,10 @@ def main() -> None:
193193
"--file_size",
194194
dest="file_size",
195195
type=int,
196-
help="Maximum file size in bytes (or for the case of blf, maximum "
197-
"buffer size before compression and flush to file). Rotate log "
198-
"file when size threshold is reached.",
196+
help="Maximum file size in bytes. Rotate log file when size threshold "
197+
"is reached. (The resulting file sizes will be consistent, but are not "
198+
"guaranteed to be exactly what is specified here due to the rollover "
199+
"conditions being logger implementation specific.)",
199200
default=None,
200201
)
201202

0 commit comments

Comments
 (0)