Skip to content

Commit 0a0c5e8

Browse files
committed
chore(dependency): upgrade spring boot from 2.7.x to 3.0.x and spring cloud from 2021.0.x to 2022.0.x
Upgrading spring boot 2.7.18 to 3.0.13 and spring cloud 2021.0.8 to 2022.0.5. Spring cloud release 2022.0.x is compatible with spring boot 3.0.x. https://github.com/spring-cloud/spring-cloud-release/wiki/Supported-Versions#supported-releases ====================================================== refactor(dependency): replace javax with jakarta, javax.inject with jakarta.inject, rxjava with rxjava3 and add resilience4j-vavr during upgrade of spring boot 3.0.x Spring Boot 3.0 has migrated from Java EE to Jakarta EE APIs for all dependencies. https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-3.0-Release-Notes#third-party-library-upgrades So, replacing the imports with `javax` to `jakarta`. Spring boot 3.x deprecated and removed rxjava, and rxjava3 has been added. So, update the dependency. https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-3.0-Migration-Guide#rxjava `io.vavr` dependency has been removed from resilience4j:2.0.2. https://github.com/resilience4j/resilience4j/releases/tag/v2.0.0 Resilience4j comes as transitive dependency of spring-cloud-dependencies. https://mvnrepository.com/artifact/org.springframework.cloud/spring-cloud-dependencies/2022.0.5 So, adding explicit dependency of `resilience4j-vavr` `javax.inject` that has been moved from present coordinate to `jakarta.inject`. So, updating the coordinates in igor-web module. google/guice#1463 google/guice#1383 https://docs.openrewrite.org/recipes/java/migrate/jakarta/javaxinjectmigrationtojakartainject
1 parent c2f8691 commit 0a0c5e8

27 files changed

+41
-39
lines changed

igor-core/igor-core.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ dependencies {
33
implementation "io.spinnaker.kork:kork-core"
44
implementation "io.spinnaker.kork:kork-jedis"
55
implementation "io.spinnaker.fiat:fiat-core:$fiatVersion"
6-
implementation "javax.validation:validation-api"
6+
implementation "jakarta.validation:jakarta.validation-api"
77

88
// TODO(rz): Get rid of this dependency!
99
implementation "com.squareup.retrofit:retrofit"

igor-core/src/main/java/com/netflix/spinnaker/igor/artifacts/JinjaTemplateService.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@
1717
package com.netflix.spinnaker.igor.artifacts;
1818

1919
import com.netflix.spinnaker.igor.config.ArtifactTemplateProperties;
20+
import jakarta.annotation.PostConstruct;
2021
import java.util.Map;
21-
import javax.annotation.PostConstruct;
2222
import org.springframework.beans.factory.annotation.Autowired;
2323
import org.springframework.stereotype.Component;
2424

igor-core/src/main/java/com/netflix/spinnaker/igor/config/ArtifactDecorationProperties.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,9 @@
1616

1717
package com.netflix.spinnaker.igor.config;
1818

19+
import jakarta.validation.Valid;
20+
import jakarta.validation.constraints.NotEmpty;
1921
import java.util.List;
20-
import javax.validation.Valid;
21-
import javax.validation.constraints.NotEmpty;
2222
import lombok.Data;
2323
import org.springframework.boot.context.properties.ConfigurationProperties;
2424
import org.springframework.context.annotation.Configuration;

igor-core/src/main/java/com/netflix/spinnaker/igor/config/ArtifactTemplateProperties.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,12 @@
1717
package com.netflix.spinnaker.igor.config;
1818

1919
import com.netflix.spinnaker.igor.artifacts.CustomJinjaTemplate;
20+
import jakarta.validation.Valid;
21+
import jakarta.validation.constraints.NotEmpty;
2022
import java.util.ArrayList;
2123
import java.util.List;
2224
import java.util.Map;
2325
import java.util.stream.Collectors;
24-
import javax.validation.Valid;
25-
import javax.validation.constraints.NotEmpty;
2626
import lombok.Data;
2727
import lombok.NoArgsConstructor;
2828
import org.springframework.boot.context.properties.ConfigurationProperties;

igor-core/src/main/java/com/netflix/spinnaker/igor/polling/CommonPollingMonitor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
import com.netflix.spinnaker.kork.discovery.DiscoveryStatusListener;
2424
import com.netflix.spinnaker.kork.discovery.RemoteStatusChangedEvent;
2525
import com.netflix.spinnaker.kork.dynamicconfig.DynamicConfigService;
26+
import jakarta.annotation.PreDestroy;
2627
import java.time.Duration;
2728
import java.util.Map;
2829
import java.util.Optional;
@@ -32,7 +33,6 @@
3233
import java.util.concurrent.atomic.AtomicInteger;
3334
import java.util.concurrent.atomic.AtomicLong;
3435
import javax.annotation.Nullable;
35-
import javax.annotation.PreDestroy;
3636
import net.logstash.logback.argument.StructuredArguments;
3737
import org.apache.commons.lang3.StringUtils;
3838
import org.slf4j.Logger;

igor-core/src/main/java/com/netflix/spinnaker/igor/service/ArtifactDecorator.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,12 +21,12 @@
2121
import com.netflix.spinnaker.igor.build.model.GenericArtifact;
2222
import com.netflix.spinnaker.igor.build.model.GenericBuild;
2323
import com.netflix.spinnaker.igor.config.ArtifactDecorationProperties;
24+
import jakarta.validation.Valid;
2425
import java.util.ArrayList;
2526
import java.util.Collections;
2627
import java.util.List;
2728
import java.util.Optional;
2829
import java.util.stream.Collectors;
29-
import javax.validation.Valid;
3030
import lombok.extern.slf4j.Slf4j;
3131
import org.springframework.beans.factory.annotation.Autowired;
3232
import org.springframework.boot.autoconfigure.condition.ConditionalOnProperty;

igor-monitor-travis/igor-monitor-travis.gradle

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,9 @@ dependencies {
3131
implementation "com.jakewharton.retrofit:retrofit1-okhttp3-client"
3232
implementation "com.squareup.retrofit:converter-jackson"
3333
implementation "com.squareup.retrofit:retrofit"
34-
implementation "io.reactivex:rxjava" // TODO(jervi): get rid of this dependency
35-
implementation "javax.validation:validation-api"
34+
implementation "io.github.resilience4j:resilience4j-vavr"
35+
implementation "io.reactivex.rxjava3:rxjava" // TODO(jervi): get rid of this dependency
36+
implementation "jakarta.validation:jakarta.validation-api"
3637
implementation "javax.xml.bind:jaxb-api"
3738

3839
testImplementation "com.squareup.okhttp3:mockwebserver"

igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/config/TravisConfig.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,13 +29,13 @@
2929
import com.netflix.spinnaker.kork.retrofit.exceptions.SpinnakerRetrofitErrorHandler;
3030
import com.netflix.spinnaker.retrofit.Slf4jRetrofitLogger;
3131
import io.github.resilience4j.circuitbreaker.CircuitBreakerRegistry;
32+
import jakarta.validation.Valid;
3233
import java.util.ArrayList;
3334
import java.util.Map;
3435
import java.util.Optional;
3536
import java.util.concurrent.TimeUnit;
3637
import java.util.function.Function;
3738
import java.util.stream.Collectors;
38-
import javax.validation.Valid;
3939
import lombok.extern.slf4j.Slf4j;
4040
import okhttp3.OkHttpClient;
4141
import org.springframework.boot.autoconfigure.condition.ConditionalOnProperty;

igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/config/TravisProperties.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,11 @@
1919

2020
import com.netflix.spinnaker.fiat.model.resources.Permissions;
2121
import com.netflix.spinnaker.igor.config.BuildServerProperties;
22+
import jakarta.validation.Valid;
23+
import jakarta.validation.constraints.NotEmpty;
2224
import java.util.Collection;
2325
import java.util.Collections;
2426
import java.util.List;
25-
import javax.validation.Valid;
26-
import javax.validation.constraints.NotEmpty;
2727
import lombok.Data;
2828
import lombok.extern.slf4j.Slf4j;
2929
import org.springframework.boot.context.properties.ConfigurationProperties;

igor-web/igor-web.gradle

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -71,8 +71,8 @@ dependencies {
7171
implementation "io.projectreactor:reactor-core"
7272
implementation "com.google.code.gson:gson"
7373
implementation "com.google.guava:guava"
74-
implementation "javax.inject:javax.inject:1"
75-
implementation "javax.validation:validation-api"
74+
implementation "jakarta.inject:jakarta.inject-api:2.0.1"
75+
implementation "jakarta.validation:jakarta.validation-api"
7676

7777
runtimeOnly "io.spinnaker.kork:kork-runtime"
7878

@@ -83,5 +83,6 @@ dependencies {
8383
testImplementation "org.junit.jupiter:junit-jupiter-api"
8484
testImplementation "org.assertj:assertj-core"
8585

86-
testImplementation "com.github.tomakehurst:wiremock-jre8"
86+
testImplementation "com.github.tomakehurst:wiremock-jre8-standalone"
87+
testImplementation "com.netflix.spectator:spectator-reg-micrometer"
8788
}

igor-web/src/main/groovy/com/netflix/spinnaker/igor/build/BuildController.groovy

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ import org.springframework.web.servlet.HandlerMapping
4949
import retrofit.http.Query
5050

5151
import javax.annotation.Nullable
52-
import javax.servlet.http.HttpServletRequest
52+
import jakarta.servlet.http.HttpServletRequest
5353

5454
import static net.logstash.logback.argument.StructuredArguments.kv
5555
import static org.springframework.http.HttpStatus.NOT_FOUND

igor-web/src/main/groovy/com/netflix/spinnaker/igor/build/InfoController.groovy

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ import org.springframework.web.bind.annotation.RequestParam
3535
import org.springframework.web.bind.annotation.RestController
3636
import org.springframework.web.servlet.HandlerMapping
3737

38-
import javax.servlet.http.HttpServletRequest
38+
import jakarta.servlet.http.HttpServletRequest
3939

4040
/**
4141
* A controller that provides jenkins information

igor-web/src/main/groovy/com/netflix/spinnaker/igor/config/BitBucketConfig.groovy

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ import retrofit.Endpoints
3232
import retrofit.RequestInterceptor
3333
import retrofit.RestAdapter
3434
import retrofit.converter.JacksonConverter
35-
import javax.validation.Valid
35+
import jakarta.validation.Valid
3636

3737
/**
3838
* Converts the list of BitBucket Configuration properties a collection of clients to access the BitBucket hosts

igor-web/src/main/groovy/com/netflix/spinnaker/igor/config/BitBucketProperties.groovy

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ import groovy.transform.CompileStatic
2020
import org.hibernate.validator.constraints.NotEmpty
2121
import org.springframework.boot.autoconfigure.condition.ConditionalOnProperty
2222
import org.springframework.boot.context.properties.ConfigurationProperties
23-
import javax.validation.constraints.NotNull
23+
import jakarta.validation.constraints.NotNull
2424

2525
/**
2626
* Helper class to map masters in properties file into a validated property map

igor-web/src/main/groovy/com/netflix/spinnaker/igor/config/GitHubConfig.groovy

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ import retrofit.RequestInterceptor
3333
import retrofit.RestAdapter
3434
import retrofit.converter.JacksonConverter
3535

36-
import javax.validation.Valid
36+
import jakarta.validation.Valid
3737

3838
/**
3939
* Converts the list of GitHub Configuration properties a collection of clients to access the GitHub hosts

igor-web/src/main/groovy/com/netflix/spinnaker/igor/config/GitHubProperties.groovy

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ import org.hibernate.validator.constraints.NotEmpty
2121
import org.springframework.boot.autoconfigure.condition.ConditionalOnProperty
2222
import org.springframework.boot.context.properties.ConfigurationProperties
2323

24-
import javax.validation.constraints.NotNull
24+
import jakarta.validation.constraints.NotNull
2525

2626
/**
2727
* Helper class to map masters in properties file into a validated property map

igor-web/src/main/groovy/com/netflix/spinnaker/igor/config/GitLabConfig.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
import com.netflix.spinnaker.igor.scm.gitlab.client.GitLabClient;
2121
import com.netflix.spinnaker.igor.scm.gitlab.client.GitLabMaster;
2222
import com.netflix.spinnaker.retrofit.Slf4jRetrofitLogger;
23-
import javax.validation.Valid;
23+
import jakarta.validation.Valid;
2424
import org.slf4j.Logger;
2525
import org.slf4j.LoggerFactory;
2626
import org.springframework.boot.autoconfigure.condition.ConditionalOnProperty;

igor-web/src/main/groovy/com/netflix/spinnaker/igor/config/GitLabProperties.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
package com.netflix.spinnaker.igor.config;
1818

19-
import javax.validation.constraints.NotNull;
19+
import jakarta.validation.constraints.NotNull;
2020
import org.hibernate.validator.constraints.NotEmpty;
2121
import org.springframework.boot.autoconfigure.condition.ConditionalOnProperty;
2222
import org.springframework.boot.context.properties.ConfigurationProperties;

igor-web/src/main/groovy/com/netflix/spinnaker/igor/config/GitlabCiProperties.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,9 @@
1616
package com.netflix.spinnaker.igor.config;
1717

1818
import com.netflix.spinnaker.fiat.model.resources.Permissions;
19+
import jakarta.validation.Valid;
1920
import java.util.ArrayList;
2021
import java.util.List;
21-
import javax.validation.Valid;
2222
import org.hibernate.validator.constraints.NotEmpty;
2323
import org.springframework.boot.context.properties.ConfigurationProperties;
2424
import org.springframework.validation.annotation.Validated;

igor-web/src/main/groovy/com/netflix/spinnaker/igor/config/JenkinsConfig.groovy

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ import javax.net.ssl.SSLContext
5353
import javax.net.ssl.TrustManager
5454
import javax.net.ssl.TrustManagerFactory
5555
import javax.net.ssl.X509TrustManager
56-
import javax.validation.Valid
56+
import jakarta.validation.Valid
5757
import java.security.KeyStore
5858
import java.security.cert.CertificateException
5959
import java.security.cert.X509Certificate

igor-web/src/main/groovy/com/netflix/spinnaker/igor/config/JenkinsProperties.groovy

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ import org.hibernate.validator.constraints.NotEmpty
2222
import org.springframework.boot.context.properties.ConfigurationProperties
2323
import org.springframework.validation.annotation.Validated
2424

25-
import javax.validation.Valid
25+
import jakarta.validation.Valid
2626
import java.security.KeyStore
2727

2828
/**

igor-web/src/main/groovy/com/netflix/spinnaker/igor/config/StashConfig.groovy

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ import retrofit.RestAdapter
3333
import retrofit.converter.JacksonConverter
3434
import com.netflix.spinnaker.kork.retrofit.exceptions.SpinnakerRetrofitErrorHandler;
3535

36-
import javax.validation.Valid
36+
import jakarta.validation.Valid
3737

3838
/**
3939
* Converts the list of Stash Configuration properties a collection of clients to access the Stash hosts

igor-web/src/main/groovy/com/netflix/spinnaker/igor/config/WerckerConfig.groovy

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ import retrofit.converter.JacksonConverter
3232

3333
import java.util.concurrent.TimeUnit
3434

35-
import javax.validation.Valid
35+
import jakarta.validation.Valid
3636

3737
import retrofit.Endpoints
3838
import retrofit.RestAdapter

igor-web/src/main/groovy/com/netflix/spinnaker/igor/config/WerckerProperties.groovy

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import groovy.transform.CompileStatic
1313
import org.hibernate.validator.constraints.NotEmpty
1414
import org.springframework.boot.context.properties.ConfigurationProperties
1515

16-
import javax.validation.Valid
16+
import jakarta.validation.Valid
1717

1818
/**
1919
* Helper class to map masters in properties file into a validated property map

igor-web/src/main/groovy/com/netflix/spinnaker/igor/filters/IgorCorsFilter.groovy

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -19,13 +19,13 @@ package com.netflix.spinnaker.igor.filters
1919
import groovy.transform.CompileStatic
2020
import org.springframework.stereotype.Component
2121

22-
import javax.servlet.Filter
23-
import javax.servlet.FilterChain
24-
import javax.servlet.FilterConfig
25-
import javax.servlet.ServletException
26-
import javax.servlet.ServletRequest
27-
import javax.servlet.ServletResponse
28-
import javax.servlet.http.HttpServletResponse
22+
import jakarta.servlet.Filter
23+
import jakarta.servlet.FilterChain
24+
import jakarta.servlet.FilterConfig
25+
import jakarta.servlet.ServletException
26+
import jakarta.servlet.ServletRequest
27+
import jakarta.servlet.ServletResponse
28+
import jakarta.servlet.http.HttpServletResponse
2929

3030
/**
3131
* A filter to enable CORS access

igor-web/src/main/groovy/com/netflix/spinnaker/igor/scm/bitbucket/client/BitBucketMaster.groovy

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ import retrofit.Endpoints
2727
import retrofit.RequestInterceptor
2828
import retrofit.RestAdapter
2929
import retrofit.converter.JacksonConverter
30-
import javax.validation.Valid
30+
import jakarta.validation.Valid
3131

3232
/**
3333
* Wrapper class for a collection of BitBucket clients

igor-web/src/main/java/com/netflix/spinnaker/igor/config/ConcourseConfig.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,13 @@
55
import com.netflix.spinnaker.igor.concourse.service.ConcourseService;
66
import com.netflix.spinnaker.igor.service.ArtifactDecorator;
77
import com.netflix.spinnaker.igor.service.BuildServices;
8+
import jakarta.validation.Valid;
89
import java.util.Collections;
910
import java.util.List;
1011
import java.util.Map;
1112
import java.util.Optional;
1213
import java.util.function.Function;
1314
import java.util.stream.Collectors;
14-
import javax.validation.Valid;
1515
import org.springframework.boot.autoconfigure.condition.ConditionalOnProperty;
1616
import org.springframework.boot.context.properties.EnableConfigurationProperties;
1717
import org.springframework.context.annotation.Bean;

0 commit comments

Comments
 (0)