Skip to content

Commit 0fe9195

Browse files
committed
refactor: use slices.Clone and slices.Replace
1 parent 1061abf commit 0fe9195

File tree

2 files changed

+5
-7
lines changed

2 files changed

+5
-7
lines changed

Diff for: editor/editor.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import (
44
"fmt"
55
"os"
66
"os/exec"
7+
"slices"
78
"strings"
89
"text/template"
910

@@ -72,8 +73,7 @@ func (ed *editor) substituteArgs(result *lang.GenerateResult) ([]string, error)
7273
TestCasesFile: getPath(lang.TestCasesFile),
7374
}
7475

75-
args := make([]string, len(ed.args))
76-
copy(args, ed.args)
76+
args := slices.Clone(ed.args)
7777
for i, arg := range args {
7878
if !strings.Contains(arg, "{{") {
7979
continue
@@ -99,7 +99,7 @@ func (ed *editor) substituteArgs(result *lang.GenerateResult) ([]string, error)
9999
for j, f := range result.Files {
100100
allFiles[j] = f.GetPath()
101101
}
102-
args = append(args[:i], append(allFiles, args[i+1:]...)...)
102+
args = slices.Replace(args, i, i+1, allFiles...)
103103
break
104104
}
105105
}

Diff for: scripts/update_readme.go

+2-4
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import (
44
"bytes"
55
"fmt"
66
"os"
7+
"slices"
78
"strings"
89

910
"github.com/fatih/color"
@@ -33,10 +34,7 @@ func replace(mark string, origin []byte, new []byte) []byte {
3334
endMark := fmt.Appendf(nil, "<!-- END %s -->", mark)
3435
begin := bytes.Index(origin, beginMark) + len(beginMark)
3536
end := bytes.Index(origin, endMark)
36-
result := append([]byte(nil), origin[:begin]...)
37-
result = append(result, new...)
38-
result = append(result, origin[end:]...)
39-
return result
37+
return slices.Replace(origin, begin, end, new...)
4038
}
4139

4240
func updateUsage(readme []byte) []byte {

0 commit comments

Comments
 (0)