Skip to content

GIT_USER and GIT_EMAIL are not exported by default #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
navrkald opened this issue Apr 20, 2020 · 2 comments · May be fixed by #57
Open

GIT_USER and GIT_EMAIL are not exported by default #56

navrkald opened this issue Apr 20, 2020 · 2 comments · May be fixed by #57

Comments

@navrkald
Copy link
Contributor

navrkald commented Apr 20, 2020 •
edited
Loading

This should be very useful feature to know who have something deployed for audit reasons.
E.g. our use case is to distinguish if given service was deployed via Jenkins or if it was deployed by some human and who?
We have micro-service architecture with a lot of stacks and lambda functions and many small distributed teams so for us it would be extremely helpful if GIT_USER and GIT_EMAIL would be exported by default.
I think this feature would be useful for the most of the people and if somebody don't want to populate his email or password, he could always use gitVariablesEnvWhitelist and or gitVariablesTagsWhitelist feature to hide this info.
navrkald added a commit to navrkald/serverless-plugin-git-variables that referenced this issue Apr 20, 2020
@navrkald
Export GIT_USER and GIT_EMAIL env and tags vars by default.
1c3af0d 
Fixes jacob-meacham#56.
@navrkald navrkald linked a pull request Apr 20, 2020 that will close this issue
Open
@navrkald
Copy link
Contributor Author

If @jacob-meacham still disagree pls don't close it immediately and let people express their opinions.

@f00f
Copy link

f00f commented May 6, 2022

I don't think this solves any problem, and is not an issue of this plugin.

If you want to know the user, you could tag with the OS login which is harder to fake.
You could also just add another tag in jenkins deployments?
Or don't give users permissions to deploy to prod.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Export GIT_USER and GIT_EMAIL env and tags vars by default. navrkald/serverless-plugin-git-variables
2 participants
@f00f @navrkald