Skip to content

Commit 5b4ee87

Browse files
committed
update test with null values
- addresses graphql-python#118 - initial implementation by @yen223 in PR graphql-python#119
1 parent b099fab commit 5b4ee87

File tree

4 files changed

+12
-8
lines changed

4 files changed

+12
-8
lines changed

graphql/language/tests/fixtures.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@
5353
}
5454
5555
{
56-
unnamed(truthy: true, falsey: false),
56+
unnamed(truthy: true, falsey: false, nullish: null),
5757
query
5858
}
5959
"""

graphql/language/tests/test_parser.py

+4-6
Original file line numberDiff line numberDiff line change
@@ -90,11 +90,8 @@ def test_does_not_accept_fragments_spread_of_on():
9090
assert 'Syntax Error GraphQL (1:9) Expected Name, found }' in excinfo.value.message
9191

9292

93-
def test_does_not_allow_null_value():
94-
with raises(GraphQLSyntaxError) as excinfo:
95-
parse('{ fieldWithNullableStringInput(input: null) }')
96-
97-
assert 'Syntax Error GraphQL (1:39) Unexpected Name "null"' in excinfo.value.message
93+
def test_allows_null_value():
94+
parse('{ fieldWithNullableStringInput(input: null) }')
9895

9996

10097
def test_parses_multi_byte_characters():
@@ -130,7 +127,8 @@ def tesst_allows_non_keywords_anywhere_a_name_is_allowed():
130127
'mutation',
131128
'subscription',
132129
'true',
133-
'false'
130+
'false',
131+
'null',
134132
]
135133

136134
query_template = '''

graphql/language/tests/test_printer.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ def test_prints_kitchen_sink():
118118
}
119119
120120
{
121-
unnamed(truthy: true, falsey: false)
121+
unnamed(truthy: true, falsey: false, nullish: null)
122122
query
123123
}
124124
'''

graphql/language/tests/test_visitor.py

+6
Original file line numberDiff line numberDiff line change
@@ -562,6 +562,12 @@ def leave(self, node, key, parent, *args):
562562
['enter', 'BooleanValue', 'value', 'Argument'],
563563
['leave', 'BooleanValue', 'value', 'Argument'],
564564
['leave', 'Argument', 1, None],
565+
['enter', 'Argument', 2, None],
566+
['enter', 'Name', 'name', 'Argument'],
567+
['leave', 'Name', 'name', 'Argument'],
568+
['enter', 'NullValue', 'value', 'Argument'],
569+
['leave', 'NullValue', 'value', 'Argument'],
570+
['leave', 'Argument', 2, None],
565571
['leave', 'Field', 0, None],
566572
['enter', 'Field', 1, None],
567573
['enter', 'Name', 'name', 'Field'],

0 commit comments

Comments
 (0)