Skip to content

Commit 5c7a290

Browse files
committed
Fix new flake8 E741 error from using l variable
The just-updated flake8 package hits a bunch of: E741 ambiguous variable name 'l' warnings. This commit renames them all from `l` to `lst` (they are all list values) to avoid the error.
1 parent 32ef69a commit 5c7a290

File tree

4 files changed

+27
-27
lines changed

4 files changed

+27
-27
lines changed

tests/test_opaque_types.py

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4,21 +4,21 @@
44

55

66
def test_string_list():
7-
l = m.StringList()
8-
l.push_back("Element 1")
9-
l.push_back("Element 2")
10-
assert m.print_opaque_list(l) == "Opaque list: [Element 1, Element 2]"
11-
assert l.back() == "Element 2"
7+
lst = m.StringList()
8+
lst.push_back("Element 1")
9+
lst.push_back("Element 2")
10+
assert m.print_opaque_list(lst) == "Opaque list: [Element 1, Element 2]"
11+
assert lst.back() == "Element 2"
1212

13-
for i, k in enumerate(l, start=1):
13+
for i, k in enumerate(lst, start=1):
1414
assert k == "Element {}".format(i)
15-
l.pop_back()
16-
assert m.print_opaque_list(l) == "Opaque list: [Element 1]"
15+
lst.pop_back()
16+
assert m.print_opaque_list(lst) == "Opaque list: [Element 1]"
1717

1818
cvp = m.ClassWithSTLVecProperty()
1919
assert m.print_opaque_list(cvp.stringList) == "Opaque list: []"
2020

21-
cvp.stringList = l
21+
cvp.stringList = lst
2222
cvp.stringList.push_back("Element 3")
2323
assert m.print_opaque_list(cvp.stringList) == "Opaque list: [Element 1, Element 3]"
2424

tests/test_pytypes.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,11 @@
77

88
def test_list(capture, doc):
99
with capture:
10-
l = m.get_list()
11-
assert l == ["overwritten"]
10+
lst = m.get_list()
11+
assert lst == ["overwritten"]
1212

13-
l.append("value2")
14-
m.print_list(l)
13+
lst.append("value2")
14+
m.print_list(lst)
1515
assert capture.unordered == """
1616
Entry at position 0: value
1717
list item 0: overwritten

tests/test_sequences_and_iterators.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -131,9 +131,9 @@ def bad_next_call():
131131
m.iterator_to_list(iter(bad_next_call, None))
132132
assert str(excinfo.value) == "py::iterator::advance() should propagate errors"
133133

134-
l = [1, None, 0, None]
135-
assert m.count_none(l) == 2
136-
assert m.find_none(l) is True
134+
lst = [1, None, 0, None]
135+
assert m.count_none(lst) == 2
136+
assert m.find_none(lst) is True
137137
assert m.count_nonzeros({"a": 0, "b": 1, "c": 2}) == 2
138138

139139
r = range(5)

tests/test_stl.py

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,11 @@
66

77
def test_vector(doc):
88
"""std::vector <-> list"""
9-
l = m.cast_vector()
10-
assert l == [1]
11-
l.append(2)
12-
assert m.load_vector(l)
13-
assert m.load_vector(tuple(l))
9+
lst = m.cast_vector()
10+
assert lst == [1]
11+
lst.append(2)
12+
assert m.load_vector(lst)
13+
assert m.load_vector(tuple(lst))
1414

1515
assert m.cast_bool_vector() == [True, False]
1616
assert m.load_bool_vector([True, False])
@@ -24,19 +24,19 @@ def test_vector(doc):
2424

2525
def test_array(doc):
2626
"""std::array <-> list"""
27-
l = m.cast_array()
28-
assert l == [1, 2]
29-
assert m.load_array(l)
27+
lst = m.cast_array()
28+
assert lst == [1, 2]
29+
assert m.load_array(lst)
3030

3131
assert doc(m.cast_array) == "cast_array() -> List[int[2]]"
3232
assert doc(m.load_array) == "load_array(arg0: List[int[2]]) -> bool"
3333

3434

3535
def test_valarray(doc):
3636
"""std::valarray <-> list"""
37-
l = m.cast_valarray()
38-
assert l == [1, 4, 9]
39-
assert m.load_valarray(l)
37+
lst = m.cast_valarray()
38+
assert lst == [1, 4, 9]
39+
assert m.load_valarray(lst)
4040

4141
assert doc(m.cast_valarray) == "cast_valarray() -> List[int]"
4242
assert doc(m.load_valarray) == "load_valarray(arg0: List[int]) -> bool"

0 commit comments

Comments
 (0)