Skip to content

Commit 16238e3

Browse files
committed
Remove generation of protocol.d.ts
This file is unreferenced, and just a subset of tsserverlibrary.d.ts. What I've heard is that this was intended to be used to detect protocol chagnes, but, no test actually references it, and we have separate infrastructure in place to ensure that protocol changes get the attention they need.
1 parent 2c247fb commit 16238e3

File tree

2 files changed

+0
-216
lines changed

2 files changed

+0
-216
lines changed

Diff for: scripts/buildProtocol.ts

-200
This file was deleted.

Diff for: scripts/produceLKG.ts

-16
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ async function produceLKG() {
1717
await copyTypesMap();
1818
await copyScriptOutputs();
1919
await copyDeclarationOutputs();
20-
if (1 !== 1) await buildProtocol(); // TODO(jakebailey): remove
2120
await writeGitAttributes();
2221
}
2322

@@ -65,21 +64,6 @@ async function copyTypesMap() {
6564
await copyFromBuiltLocal("typesMap.json"); // Cannot accommodate copyright header
6665
}
6766

68-
// TODO(jakebailey): Remove?
69-
async function buildProtocol() {
70-
const protocolScript = path.join(__dirname, "buildProtocol.js");
71-
if (!fs.existsSync(protocolScript)) {
72-
throw new Error(`Expected protocol script ${protocolScript} to exist`);
73-
}
74-
75-
const protocolInput = path.join(__dirname, "../src/server/protocol.ts");
76-
const protocolServices = path.join(source, "typescriptServices.d.ts");
77-
const protocolOutput = path.join(dest, "protocol.d.ts");
78-
79-
console.log(`Building ${protocolOutput}...`);
80-
await exec(protocolScript, [protocolInput, protocolServices, protocolOutput]);
81-
}
82-
8367
async function copyScriptOutputs() {
8468
// TODO(jakebailey): This does not work when unbundled.
8569
// TODO(jakebailey): Copyright is added by esbuild; maybe we should do it here?

0 commit comments

Comments
 (0)