Add babel for let/const lowering

This reverts commit 8623e3ee6936bf15418fc437b45d7621ca732296.

Author: jakebailey

Diff for: Gulpfile.js

@@ -140,14 +140,17 @@ function getCopyrightHeader() {
  * @param {string} entrypoint
  * @param {string} outfile
  * @param {boolean} exportIsTsObject True if this file exports the TS object and should have relevant code injected.
+ * @param {boolean} performanceMatters True if this is a bundle where performance matters, so should be optimized at the cost of build time.
  */
-function esbuildTask(entrypoint, outfile, exportIsTsObject = false) {
+function esbuildTask(entrypoint, outfile, exportIsTsObject = false, performanceMatters = false) {
+    const preBabel = `${outfile}.tmp.js`;
+
     /** @type {esbuild.BuildOptions} */
     const options = {
         entryPoints: [entrypoint],
         banner: { js: getCopyrightHeader() },
         bundle: true,
-        outfile,
+        outfile: performanceMatters ? preBabel : outfile,
         platform: "node",
         // TODO: also specify minimal browser targets
         target: "node10", // Node 10 is the oldest benchmarker.
@@ -183,7 +186,15 @@ function esbuildTask(entrypoint, outfile, exportIsTsObject = false) {
     }
 
     return {
-        build: () => esbuild.build(options),
+        build: async () => {
+            await esbuild.build(options);
+            if (performanceMatters) {
+                // TODO(jakebailey): we could use ts.transpileModule for this, but running babel is faster to get this singular transform.
+                // If we did use ts.transpileModule, we'd need ts.ScriptTarget.ES5, which also will downlevel arrow functions, for-of, spread, etc.
+                await exec(process.execPath, ["./node_modules/@babel/cli/bin/babel.js", preBabel, "--out-file", outfile, "--plugins", "@babel/plugin-transform-block-scoping", "--compact", "false", "--source-maps"]);
+                await del([preBabel, `${preBabel}.map`]);
+            }
+        },
         clean: () => del([outfile, `${outfile}.map`]),
         watch: () => esbuild.build({ ...options, watch: true }),
     };
@@ -211,7 +222,7 @@ cleanTasks.push(cleanDebugTools);
 const lkgPreBuild = parallel(generateLibs, series(buildScripts, generateDiagnostics, buildDebugTools));
 
 
-const esbuildTsc = esbuildTask("./src/tsc/tsc.ts", "./built/local/tsc.js", /* exportIsTsObject */ true);
+const esbuildTsc = esbuildTask("./src/tsc/tsc.ts", "./built/local/tsc.js", /* exportIsTsObject */ true, /* performanceMatters */ true);
 
 
 const buildTsc = () => {
@@ -238,7 +249,7 @@ const localPreBuild = parallel(generateLibs, series(buildScripts, generateDiagno
 // Pre-build steps to use based on supplied options.
 const preBuild = cmdLineOptions.lkg ? lkgPreBuild : localPreBuild;
 
-const esbuildServices = esbuildTask("./src/typescript/typescript.ts", "./built/local/typescript.js", /* exportIsTsObject */ true);
+const esbuildServices = esbuildTask("./src/typescript/typescript.ts", "./built/local/typescript.js", /* exportIsTsObject */ true, /* performanceMatters */ true);
 
 // TODO(jakebailey): rename this; no longer "services".
 const buildServices = () => {
@@ -268,7 +279,7 @@ task("watch-services").flags = {
 };
 
 
-const esbuildServer = esbuildTask("./src/tsserver/server.ts", "./built/local/tsserver.js", /* exportIsTsObject */ true);
+const esbuildServer = esbuildTask("./src/tsserver/server.ts", "./built/local/tsserver.js", /* exportIsTsObject */ true, /* performanceMatters */ true);
 
 const buildServer = () => {
     if (cmdLineOptions.bundle) return esbuildServer.build();
@@ -311,12 +322,7 @@ task("watch-min").flags = {
     "   --built": "Compile using the built version of the compiler."
 };
 
-const buildLssl = (() => {
-    // TODO(jakebailey): fix this for modules
-    return cb => {
-        console.log("!!!TODO!!! buildLssl");
-        cb();
-    };
+const esbuildLssl = esbuildTask("./src/tsserverlibrary/tsserverlibrary.ts", "./built/local/tsserverlibrary.js", /* exportIsTsObject */ true, /* performanceMatters */ true);
 
 const buildLssl = () => {
     if (cmdLineOptions.bundle) return esbuildLssl.build();