Skip to content

Commit f1fe3ba

Browse files
committed
Don't check needsUpdate for localize, now that it is fast
1 parent 3969a14 commit f1fe3ba

File tree

1 file changed

+3
-8
lines changed

1 file changed

+3
-8
lines changed

Diff for: Herebyfile.mjs

+3-8
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import esbuild from "esbuild";
66
import { task } from "hereby";
77
import _glob from "glob";
88
import util from "util";
9-
import { exec, readJson, needsUpdate, getDiffTool, getDirSize } from "./scripts/build/utils.mjs";
9+
import { exec, readJson, getDiffTool, getDirSize } from "./scripts/build/utils.mjs";
1010
import { runConsoleTests, refBaseline, localBaseline, refRwcBaseline, localRwcBaseline } from "./scripts/build/tests.mjs";
1111
import { buildProject as realBuildProject, cleanProject } from "./scripts/build/projects.mjs";
1212
import { localizationDirectories } from "./scripts/build/localization.mjs";
@@ -148,15 +148,10 @@ const localizationTargets = localizationDirectories
148148
.map(f => `built/local/${f}/diagnosticMessages.generated.json`)
149149
.concat(generatedLCGFile);
150150

151-
const localize = task({
151+
export const localize = task({
152152
name: "localize",
153153
dependencies: [generateDiagnostics],
154-
run: async () => {
155-
if (needsUpdate(diagnosticMessagesGeneratedJson, generatedLCGFile)) {
156-
// TODO(jakebailey): slow; need needsUpdate to not block the builds
157-
return exec(process.execPath, ["scripts/generateLocalizedDiagnosticMessages.mjs", "src/loc/lcl", "built/local", diagnosticMessagesGeneratedJson], { ignoreExitCode: true });
158-
}
159-
}
154+
run: () => exec(process.execPath, ["scripts/generateLocalizedDiagnosticMessages.mjs", "src/loc/lcl", "built/local", diagnosticMessagesGeneratedJson], { ignoreExitCode: true }),
160155
});
161156

162157
export const buildSrc = task({

0 commit comments

Comments
 (0)