Merge pull request #440 from jakob-bagterp/fix/flaky-test-for-count-minutes-to-seconds

Fix: Flaky tests for rounding of floating point numbers

Author: jakob-bagterp

test/helper/time_fractions/count_minutes_to_seconds_test.py

@@ -1,3 +1,5 @@
+import math
+
 from _helper.time_fractions import random_minutes_as_ns
 
 from timer.model.time_fractions import TimeFractions
@@ -9,4 +11,4 @@ def test_count_minutes_to_seconds() -> None:
         mock_elapsed_time_ns = random_minutes_as_ns()
         rounded_seconds = round(TimeFractions(mock_elapsed_time_ns).count_minutes_to_seconds(), float_precision)
         rounded_mock_seconds = round(mock_elapsed_time_ns / 1000 / 1000 / 1000, float_precision)
-        assert rounded_seconds == rounded_mock_seconds
+        assert math.isclose(rounded_seconds, rounded_mock_seconds, rel_tol=1e-6)

test/helper/time_fractions/count_x_to_float_test.py

@@ -1,3 +1,5 @@
+import math
+
 from _helper.time_fractions import (random_microseconds_as_ns,
                                     random_milliseconds_as_ns,
                                     random_seconds_as_ns)
@@ -12,7 +14,7 @@ def test_count_microseconds_to_float() -> None:
         rounded_microseconds_to_float = round(TimeFractions(
             mock_elapsed_time_ns).count_microseconds_to_float(), float_precision)
         rounded_mock_microseconds_to_float = round(mock_elapsed_time_ns / 1000, float_precision)
-        assert rounded_microseconds_to_float == rounded_mock_microseconds_to_float
+        assert math.isclose(rounded_microseconds_to_float, rounded_mock_microseconds_to_float, rel_tol=1e-6)
 
 
 def test_count_milliseconds_to_float() -> None:
@@ -22,7 +24,7 @@ def test_count_milliseconds_to_float() -> None:
         rounded_milliseconds_to_float = round(TimeFractions(
             mock_elapsed_time_ns).count_milliseconds_to_float(), float_precision)
         rounded_mock_milliseconds_to_float = round(mock_elapsed_time_ns / 1000 / 1000, float_precision)
-        assert rounded_milliseconds_to_float == rounded_mock_milliseconds_to_float
+        assert math.isclose(rounded_milliseconds_to_float, rounded_mock_milliseconds_to_float, rel_tol=1e-9)
 
 
 def test_count_seconds_to_float() -> None:
@@ -31,4 +33,4 @@ def test_count_seconds_to_float() -> None:
         mock_elapsed_time_ns = random_seconds_as_ns()
         rounded_seconds_to_float = round(TimeFractions(mock_elapsed_time_ns).count_seconds_to_float(), float_precision)
         rounded_mock_seconds_to_float = round(mock_elapsed_time_ns / 1000 / 1000 / 1000, float_precision)
-        assert rounded_seconds_to_float == rounded_mock_seconds_to_float
+        assert math.isclose(rounded_seconds_to_float, rounded_mock_seconds_to_float, rel_tol=1e-12)

test/helper/time_fractions/seconds_rounded_test.py

@@ -1,3 +1,5 @@
+import math
+
 from _helper.time_fractions import random_seconds_as_ns
 
 from timer.model.time_fractions import TimeFractions
@@ -8,4 +10,4 @@ def test_seconds_rounded() -> None:
         mock_elapsed_time_ns = random_seconds_as_ns()
         round_seconds = TimeFractions(mock_elapsed_time_ns).seconds_rounded()
         rounded_mock_seconds = round(mock_elapsed_time_ns / 1000 / 1000 / 1000, 0)
-        assert round_seconds == rounded_mock_seconds
+        assert math.isclose(round_seconds, rounded_mock_seconds, rel_tol=1e-9)