Remove asserts (pyca#904)

Author: Gallaecio

src/OpenSSL/SSL.py

@@ -2131,7 +2131,7 @@ def server_random(self):
         if session == _ffi.NULL:
             return None
         length = _lib.SSL_get_server_random(self._ssl, _ffi.NULL, 0)
-        assert length > 0
+        _openssl_assert(length > 0)
         outp = _no_zero_allocator("unsigned char[]", length)
         _lib.SSL_get_server_random(self._ssl, outp, length)
         return _ffi.buffer(outp, length)[:]
@@ -2147,7 +2147,7 @@ def client_random(self):
             return None
 
         length = _lib.SSL_get_client_random(self._ssl, _ffi.NULL, 0)
-        assert length > 0
+        _openssl_assert(length > 0)
         outp = _no_zero_allocator("unsigned char[]", length)
         _lib.SSL_get_client_random(self._ssl, outp, length)
         return _ffi.buffer(outp, length)[:]
@@ -2163,7 +2163,7 @@ def master_key(self):
             return None
 
         length = _lib.SSL_SESSION_get_master_key(session, _ffi.NULL, 0)
-        assert length > 0
+        _openssl_assert(length > 0)
         outp = _no_zero_allocator("unsigned char[]", length)
         _lib.SSL_SESSION_get_master_key(session, outp, length)
         return _ffi.buffer(outp, length)[:]

src/OpenSSL/crypto.py

@@ -1819,7 +1819,7 @@ def dump_certificate(type, cert):
             "type argument must be FILETYPE_PEM, FILETYPE_ASN1, or "
             "FILETYPE_TEXT")
 
-    assert result_code == 1
+    _openssl_assert(result_code == 1)
     return _bio_to_string(bio)
 
 
@@ -2893,7 +2893,7 @@ def dump_crl(type, crl):
             "type argument must be FILETYPE_PEM, FILETYPE_ASN1, or "
             "FILETYPE_TEXT")
 
-    assert ret == 1
+    _openssl_assert(ret == 1)
     return _bio_to_string(bio)