Skip to content

Commit 2405d2e

Browse files
max630jamill
authored andcommitted
mingw: use CreateHardLink directly
It was observed that the current implementation of of get_proc_addr() fails to load the kernel32.dll with code ERROR_INVALID_PARAMETER. Probably the reason is that kernel32.dll is already loaded. The behavior was seen at Windows SP1, both 32bit and 64bit. Probably it would behave same way in some or all other Windows versions. This breaks all usages of "clone --local", including the automatic tests where they call it. The function CreateHardLink is available in all supported Windows versions (since Windows XP), so there is no more need to resolve it in runtime. Signed-off-by: Max Kirillov <[email protected]>
1 parent a8db1be commit 2405d2e

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

compat/mingw.c

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2703,13 +2703,8 @@ int mingw_raise(int sig)
27032703

27042704
int link(const char *oldpath, const char *newpath)
27052705
{
2706-
DECLARE_PROC_ADDR(kernel32.dll, BOOL, CreateHardLinkW,
2707-
LPCWSTR, LPCWSTR, LPSECURITY_ATTRIBUTES);
27082706
wchar_t woldpath[MAX_LONG_PATH], wnewpath[MAX_LONG_PATH];
27092707

2710-
if (!INIT_PROC_ADDR(CreateHardLinkW))
2711-
return -1;
2712-
27132708
if (xutftowcs_long_path(woldpath, oldpath) < 0 ||
27142709
xutftowcs_long_path(wnewpath, newpath) < 0)
27152710
return -1;

0 commit comments

Comments
 (0)