Skip to content

Commit f1ae7c8

Browse files
committed
migration gem to use just gemspec and fix string bug
1 parent 35e3436 commit f1ae7c8

10 files changed

+42
-121
lines changed

.gitignore

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
*.gem
2+
.bundle
3+
.rvmrc
4+
Gemfile.lock
5+
pkg/*

Gemfile

+4
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
source "http://rubygems.org"
2+
3+
# Specify your gem's dependencies in send_grid.gemspec
4+
gemspec

Rakefile

+5-61
Original file line numberDiff line numberDiff line change
@@ -1,61 +1,5 @@
1-
require 'rubygems'
2-
require 'rake'
3-
4-
begin
5-
require 'jeweler'
6-
Jeweler::Tasks.new do |gem|
7-
gem.name = "normalizations"
8-
gem.summary = %Q{normalize data prior to save}
9-
gem.description = %Q{normalize data prior to save}
10-
gem.email = "[email protected]"
11-
gem.homepage = "http://github.com/kylejginavan/normalizations"
12-
gem.authors = ["Kyle Ginavan"]
13-
gem.add_development_dependency "thoughtbot-shoulda", ">= 0"
14-
# gem is a Gem::Specification... see http://www.rubygems.org/read/chapter/20 for additional settings
15-
end
16-
Jeweler::GemcutterTasks.new
17-
rescue LoadError
18-
puts "Jeweler (or a dependency) not available. Install it with: gem install jeweler"
19-
end
20-
21-
require 'rake/testtask'
22-
Rake::TestTask.new(:test) do |test|
23-
test.libs << 'spec'
24-
test.pattern = 'spec/**/*_spec.rb'
25-
test.verbose = true
26-
end
27-
28-
begin
29-
require 'rcov/rcovtask'
30-
Rcov::RcovTask.new do |test|
31-
test.libs << 'spec'
32-
test.pattern = 'spec/**/*_spec.rb'
33-
test.verbose = true
34-
end
35-
rescue LoadError
36-
task :rcov do
37-
abort "RCov is not available. In order to run rcov, you must: sudo gem install spicycode-rcov"
38-
end
39-
end
40-
41-
task :test => :check_dependencies
42-
43-
task :default => :test
44-
45-
require 'rake/rdoctask'
46-
Rake::RDocTask.new do |rdoc|
47-
version = File.exist?('VERSION') ? File.read('VERSION') : ""
48-
49-
rdoc.rdoc_dir = 'rdoc'
50-
rdoc.title = "normalizations #{version}"
51-
rdoc.rdoc_files.include('README*')
52-
rdoc.rdoc_files.include('lib/**/*.rb')
53-
end
54-
55-
require 'spec/rake/spectask'
56-
desc "Run all specs"
57-
Spec::Rake::SpecTask.new('spec') do |t|
58-
t.spec_opts = ['--colour --format progress --loadby mtime --reverse']
59-
t.spec_files = FileList['spec/**/*_spec.rb']
60-
end
61-
1+
require 'bundler'
2+
require 'rspec/core/rake_task'
3+
Bundler::GemHelper.install_tasks
4+
RSpec::Core::RakeTask.new(:spec)
5+
task :default => :spec

VERSION

-1
This file was deleted.

lib/normalizations.rb

+3-3
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,10 @@ module Normalizations
99
PERCENT = /[% ]/
1010
SPACES = /\s/
1111

12-
module Instance_methods
12+
module Instance_methods
1313
def normalize(type)
14-
if self && self.to_s.match(type)
15-
self.to_s.gsub!(type,'')
14+
if self && self.is_a?(String) && self.match(type)
15+
self.gsub!(type,'')
1616
else
1717
self
1818
end

lib/version.rb

+3
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
module Normalizations
2+
VERSION = "0.0.4"
3+
end

normalizations.gemspec

+9-48
Original file line numberDiff line numberDiff line change
@@ -1,60 +1,21 @@
1-
# Generated by jeweler
2-
# DO NOT EDIT THIS FILE DIRECTLY
3-
# Instead, edit Jeweler::Tasks in Rakefile, and run the gemspec command
41
# -*- encoding: utf-8 -*-
2+
$:.push File.expand_path("../lib", __FILE__)
3+
require "version"
54

65
Gem::Specification.new do |s|
76
s.name = %q{normalizations}
8-
s.version = "0.0.4"
9-
7+
s.version = Normalizations::VERSION
108
s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
119
s.authors = ["Kyle Ginavan"]
1210
s.date = %q{2010-05-18}
1311
s.description = %q{normalize data prior to save}
1412
s.email = %q{[email protected]}
15-
s.extra_rdoc_files = [
16-
"LICENSE",
17-
"README.rdoc"
18-
]
19-
s.files = [
20-
"LICENSE",
21-
"README.rdoc",
22-
"Rakefile",
23-
"VERSION",
24-
"lib/normalizations.rb",
25-
"normalizations.gemspec",
26-
"normalizations.tmproj",
27-
"pkg/normalizations-0.0.0.gem",
28-
"pkg/normalizations-0.0.1.gem",
29-
"pkg/normalizations-0.0.2.gem",
30-
"pkg/normalizations-0.0.3.gem",
31-
"pkg/normalizations-0.0.4.gem",
32-
"spec/base.rb",
33-
"spec/sample.rb",
34-
"spec/sample_spec.rb"
35-
]
36-
s.homepage = %q{http://github.com/kylejginavan/normalizations}
37-
s.rdoc_options = ["--charset=UTF-8"]
13+
s.rubyforge_project = "normalizations"
14+
s.files = `git ls-files`.split("\n")
15+
s.test_files = `git ls-files -- {test,spec,features}/*`.split("\n")
16+
s.executables = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
3817
s.require_paths = ["lib"]
39-
s.rubygems_version = %q{1.3.6}
40-
s.summary = %q{normalize data prior to save}
41-
s.test_files = [
42-
"spec/base.rb",
43-
"spec/sample.rb",
44-
"spec/sample_spec.rb"
45-
]
46-
47-
if s.respond_to? :specification_version then
48-
current_version = Gem::Specification::CURRENT_SPECIFICATION_VERSION
49-
s.specification_version = 3
50-
51-
if Gem::Version.new(Gem::RubyGemsVersion) >= Gem::Version.new('1.2.0') then
52-
s.add_development_dependency(%q<thoughtbot-shoulda>, [">= 0"])
53-
else
54-
s.add_dependency(%q<thoughtbot-shoulda>, [">= 0"])
55-
end
56-
else
57-
s.add_dependency(%q<thoughtbot-shoulda>, [">= 0"])
58-
end
18+
s.add_development_dependency "thoughtbot-shoulda"
19+
s.add_development_dependency "rspec"
5920
end
6021

spec/base.rb

-5
This file was deleted.

spec/sample_spec.rb

+10-3
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
require File.dirname(__FILE__) + '/base'
1+
require 'spec_helper'
22

33
describe Sample do
44
before(:each) do
@@ -23,7 +23,8 @@
2323
it{@sample.value = nil;@sample.value.normalize(Normalizations::ZIPCODE).should == nil}
2424
it{@sample.value = "(111)";@sample.value.normalize(Normalizations::ZIPCODE).should == "111"}
2525
it{@sample.value = "11111";@sample.value.normalize(Normalizations::ZIPCODE).should == "11111"}
26-
it{@sample.value = 111.11;@sample.value.normalize(Normalizations::ZIPCODE).should == "11111"}
26+
it{@sample.value = 111.11;@sample.value.normalize(Normalizations::ZIPCODE).should == 111.11}
27+
it{@sample.value = 2;@sample.value.normalize(Normalizations::ZIPCODE).should == 2}
2728
end
2829

2930
describe "PHONE" do
@@ -37,6 +38,7 @@
3738

3839
it{@sample.value = "";@sample.value.normalize(Normalizations::PHONE).should == ""}
3940
it{@sample.value = nil;@sample.value.normalize(Normalizations::PHONE).should == nil}
41+
it{@sample.value = 111.1111;@sample.value.normalize(Normalizations::PHONE).should == 111.1111}
4042
end
4143

4244
describe "SSN" do
@@ -49,6 +51,7 @@
4951

5052
it{@sample.value = "";@sample.value.normalize(Normalizations::SSN).should == ""}
5153
it{@sample.value = nil;@sample.value.normalize(Normalizations::SSN).should == nil}
54+
it{@sample.value = 111.1111;@sample.value.normalize(Normalizations::SSN).should == 111.1111}
5255
end
5356

5457
describe "TAXID" do
@@ -59,6 +62,8 @@
5962

6063
it{@sample.value = "";@sample.value.normalize(Normalizations::TAXID).should == ""}
6164
it{@sample.value = nil;@sample.value.normalize(Normalizations::TAXID).should == nil}
65+
it{@sample.value = 1.2345;@sample.value.normalize(Normalizations::TAXID).should == 1.2345}
66+
6267
end
6368

6469
describe "DOLLAR" do
@@ -69,6 +74,8 @@
6974

7075
it{@sample.value = "";@sample.value.normalize(Normalizations::DOLLAR).should == ""}
7176
it{@sample.value = nil;@sample.value.normalize(Normalizations::DOLLAR).should == nil}
77+
it{@sample.value = 111.111;@sample.value.normalize(Normalizations::DOLLAR).should == 111.111}
78+
7279
end
7380

7481
describe "NUMBER" do
@@ -77,6 +84,7 @@
7784

7885
it{@sample.value = "";@sample.value.normalize(Normalizations::NUMBER).should == ""}
7986
it{@sample.value = nil;@sample.value.normalize(Normalizations::NUMBER).should == nil}
87+
it{@sample.value = 123;@sample.value.normalize(Normalizations::NUMBER).should == 123}
8088
end
8189

8290
describe "PERCENT" do
@@ -96,4 +104,3 @@
96104
it{@sample.value = nil;@sample.value.normalize(Normalizations::SPACES).should == nil}
97105
end
98106
end
99-

spec/spec_helper.rb

+3
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
require 'normalizations'
2+
require 'sample'
3+

0 commit comments

Comments
 (0)