Skip to content

Commit 7e35c2c

Browse files
We no longer need to wrap in quotes JavaScript reserved words used as properties (#4527)
1 parent 5651b8b commit 7e35c2c

File tree

9 files changed

+41
-54
lines changed

9 files changed

+41
-54
lines changed

lib/coffeescript/browser.js

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/coffeescript/cake.js

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/coffeescript/coffeescript.js

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/coffeescript/command.js

+7-7
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/coffeescript/nodes.js

+24-31
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/coffeescript/optparse.js

+4-4
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/coffeescript/repl.js

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/nodes.coffee

+1-7
Original file line numberDiff line numberDiff line change
@@ -951,10 +951,7 @@ exports.Access = class Access extends Base
951951
name = @name.compileToFragments o
952952
node = @name.unwrap()
953953
if node instanceof PropertyName
954-
if node.value in JS_FORBIDDEN
955-
[@makeCode('["'), name..., @makeCode('"]')]
956-
else
957-
[@makeCode('.'), name...]
954+
[@makeCode('.'), name...]
958955
else
959956
[@makeCode('['), name..., @makeCode(']')]
960957

@@ -1781,9 +1778,6 @@ exports.Assign = class Assign extends Base
17811778
if @variable.shouldCache()
17821779
compiledName.unshift @makeCode '['
17831780
compiledName.push @makeCode ']'
1784-
else if fragmentsToText(compiledName) in JS_FORBIDDEN
1785-
compiledName.unshift @makeCode '"'
1786-
compiledName.push @makeCode '"'
17871781
return compiledName.concat @makeCode(": "), val
17881782

17891783
answer = compiledName.concat @makeCode(" #{ @context or '=' } "), val

test/modules.coffee

+1-1
Original file line numberDiff line numberDiff line change
@@ -770,7 +770,7 @@ test "#4451: `default` in an export statement is only treated as a keyword when
770770
input = "export default { default: 1 }"
771771
output = """
772772
export default {
773-
"default": 1
773+
default: 1
774774
};
775775
"""
776776
eq toJS(input), output

0 commit comments

Comments
 (0)