add configuration for user authentication #279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@t-io Thanks for the PR! Do you mind adding documentation in the SETTINGS section? If you don't mind adding a test for a different authentication scheme as well? Honestly you don't need to do the latter. I ran the test suite and everything passed, so it LGTM! Ping @davesque |
Andrew-Chen-Wang
approved these changes
Jul 30, 2020
This was referenced Sep 2, 2020
davesque
reviewed
Oct 2, 2020
| @@ -24,6 +24,7 @@ | |||
| 'AUTH_HEADER_TYPES': ('Bearer',), | |||
| 'USER_ID_FIELD': 'id', | |||
| 'USER_ID_CLAIM': 'user_id', | |||
| 'USER_AUTHENTICATION_RULE': 'rest_framework_simplejwt.authentication.default_user_authentication_rule', | |||
There was a problem hiding this comment.
If we add this setting name to rest_framework_simplejwt.settings.IMPORT_STRINGS, we won't need to do the string splitting and importlib stuff in rest_framework_simplejwt/serializers.py.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.