-
Notifications
You must be signed in to change notification settings - Fork 691
Changed incorrect language code de_CH of es_CL #299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Just edited your comment for automatic resolving of issue. Thanks for double checking! Edit: Just took a look at the .mo file. It turns out that there is a language code in there as well (that's also incorrect). I'm not looking forward to tampering a partially non UTF-8 file that may be binary, so do you mind recompiling the files according to documentation? https://docs.djangoproject.com/en/3.1/topics/i18n/translation/#message-files Thanks! This is what I'm seeing in the de_CH django.mo file:
|
Cool, turns out .mo files also needs to be regenerated. I think |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks @dgmouris !
Actually is there a reason why all the paths had to include the package name?
Hey @Andrew-Chen-Wang, I took a look at some docs (https://docs.djangoproject.com/en/3.1/topics/i18n/translation/) and It looks like I needed to run a couple of things.
As well I ran the "makemessages" and compilemessages" and it seems like the mo files for UPDATE: |
@dgmouris I took a look at dj-stripe's repo. They don't even have the .mo file and I believe it's because Django will create the .mo file if the developer chooses to support i18n. (i.e. the devs need to run the compile messages or other commands). In this case, it's fine but I'm curious as to why the .po files changed the paths for all of them |
@Andrew-Chen-Wang I moved into the rest_framework_simplejwt and it fixed all of the paths to what was expected. My apologies:) It should be all good now. Cheers, Dan |
Thanks for the help @dgmouris! |
Fixes #297