Skip to content

Commit 2288811

Browse files
dschoderrickstolee
authored andcommitted
Merge virtualfilesystem hook
Add virtual file system settings and hook proc. On index load, clear/set the skip worktree bits based on the virtual file system data. Use virtual file system data to update skip-worktree bit in unpack-trees. Use virtual file system data to exclude files and folders not explicitly requested. The hook was first contributed in private, but was extended via the following pull requests: git-for-windows#15 git-for-windows#27 git-for-windows#33 git-for-windows#70 Signed-off-by: Ben Peart <[email protected]> Signed-off-by: Derrick Stolee <[email protected]>
2 parents 3153537 + c4bc864 commit 2288811

16 files changed

+864
-4
lines changed

Documentation/config/core.txt

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,14 @@ and MacOS.
107107
Note: if this config setting is set to `true`, the values of
108108
`core.fsmonitor` and `core.fsmonitorHookVersion` are ignored.
109109

110+
core.virtualFilesystem::
111+
If set, the value of this variable is used as a command which
112+
will identify all files and directories that are present in
113+
the working directory. Git will only track and update files
114+
listed in the virtual file system. Using the virtual file system
115+
will supersede the sparse-checkout settings which will be ignored.
116+
See the "virtual file system" section of linkgit:githooks[5].
117+
110118
core.trustctime::
111119
If false, the ctime differences between the index and the
112120
working tree are ignored; useful when the inode change time

Documentation/githooks.txt

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -699,6 +699,26 @@ and "0" meaning they were not.
699699
Only one parameter should be set to "1" when the hook runs. The hook
700700
running passing "1", "1" should not be possible.
701701

702+
virtualFilesystem
703+
~~~~~~~~~~~~~~~~~~
704+
705+
"Virtual File System" allows populating the working directory sparsely.
706+
The projection data is typically automatically generated by an external
707+
process. Git will limit what files it checks for changes as well as which
708+
directories are checked for untracked files based on the path names given.
709+
Git will also only update those files listed in the projection.
710+
711+
The hook is invoked when the configuration option core.virtualFilesystem
712+
is set. It takes one argument, a version (currently 1).
713+
714+
The hook should output to stdout the list of all files in the working
715+
directory that git should track. The paths are relative to the root
716+
of the working directory and are separated by a single NUL. Full paths
717+
('dir1/a.txt') as well as directories are supported (ie 'dir1/').
718+
719+
The exit status determines whether git will use the data from the
720+
hook. On error, git will abort the command with an error message.
721+
702722
GIT
703723
---
704724
Part of the linkgit:git[1] suite

Makefile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1066,6 +1066,7 @@ LIB_OBJS += utf8.o
10661066
LIB_OBJS += varint.o
10671067
LIB_OBJS += version.o
10681068
LIB_OBJS += versioncmp.o
1069+
LIB_OBJS += virtualfilesystem.o
10691070
LIB_OBJS += walker.o
10701071
LIB_OBJS += wildmatch.o
10711072
LIB_OBJS += worktree.o

cache.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -987,6 +987,7 @@ extern char *git_replace_ref_base;
987987

988988
extern int fsync_object_files;
989989
extern int core_preload_index;
990+
extern const char *core_virtualfilesystem;
990991
extern int core_gvfs;
991992
extern int precomposed_unicode;
992993
extern int protect_hfs;

config.c

Lines changed: 36 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1535,7 +1535,11 @@ static int git_default_core_config(const char *var, const char *value, void *cb)
15351535
}
15361536

15371537
if (!strcmp(var, "core.sparsecheckout")) {
1538-
core_apply_sparse_checkout = git_config_bool(var, value);
1538+
/* virtual file system relies on the sparse checkout logic so force it on */
1539+
if (core_virtualfilesystem)
1540+
core_apply_sparse_checkout = 1;
1541+
else
1542+
core_apply_sparse_checkout = git_config_bool(var, value);
15391543
return 0;
15401544
}
15411545

@@ -2528,6 +2532,37 @@ int git_config_get_max_percent_split_change(void)
25282532
return -1; /* default value */
25292533
}
25302534

2535+
int git_config_get_virtualfilesystem(void)
2536+
{
2537+
if (git_config_get_pathname("core.virtualfilesystem", &core_virtualfilesystem))
2538+
core_virtualfilesystem = getenv("GIT_VIRTUALFILESYSTEM_TEST");
2539+
2540+
if (core_virtualfilesystem && !*core_virtualfilesystem)
2541+
core_virtualfilesystem = NULL;
2542+
2543+
if (core_virtualfilesystem) {
2544+
/*
2545+
* Some git commands spawn helpers and redirect the index to a different
2546+
* location. These include "difftool -d" and the sequencer
2547+
* (i.e. `git rebase -i`, `git cherry-pick` and `git revert`) and others.
2548+
* In those instances we don't want to update their temporary index with
2549+
* our virtualization data.
2550+
*/
2551+
char *default_index_file = xstrfmt("%s/%s", the_repository->gitdir, "index");
2552+
int should_run_hook = !strcmp(default_index_file, the_repository->index_file);
2553+
2554+
free(default_index_file);
2555+
if (should_run_hook) {
2556+
/* virtual file system relies on the sparse checkout logic so force it on */
2557+
core_apply_sparse_checkout = 1;
2558+
return 1;
2559+
}
2560+
core_virtualfilesystem = NULL;
2561+
}
2562+
2563+
return 0;
2564+
}
2565+
25312566
int git_config_get_index_threads(int *dest)
25322567
{
25332568
int is_bool, val;

config.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -609,6 +609,7 @@ int git_config_get_index_threads(int *dest);
609609
int git_config_get_untracked_cache(void);
610610
int git_config_get_split_index(void);
611611
int git_config_get_max_percent_split_change(void);
612+
int git_config_get_virtualfilesystem(void);
612613

613614
/* This dies if the configured or default date is in the future */
614615
int git_config_get_expiry(const char *key, const char **output);

dir.c

Lines changed: 30 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
* Junio Hamano, 2005-2006
77
*/
88
#include "cache.h"
9+
#include "virtualfilesystem.h"
910
#include "config.h"
1011
#include "dir.h"
1112
#include "object-store.h"
@@ -1418,6 +1419,17 @@ enum pattern_match_result path_matches_pattern_list(
14181419
int result = NOT_MATCHED;
14191420
size_t slash_pos;
14201421

1422+
/*
1423+
* The virtual file system data is used to prevent git from traversing
1424+
* any part of the tree that is not in the virtual file system. Return
1425+
* 1 to exclude the entry if it is not found in the virtual file system,
1426+
* else fall through to the regular excludes logic as it may further exclude.
1427+
*/
1428+
if (*dtype == DT_UNKNOWN)
1429+
*dtype = resolve_dtype(DT_UNKNOWN, istate, pathname, pathlen);
1430+
if (is_excluded_from_virtualfilesystem(pathname, pathlen, *dtype) > 0)
1431+
return 1;
1432+
14211433
if (!pl->use_cone_patterns) {
14221434
pattern = last_matching_pattern_from_list(pathname, pathlen, basename,
14231435
dtype, pl, istate);
@@ -1691,8 +1703,20 @@ struct path_pattern *last_matching_pattern(struct dir_struct *dir,
16911703
int is_excluded(struct dir_struct *dir, struct index_state *istate,
16921704
const char *pathname, int *dtype_p)
16931705
{
1694-
struct path_pattern *pattern =
1695-
last_matching_pattern(dir, istate, pathname, dtype_p);
1706+
struct path_pattern *pattern;
1707+
1708+
/*
1709+
* The virtual file system data is used to prevent git from traversing
1710+
* any part of the tree that is not in the virtual file system. Return
1711+
* 1 to exclude the entry if it is not found in the virtual file system,
1712+
* else fall through to the regular excludes logic as it may further exclude.
1713+
*/
1714+
if (*dtype_p == DT_UNKNOWN)
1715+
*dtype_p = resolve_dtype(DT_UNKNOWN, istate, pathname, strlen(pathname));
1716+
if (is_excluded_from_virtualfilesystem(pathname, strlen(pathname), *dtype_p) > 0)
1717+
return 1;
1718+
1719+
pattern = last_matching_pattern(dir, istate, pathname, dtype_p);
16961720
if (pattern)
16971721
return pattern->flags & PATTERN_FLAG_NEGATIVE ? 0 : 1;
16981722
return 0;
@@ -2257,6 +2281,8 @@ static enum path_treatment treat_path(struct dir_struct *dir,
22572281
ignore_case);
22582282
if (dtype != DT_DIR && has_path_in_index)
22592283
return path_none;
2284+
if (is_excluded_from_virtualfilesystem(path->buf, path->len, dtype) > 0)
2285+
return path_excluded;
22602286

22612287
/*
22622288
* When we are looking at a directory P in the working tree,
@@ -2461,6 +2487,8 @@ static void add_path_to_appropriate_result_list(struct dir_struct *dir,
24612487
/* add the path to the appropriate result list */
24622488
switch (state) {
24632489
case path_excluded:
2490+
if (is_excluded_from_virtualfilesystem(path->buf, path->len, DT_DIR) > 0)
2491+
break;
24642492
if (dir->flags & DIR_SHOW_IGNORED)
24652493
dir_add_name(dir, istate, path->buf, path->len);
24662494
else if ((dir->flags & DIR_SHOW_IGNORED_TOO) ||

environment.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,7 @@ int grafts_replace_parents = 1;
7171
int core_apply_sparse_checkout;
7272
int core_sparse_checkout_cone;
7373
int core_gvfs;
74+
const char *core_virtualfilesystem;
7475
int merge_log_config = -1;
7576
int precomposed_unicode = -1; /* see probe_utf8_pathname_composition() */
7677
unsigned long pack_size_limit_cfg;

read-cache.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
*/
66
#include "cache.h"
77
#include "gvfs.h"
8+
#include "virtualfilesystem.h"
89
#include "config.h"
910
#include "diff.h"
1011
#include "diffcore.h"
@@ -1989,6 +1990,7 @@ static void post_read_index_from(struct index_state *istate)
19891990
tweak_untracked_cache(istate);
19901991
tweak_split_index(istate);
19911992
tweak_fsmonitor(istate);
1993+
apply_virtualfilesystem(istate);
19921994
}
19931995

19941996
static size_t estimate_cache_size_from_compressed(unsigned int entries)

run-command.c

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1417,6 +1417,17 @@ int run_hook_strvec(const char *const *env, const char *name,
14171417
const char *p;
14181418

14191419
p = find_hook(name);
1420+
/*
1421+
* Backwards compatibility hack in VFS for Git: when originally
1422+
* introduced (and used!), it was called `post-indexchanged`, but this
1423+
* name was changed during the review on the Git mailing list.
1424+
*
1425+
* Therefore, when the `post-index-change` hook is not found, let's
1426+
* look for a hook with the old name (which would be found in case of
1427+
* already-existing checkouts).
1428+
*/
1429+
if (!p && !strcmp(name, "post-index-change"))
1430+
p = find_hook("post-indexchanged");
14201431
if (!p)
14211432
return 0;
14221433

0 commit comments

Comments
 (0)