Skip to content

Commit fa397c6

Browse files
committed
Merge virtualfilesystem hook
Add virtual file system settings and hook proc. On index load, clear/set the skip worktree bits based on the virtual file system data. Use virtual file system data to update skip-worktree bit in unpack-trees. Use virtual file system data to exclude files and folders not explicitly requested. The hook was first contributed in private, but was extended via the following pull requests: git-for-windows#15 git-for-windows#27 git-for-windows#33 git-for-windows#70 Signed-off-by: Ben Peart <[email protected]> Signed-off-by: Derrick Stolee <[email protected]>
2 parents 4100da9 + 0f692ce commit fa397c6

16 files changed

+864
-4
lines changed

Documentation/config/core.txt

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,14 @@ and MacOS.
107107
Note: if this config setting is set to `true`, the values of
108108
`core.fsmonitor` and `core.fsmonitorHookVersion` are ignored.
109109

110+
core.virtualFilesystem::
111+
If set, the value of this variable is used as a command which
112+
will identify all files and directories that are present in
113+
the working directory. Git will only track and update files
114+
listed in the virtual file system. Using the virtual file system
115+
will supersede the sparse-checkout settings which will be ignored.
116+
See the "virtual file system" section of linkgit:githooks[5].
117+
110118
core.trustctime::
111119
If false, the ctime differences between the index and the
112120
working tree are ignored; useful when the inode change time

Documentation/githooks.txt

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -699,6 +699,26 @@ and "0" meaning they were not.
699699
Only one parameter should be set to "1" when the hook runs. The hook
700700
running passing "1", "1" should not be possible.
701701

702+
virtualFilesystem
703+
~~~~~~~~~~~~~~~~~~
704+
705+
"Virtual File System" allows populating the working directory sparsely.
706+
The projection data is typically automatically generated by an external
707+
process. Git will limit what files it checks for changes as well as which
708+
directories are checked for untracked files based on the path names given.
709+
Git will also only update those files listed in the projection.
710+
711+
The hook is invoked when the configuration option core.virtualFilesystem
712+
is set. It takes one argument, a version (currently 1).
713+
714+
The hook should output to stdout the list of all files in the working
715+
directory that git should track. The paths are relative to the root
716+
of the working directory and are separated by a single NUL. Full paths
717+
('dir1/a.txt') as well as directories are supported (ie 'dir1/').
718+
719+
The exit status determines whether git will use the data from the
720+
hook. On error, git will abort the command with an error message.
721+
702722
GIT
703723
---
704724
Part of the linkgit:git[1] suite

Makefile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1051,6 +1051,7 @@ LIB_OBJS += utf8.o
10511051
LIB_OBJS += varint.o
10521052
LIB_OBJS += version.o
10531053
LIB_OBJS += versioncmp.o
1054+
LIB_OBJS += virtualfilesystem.o
10541055
LIB_OBJS += walker.o
10551056
LIB_OBJS += wildmatch.o
10561057
LIB_OBJS += worktree.o

cache.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -978,6 +978,7 @@ extern char *git_replace_ref_base;
978978

979979
extern int fsync_object_files;
980980
extern int core_preload_index;
981+
extern const char *core_virtualfilesystem;
981982
extern int core_gvfs;
982983
extern int precomposed_unicode;
983984
extern int protect_hfs;

config.c

Lines changed: 36 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1535,7 +1535,11 @@ static int git_default_core_config(const char *var, const char *value, void *cb)
15351535
}
15361536

15371537
if (!strcmp(var, "core.sparsecheckout")) {
1538-
core_apply_sparse_checkout = git_config_bool(var, value);
1538+
/* virtual file system relies on the sparse checkout logic so force it on */
1539+
if (core_virtualfilesystem)
1540+
core_apply_sparse_checkout = 1;
1541+
else
1542+
core_apply_sparse_checkout = git_config_bool(var, value);
15391543
return 0;
15401544
}
15411545

@@ -2553,6 +2557,37 @@ int repo_config_get_fsmonitor(struct repository *r)
25532557
return 0;
25542558
}
25552559

2560+
int git_config_get_virtualfilesystem(void)
2561+
{
2562+
if (git_config_get_pathname("core.virtualfilesystem", &core_virtualfilesystem))
2563+
core_virtualfilesystem = getenv("GIT_VIRTUALFILESYSTEM_TEST");
2564+
2565+
if (core_virtualfilesystem && !*core_virtualfilesystem)
2566+
core_virtualfilesystem = NULL;
2567+
2568+
if (core_virtualfilesystem) {
2569+
/*
2570+
* Some git commands spawn helpers and redirect the index to a different
2571+
* location. These include "difftool -d" and the sequencer
2572+
* (i.e. `git rebase -i`, `git cherry-pick` and `git revert`) and others.
2573+
* In those instances we don't want to update their temporary index with
2574+
* our virtualization data.
2575+
*/
2576+
char *default_index_file = xstrfmt("%s/%s", the_repository->gitdir, "index");
2577+
int should_run_hook = !strcmp(default_index_file, the_repository->index_file);
2578+
2579+
free(default_index_file);
2580+
if (should_run_hook) {
2581+
/* virtual file system relies on the sparse checkout logic so force it on */
2582+
core_apply_sparse_checkout = 1;
2583+
return 1;
2584+
}
2585+
core_virtualfilesystem = NULL;
2586+
}
2587+
2588+
return 0;
2589+
}
2590+
25562591
int git_config_get_index_threads(int *dest)
25572592
{
25582593
int is_bool, val;

config.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -610,6 +610,7 @@ int git_config_get_untracked_cache(void);
610610
int git_config_get_split_index(void);
611611
int git_config_get_max_percent_split_change(void);
612612
int repo_config_get_fsmonitor(struct repository *r);
613+
int git_config_get_virtualfilesystem(void);
613614

614615
/* This dies if the configured or default date is in the future */
615616
int git_config_get_expiry(const char *key, const char **output);

dir.c

Lines changed: 30 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
* Junio Hamano, 2005-2006
77
*/
88
#include "cache.h"
9+
#include "virtualfilesystem.h"
910
#include "config.h"
1011
#include "dir.h"
1112
#include "object-store.h"
@@ -1421,6 +1422,17 @@ enum pattern_match_result path_matches_pattern_list(
14211422
int result = NOT_MATCHED;
14221423
const char *slash_pos;
14231424

1425+
/*
1426+
* The virtual file system data is used to prevent git from traversing
1427+
* any part of the tree that is not in the virtual file system. Return
1428+
* 1 to exclude the entry if it is not found in the virtual file system,
1429+
* else fall through to the regular excludes logic as it may further exclude.
1430+
*/
1431+
if (*dtype == DT_UNKNOWN)
1432+
*dtype = resolve_dtype(DT_UNKNOWN, istate, pathname, pathlen);
1433+
if (is_excluded_from_virtualfilesystem(pathname, pathlen, *dtype) > 0)
1434+
return 1;
1435+
14241436
if (!pl->use_cone_patterns) {
14251437
pattern = last_matching_pattern_from_list(pathname, pathlen, basename,
14261438
dtype, pl, istate);
@@ -1680,8 +1692,20 @@ struct path_pattern *last_matching_pattern(struct dir_struct *dir,
16801692
int is_excluded(struct dir_struct *dir, struct index_state *istate,
16811693
const char *pathname, int *dtype_p)
16821694
{
1683-
struct path_pattern *pattern =
1684-
last_matching_pattern(dir, istate, pathname, dtype_p);
1695+
struct path_pattern *pattern;
1696+
1697+
/*
1698+
* The virtual file system data is used to prevent git from traversing
1699+
* any part of the tree that is not in the virtual file system. Return
1700+
* 1 to exclude the entry if it is not found in the virtual file system,
1701+
* else fall through to the regular excludes logic as it may further exclude.
1702+
*/
1703+
if (*dtype_p == DT_UNKNOWN)
1704+
*dtype_p = resolve_dtype(DT_UNKNOWN, istate, pathname, strlen(pathname));
1705+
if (is_excluded_from_virtualfilesystem(pathname, strlen(pathname), *dtype_p) > 0)
1706+
return 1;
1707+
1708+
pattern = last_matching_pattern(dir, istate, pathname, dtype_p);
16851709
if (pattern)
16861710
return pattern->flags & PATTERN_FLAG_NEGATIVE ? 0 : 1;
16871711
return 0;
@@ -2246,6 +2270,8 @@ static enum path_treatment treat_path(struct dir_struct *dir,
22462270
ignore_case);
22472271
if (dtype != DT_DIR && has_path_in_index)
22482272
return path_none;
2273+
if (is_excluded_from_virtualfilesystem(path->buf, path->len, dtype) > 0)
2274+
return path_excluded;
22492275

22502276
/*
22512277
* When we are looking at a directory P in the working tree,
@@ -2450,6 +2476,8 @@ static void add_path_to_appropriate_result_list(struct dir_struct *dir,
24502476
/* add the path to the appropriate result list */
24512477
switch (state) {
24522478
case path_excluded:
2479+
if (is_excluded_from_virtualfilesystem(path->buf, path->len, DT_DIR) > 0)
2480+
break;
24532481
if (dir->flags & DIR_SHOW_IGNORED)
24542482
dir_add_name(dir, istate, path->buf, path->len);
24552483
else if ((dir->flags & DIR_SHOW_IGNORED_TOO) ||

environment.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,7 @@ int grafts_replace_parents = 1;
7171
int core_apply_sparse_checkout;
7272
int core_sparse_checkout_cone;
7373
int core_gvfs;
74+
const char *core_virtualfilesystem;
7475
int merge_log_config = -1;
7576
int precomposed_unicode = -1; /* see probe_utf8_pathname_composition() */
7677
unsigned long pack_size_limit_cfg;

read-cache.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
*/
66
#include "cache.h"
77
#include "gvfs.h"
8+
#include "virtualfilesystem.h"
89
#include "config.h"
910
#include "diff.h"
1011
#include "diffcore.h"
@@ -1984,6 +1985,7 @@ static void post_read_index_from(struct index_state *istate)
19841985
tweak_untracked_cache(istate);
19851986
tweak_split_index(istate);
19861987
tweak_fsmonitor(istate);
1988+
apply_virtualfilesystem(istate);
19871989
}
19881990

19891991
static size_t estimate_cache_size_from_compressed(unsigned int entries)

run-command.c

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1418,6 +1418,17 @@ int run_hook_strvec(const char *const *env, const char *name,
14181418
const char *p;
14191419

14201420
p = find_hook(name);
1421+
/*
1422+
* Backwards compatibility hack in VFS for Git: when originally
1423+
* introduced (and used!), it was called `post-indexchanged`, but this
1424+
* name was changed during the review on the Git mailing list.
1425+
*
1426+
* Therefore, when the `post-index-change` hook is not found, let's
1427+
* look for a hook with the old name (which would be found in case of
1428+
* already-existing checkouts).
1429+
*/
1430+
if (!p && !strcmp(name, "post-index-change"))
1431+
p = find_hook("post-indexchanged");
14211432
if (!p)
14221433
return 0;
14231434

0 commit comments

Comments
 (0)