Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make commit message on deps updates more helpful #8777

Closed
kastl-ars opened this issue Feb 18, 2025 · 5 comments
Closed

Make commit message on deps updates more helpful #8777

kastl-ars opened this issue Feb 18, 2025 · 5 comments

Comments

@kastl-ars
Copy link

Dear maintainers,

just a small nitpick: Would it be possible to adapt the automation that creates all these chore(deps) commits? They are missing the second most important part in the first line of the commit message.

e.g. 260491c

chore(deps): upgrade to version 0.4.2

I suggest this should read something like ... upgrade jx-test to version 0.4.2?

(The information is contained in the full commit message, but most tools only show the first line when displaying multiple commits).

Thanks in advance,
Johannes

@atharva-navani16
Copy link

Hi maintainers,

I’d like to work on this issue and submit a fix. The current chore(deps) commit messages don’t specify which dependency is being updated, making it harder to scan commit history quickly.

Plan to Fix:

  1. Identify the automation tool generating these commits .
  2. Modify the commit message format to include the package name.

Can you confirm where this automation is configured? Once I have that info, I’ll start working on the fix.

Thanks!

@msvticket
Copy link
Member

I think this was due to a regression in jx-updatebot that was fixed with the merge of jenkins-x-plugins/jx-updatebot#119.

@msvticket
Copy link
Member

Do tell if you still see the issue in an updated cluster.

@kastl-ars
Copy link
Author

Looking at the newest commits, I am not sure if this is fixed. The pull request you mentioned was merged on March 26th.

This commit from the 31st is still missing details:

[chore(deps): upgrade to version 0.25.0](https://github.com/jenkins-x/jx/commit/8a6833e781587c8d30fed4bf5065993d1ec09933)

Or was the update not in place at that time?

@msvticket
Copy link
Member

The change came into master of jx3-versions yesterday, so that is when the fix reached the Jenkins X build cluster.

jenkins-x/jx3-pipeline-catalog@411a4d5 -> jenkins-x/jx3-versions#4143

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants