-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make commit message on deps updates more helpful #8777
Comments
Hi maintainers, I’d like to work on this issue and submit a fix. The current chore(deps) commit messages don’t specify which dependency is being updated, making it harder to scan commit history quickly. Plan to Fix:
Can you confirm where this automation is configured? Once I have that info, I’ll start working on the fix. Thanks! |
I think this was due to a regression in jx-updatebot that was fixed with the merge of jenkins-x-plugins/jx-updatebot#119. |
Do tell if you still see the issue in an updated cluster. |
Looking at the newest commits, I am not sure if this is fixed. The pull request you mentioned was merged on March 26th. This commit from the 31st is still missing details:
Or was the update not in place at that time? |
The change came into master of jx3-versions yesterday, so that is when the fix reached the Jenkins X build cluster. jenkins-x/jx3-pipeline-catalog@411a4d5 -> jenkins-x/jx3-versions#4143 |
Dear maintainers,
just a small nitpick: Would it be possible to adapt the automation that creates all these
chore(deps)
commits? They are missing the second most important part in the first line of the commit message.e.g. 260491c
chore(deps): upgrade to version 0.4.2
I suggest this should read something like
... upgrade jx-test to version 0.4.2
?(The information is contained in the full commit message, but most tools only show the first line when displaying multiple commits).
Thanks in advance,
Johannes
The text was updated successfully, but these errors were encountered: