Return Future from Provider#sendBinary(ByteBuffer, boolean) (#10462)

Author: krisstern

core/src/main/java/jenkins/websocket/WebSocketSession.java

@@ -108,8 +108,8 @@ protected final Future<Void> sendBinary(ByteBuffer data) throws IOException {
         return handler.sendBinary(data);
     }
 
-    protected final void sendBinary(ByteBuffer partialByte, boolean isLast) throws IOException {
-        handler.sendBinary(partialByte, isLast);
+    protected final Future<Void> sendBinary(ByteBuffer partialByte, boolean isLast) throws IOException {
+        return handler.sendBinary(partialByte, isLast);
     }
 
     protected final Future<Void> sendText(String text) throws IOException {

websocket/jetty12-ee9/src/main/java/jenkins/websocket/Jetty12EE9Provider.java

@@ -92,8 +92,10 @@ public Future<Void> sendBinary(ByteBuffer data) throws IOException {
             }
 
             @Override
-            public void sendBinary(ByteBuffer partialByte, boolean isLast) throws IOException {
-                session().getRemote().sendPartialBytes(partialByte, isLast);
+            public Future<Void> sendBinary(ByteBuffer partialByte, boolean isLast) throws IOException {
+                CompletableFuture<Void> f = new CompletableFuture<>();
+                session().getRemote().sendPartialBytes(partialByte, isLast, new WriteCallbackImpl(f));
+                return f;
             }
 
             @Override

websocket/spi/src/main/java/jenkins/websocket/Provider.java

@@ -65,7 +65,7 @@ interface Handler {
 
         Future<Void> sendBinary(ByteBuffer data) throws IOException;
 
-        void sendBinary(ByteBuffer partialByte, boolean isLast) throws IOException;
+        Future<Void> sendBinary(ByteBuffer partialByte, boolean isLast) throws IOException;
 
         Future<Void> sendText(String text) throws IOException;