Use dropdown for the default view of a user (#10482)

* use select for the default vuew of a user

Currently one has to manually type name of the view and ony after
leaving the field one knows if it was correct.
This PR changes it to a select with all known views for the user

* fix potential problems

Author: mawinter69

core/src/main/java/hudson/model/MyViewsProperty.java

@@ -33,6 +33,7 @@
 import hudson.model.userproperty.UserPropertyCategory;
 import hudson.security.ACL;
 import hudson.util.FormValidation;
+import hudson.util.ListBoxModel;
 import hudson.views.MyViewsTabBar;
 import hudson.views.ViewsTabBar;
 import jakarta.servlet.ServletException;
@@ -48,6 +49,7 @@
 import org.jenkinsci.Symbol;
 import org.kohsuke.accmod.Restricted;
 import org.kohsuke.accmod.restrictions.NoExternalUse;
+import org.kohsuke.stapler.AncestorInPath;
 import org.kohsuke.stapler.DataBoundConstructor;
 import org.kohsuke.stapler.HttpRedirect;
 import org.kohsuke.stapler.HttpResponse;
@@ -273,6 +275,24 @@ public UserProperty newInstance(User user) {
         public @NonNull UserPropertyCategory getUserPropertyCategory() {
             return UserPropertyCategory.get(UserPropertyCategory.Preferences.class);
         }
+
+        @POST
+        public ListBoxModel doFillPrimaryViewNameItems(@AncestorInPath User user) throws IOException {
+            ListBoxModel items = new ListBoxModel();
+            user = user == null ? User.current() : user;
+            if (user != null) {
+                MyViewsProperty property = user.getProperty(MyViewsProperty.class);
+                if (property == null) {
+                    property = new MyViewsProperty();
+                    user.addProperty(property);
+                }
+                for (View view : property.views) {
+                    items.add(new ListBoxModel.Option(view.getDisplayName(), view.getViewName(),
+                            view == property.getPrimaryView()));
+                }
+            }
+            return items;
+        }
     }
 
     @Override

core/src/main/resources/hudson/model/MyViewsProperty/config.jelly

@@ -24,12 +24,8 @@ THE SOFTWARE.
 
 <?jelly escape-by-default='true'?>
 <j:jelly xmlns:j="jelly:core" xmlns:st="jelly:stapler" xmlns:d="jelly:define" xmlns:l="/lib/layout" xmlns:t="/lib/hudson" xmlns:f="/lib/form">
-  <f:invisibleEntry>
-    <!-- This only exists to provide the parameter of the checkUrl -->
-    <f:checkbox name="exists" checked="true"/>
-  </f:invisibleEntry>
   <f:entry title="${%Default View}"
     description="${%description}">
-    <f:textbox field="primaryViewName" checkUrl="${rootURL}/${instance.url}viewExistsCheck" checkDependsOn="exists"/>
+    <f:select field="primaryViewName"/>
   </f:entry>
 </j:jelly>