Skip to content

Commit 0f7f882

Browse files
authored
Merge pull request #30 from jglick/SSHAuthenticator-logging
Failures in doAuthenticate should be printed to the supplied listener
2 parents 026d3be + 0f6dd7f commit 0f7f882

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

Diff for: src/main/java/com/cloudbees/jenkins/plugins/sshcredentials/SSHAuthenticator.java

+2-5
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@
3131
import edu.umd.cs.findbugs.annotations.CheckForNull;
3232
import edu.umd.cs.findbugs.annotations.NonNull;
3333
import hudson.ExtensionList;
34+
import hudson.Functions;
3435
import hudson.model.BuildListener;
35-
import hudson.model.Hudson;
3636
import hudson.model.TaskListener;
3737
import hudson.remoting.Channel;
3838
import hudson.util.StreamTaskListener;
@@ -41,8 +41,6 @@
4141
import java.util.Collection;
4242
import java.util.Collections;
4343
import java.util.List;
44-
import java.util.logging.Level;
45-
import java.util.logging.Logger;
4644
import jenkins.model.Jenkins;
4745
import jenkins.security.SlaveToMasterCallable;
4846
import net.jcip.annotations.GuardedBy;
@@ -437,8 +435,7 @@ public final boolean authenticate() {
437435
try {
438436
authenticated = doAuthenticate();
439437
} catch (Throwable t) {
440-
Logger.getLogger(getClass().getName())
441-
.log(Level.WARNING, "Uncaught exception escaped doAuthenticate method", t);
438+
listener.error("SSH authentication failed").println(Functions.printThrowable(t).trim()); // TODO 2.43+ use Functions.printStackTrace
442439
authenticated = false;
443440
}
444441
}

0 commit comments

Comments
 (0)