[JENKINS-48232] fix findbugs and NullpointerException

fcojfernandez · fcojfernandez · commit 4f484196d01d · 2017-11-27T09:17:40.000+01:00
diff --git a/src/main/java/com/cloudbees/jenkins/plugins/sshcredentials/SSHAuthenticator.java b/src/main/java/com/cloudbees/jenkins/plugins/sshcredentials/SSHAuthenticator.java
@@ -232,7 +232,7 @@ public static <C, U extends StandardUsernameCredentials> SSHAuthenticator<C, U>
      */
     private static List<SSHAuthenticatorFactory> lookupFactories() {
         // TODO once Jenkins core has a class that can be used to detect running on build agent use that to gate instead
-        return Jenkins.getInstance() == null ? null : ExtensionList.lookup(SSHAuthenticatorFactory.class);
+        return Jenkins.getInstanceOrNull() == null ? null : ExtensionList.lookup(SSHAuthenticatorFactory.class);
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -232,7 +232,7 @@ public static <C, U extends StandardUsernameCredentials> SSHAuthenticator<C, U>`
`232`	`232`	`*/`
`233`	`233`	`private static List<SSHAuthenticatorFactory> lookupFactories() {`
`234`	`234`	`// TODO once Jenkins core has a class that can be used to detect running on build agent use that to gate instead`
`235`		`- return Jenkins.getInstance() == null ? null : ExtensionList.lookup(SSHAuthenticatorFactory.class);`
	`235`	`+ return Jenkins.getInstanceOrNull() == null ? null : ExtensionList.lookup(SSHAuthenticatorFactory.class);`
`236`	`236`	`}`
`237`	`237`
`238`	`238`	`/**`