Skip to content

Commit b2afec0

Browse files
committed
Change switchTabsWithPanelJumpKeys default to true
1 parent 829aa3c commit b2afec0

File tree

4 files changed

+5
-4
lines changed

4 files changed

+5
-4
lines changed

docs/Config.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -279,7 +279,7 @@ gui:
279279
switchToFilesAfterStashApply: true
280280

281281
# If true, when using the panel jump keys (default 1 through 5) and target panel is already active, go to next tab instead
282-
switchTabsWithPanelJumpKeys: false
282+
switchTabsWithPanelJumpKeys: true
283283

284284
# Config relating to git
285285
git:

pkg/config/user_config.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -798,7 +798,7 @@ func GetDefaultConfig() *UserConfig {
798798
StatusPanelView: "dashboard",
799799
SwitchToFilesAfterStashPop: true,
800800
SwitchToFilesAfterStashApply: true,
801-
SwitchTabsWithPanelJumpKeys: false,
801+
SwitchTabsWithPanelJumpKeys: true,
802802
},
803803
Git: GitConfig{
804804
Paging: PagingConfig{

pkg/integration/tests/ui/disable_switch_tab_with_panel_jump_keys.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,11 @@ import (
66
)
77

88
var DisableSwitchTabWithPanelJumpKeys = NewIntegrationTest(NewIntegrationTestArgs{
9-
Description: "Verify that the tab does not change by default when jumping to an already focused panel",
9+
Description: "Verify that the tab does not change when jumping to an already focused panel with the config SwitchTabsWithPanelJumpKeys to false",
1010
ExtraCmdArgs: []string{},
1111
Skip: false,
1212
SetupConfig: func(config *config.AppConfig) {
13+
config.GetUserConfig().Gui.SwitchTabsWithPanelJumpKeys = false
1314
},
1415
SetupRepo: func(shell *Shell) {
1516
},

schema/config.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -728,7 +728,7 @@
728728
"switchTabsWithPanelJumpKeys": {
729729
"type": "boolean",
730730
"description": "If true, when using the panel jump keys (default 1 through 5) and target panel is already active, go to next tab instead",
731-
"default": false
731+
"default": true
732732
}
733733
},
734734
"additionalProperties": false,

0 commit comments

Comments
 (0)