Skip to content

Commit 33d18c1

Browse files
committed
Merge branch 'main' into prefer-jest-globals
2 parents 1453eb8 + 541760c commit 33d18c1

File tree

4 files changed

+277
-292
lines changed

4 files changed

+277
-292
lines changed

.DS_Store

6 KB
Binary file not shown.

src/rules/__tests__/prefer-importing-jest-globals.test.ts

+20-19
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ const ruleTester = new TSESLint.RuleTester({
77
parser: espreeParser,
88
parserOptions: {
99
ecmaVersion: 2015,
10-
sourceType: 'module',
1110
},
1211
});
1312

@@ -31,7 +30,6 @@ ruleTester.run('prefer-importing-jest-globals', rule, {
3130
expect(true).toBeDefined();
3231
});
3332
`,
34-
parserOptions: { sourceType: 'module' },
3533
},
3634
{
3735
code: dedent`
@@ -45,7 +43,6 @@ ruleTester.run('prefer-importing-jest-globals', rule, {
4543
const { test } = require('@jest/globals');
4644
test("foo");
4745
`,
48-
parserOptions: { sourceType: 'module' },
4946
},
5047
],
5148
invalid: [
@@ -65,9 +62,9 @@ ruleTester.run('prefer-importing-jest-globals', rule, {
6562
expect(true).toBeDefined();
6663
})
6764
`,
68-
parserOptions: { sourceType: 'module' },
65+
parserOptions: { sourceType: 'script' },
6966
errors: [
70-
{ endColumn: 3, column: 1, messageId: 'preferImportingJestGlobal' },
67+
{ endColumn: 9, column: 1, messageId: 'preferImportingJestGlobal' },
7168
],
7269
},
7370
{
@@ -86,9 +83,8 @@ ruleTester.run('prefer-importing-jest-globals', rule, {
8683
expect(true).toBeDefined();
8784
})
8885
`,
89-
parserOptions: { sourceType: 'module' },
9086
errors: [
91-
{ endColumn: 3, column: 1, messageId: 'preferImportingJestGlobal' },
87+
{ endColumn: 9, column: 1, messageId: 'preferImportingJestGlobal' },
9288
],
9389
},
9490
{
@@ -107,49 +103,55 @@ ruleTester.run('prefer-importing-jest-globals', rule, {
107103
expect(true).toBeDefined();
108104
})
109105
`,
110-
parserOptions: { sourceType: 'module' },
111106
errors: [
112-
{ endColumn: 3, column: 1, messageId: 'preferImportingJestGlobal' },
107+
{ endColumn: 9, column: 1, messageId: 'preferImportingJestGlobal' },
113108
],
114109
},
115110
{
116111
code: dedent`
112+
import React from 'react';
113+
import { yourFunction } from './yourFile';
114+
import something from "something";
117115
import { test } from '@jest/globals';
116+
import { xit } from '@jest/globals';
118117
describe("suite", () => {
119118
test("foo");
120119
expect(true).toBeDefined();
121120
})
122121
`,
123122
output: dedent`
123+
import React from 'react';
124+
import { yourFunction } from './yourFile';
125+
import something from "something";
124126
import { test, describe, expect } from '@jest/globals';
127+
import { xit } from '@jest/globals';
125128
describe("suite", () => {
126129
test("foo");
127130
expect(true).toBeDefined();
128131
})
129132
`,
130133
parserOptions: { sourceType: 'module' },
131134
errors: [
132-
{ endColumn: 3, column: 1, messageId: 'preferImportingJestGlobal' },
135+
{ endColumn: 9, column: 1, messageId: 'preferImportingJestGlobal' },
133136
],
134137
},
135138
{
136139
code: dedent`
137140
const { test } = require('@jest/globals');
138-
describe("suite", () => {
139-
test("foo");
141+
describe("suite", () => {
142+
test("foo");
140143
expect(true).toBeDefined();
141144
})
142145
`,
143146
output: dedent`
144147
const { test, describe, expect } = require('@jest/globals');
145-
describe("suite", () => {
146-
test("foo");
148+
describe("suite", () => {
149+
test("foo");
147150
expect(true).toBeDefined();
148151
})
149152
`,
150-
parserOptions: { sourceType: 'module' },
151153
errors: [
152-
{ endColumn: 3, column: 1, messageId: 'preferImportingJestGlobal' },
154+
{ endColumn: 9, column: 1, messageId: 'preferImportingJestGlobal' },
153155
],
154156
},
155157
{
@@ -160,15 +162,14 @@ ruleTester.run('prefer-importing-jest-globals', rule, {
160162
});
161163
`,
162164
output: dedent`
163-
const { describe, test } = require('@jest/globals');
164165
const { pending } = require('actions');
166+
const { describe, test } = require('@jest/globals');
165167
describe('foo', () => {
166168
test.each(['hello', 'world'])("%s", (a) => {});
167169
});
168170
`,
169-
parserOptions: { sourceType: 'module' },
170171
errors: [
171-
{ endColumn: 4, column: 1, messageId: 'preferImportingJestGlobal' },
172+
{ endColumn: 9, column: 1, messageId: 'preferImportingJestGlobal' },
172173
],
173174
},
174175
],

0 commit comments

Comments
 (0)