fix(no-large-snapshots): don't use instanceof for checking regexps

G-Rath · G-Rath · commit d77a6880c7d8 · 2024-03-30T08:08:57.000+13:00
diff --git a/src/rules/no-large-snapshots.ts b/src/rules/no-large-snapshots.ts
@@ -54,11 +54,11 @@ const reportOnViolation = (
       const snapshotName = getAccessorValue(node.expression.left.property);
 
       isAllowed = allowedSnapshotsInFile.some(name => {
-        if (name instanceof RegExp) {
-          return name.test(snapshotName);
+        if (typeof name === 'string') {
+          return snapshotName === name;
         }
 
-        return snapshotName === name;
+        return name.test(snapshotName);
       });
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -54,11 +54,11 @@ const reportOnViolation = (`
`54`	`54`	`const snapshotName = getAccessorValue(node.expression.left.property);`
`55`	`55`
`56`	`56`	`isAllowed = allowedSnapshotsInFile.some(name => {`
`57`		`- if (name instanceof RegExp) {`
`58`		`- return name.test(snapshotName);`
	`57`	`+ if (typeof name === 'string') {`
	`58`	`+ return snapshotName === name;`
`59`	`59`	`}`
`60`	`60`
`61`		`- return snapshotName === name;`
	`61`	`+ return name.test(snapshotName);`
`62`	`62`	`});`
`63`	`63`	`}`
`64`	`64`	`}`