chore(lint): allow destructuring without const

Author: SimenB

.eslintrc.js

@@ -76,7 +76,7 @@ module.exports = {
     // todo: pulled from v3 of @typescript-eslint's eslint-recommended config
     'prefer-spread': 'error',
     'prefer-rest-params': 'error',
-    'prefer-const': 'error',
+    'prefer-const': ['error', { destructuring: 'all' }],
     'no-var': 'error',
   },
   overrides: [

package.json

@@ -24,8 +24,8 @@
     "postbuild": "rimraf lib/__tests__ lib/**/__tests__",
     "lint": "eslint . --ignore-pattern '!.eslintrc.js' --ext js,ts",
     "prepack": "yarn build",
-    "prettier:check": "prettier --check docs/**/*.md README.md package.json tsconfig.json src/globals.json",
-    "prettier:write": "prettier --write docs/**/*.md README.md package.json tsconfig.json src/globals.json",
+    "prettier:check": "prettier --check docs/**/*.md README.md .github/** package.json tsconfig.json src/globals.json",
+    "prettier:write": "prettier --write docs/**/*.md README.md .github/** package.json tsconfig.json src/globals.json",
     "test": "jest",
     "tools:regenerate-docs": "ts-node -T tools/regenerate-docs",
     "typecheck": "tsc -p ."

src/rules/no-deprecated-functions.ts

@@ -124,7 +124,6 @@ export default createRule({
           },
           node,
           fix(fixer) {
-            // eslint-disable-next-line prefer-const
             let [name, func] = replacement.split('.');
 
             if (callee.property.type === AST_NODE_TYPES.Literal) {