Skip to content

[no-disabled-tests] false positive on todo tests #1136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
waltherjj opened this issue May 30, 2022 · 2 comments · Fixed by #1137
Closed

[no-disabled-tests] false positive on todo tests #1136

waltherjj opened this issue May 30, 2022 · 2 comments · Fixed by #1137
Assignees
@G-Rath
Labels
bug released rule: no-disabled-tests

Comments

@waltherjj
Copy link

What happens

We upgraded from 26.2.1 to 26.4.5 and are now seeing error Test is missing function argument jest/no-disabled-tests for tests marked as todos: it.todo('does something'). I guess this could have been introduced in 26.4.1 or 26.4.2 by switching to jest function call parser?

What is expected

no-disabled-tests should not report tests marked as todos.

Thanks for your time!
@G-Rath G-Rath added the bug label May 30, 2022
@G-Rath
Copy link
Collaborator

G-Rath commented May 30, 2022

Ah yup thanks, I forgot to account for that when doing #1115

@G-Rath G-Rath self-assigned this May 30, 2022
@G-Rath G-Rath changed the title 'no-disabled-tests' incorrectly reports todo-tests [no-disabled-tests] false positive on todo tests May 30, 2022
@G-Rath G-Rath mentioned this issue May 30, 2022
Merged
@github-actions
Copy link

🎉 This issue has been resolved in version 26.4.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@G-Rath G-Rath

Labels
bug released rule: no-disabled-tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(no-disabled-tests): don't report on it.todo & test.todo jest-community/eslint-plugin-jest
2 participants
@G-Rath @waltherjj