Skip to content

prefer-to-be auto fix breaks code when using .resolves #979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sapphi-red opened this issue Nov 8, 2021 · 2 comments · Fixed by #980
Closed

prefer-to-be auto fix breaks code when using .resolves #979

sapphi-red opened this issue Nov 8, 2021 · 2 comments · Fixed by #980
Assignees
@G-Rath
Labels
bug released rule: prefer-to-be

Comments

@sapphi-red
Copy link

code

await expect(p).resolves.toBe(undefined)

prefer-to-be auto fix breaks this code.

actual

await expect(p).toBeUndefined()

expected

await expect(p).resolves.toBeUndefined()
@G-Rath G-Rath self-assigned this Nov 8, 2021
@G-Rath G-Rath mentioned this issue Nov 8, 2021
Merged
@github-actions
Copy link

github-actions bot commented Nov 8, 2021

🎉 This issue has been resolved in version 25.2.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sapphi-red
Copy link
Author

Thank you for your quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@G-Rath G-Rath

Labels
bug released rule: prefer-to-be
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(prefer-to-be): preserve resolves and rejects modifiers jest-community/eslint-plugin-jest
2 participants
@G-Rath @sapphi-red