Correctly disable tests for FIPS JVMs

jkakavas · jkakavas · commit 86a66ceaf32c · 2019-02-01T20:00:42.000+02:00
Replace assertFalse with assumeFalse Resolves: elastic#38212
diff --git a/modules/reindex/src/test/java/org/elasticsearch/index/reindex/ReindexRestClientSslTests.java b/modules/reindex/src/test/java/org/elasticsearch/index/reindex/ReindexRestClientSslTests.java
@@ -143,9 +143,8 @@ public void testClientSucceedsWithCertificateAuthorities() throws IOException {
         }
     }
 
-    @AwaitsFix(bugUrl = "https://github.com/elastic/elasticsearch/issues/38212")
     public void testClientSucceedsWithVerificationDisabled() throws IOException {
-        assertFalse("Cannot disable verification in FIPS JVM", inFipsJvm());
+        assumeFalse("Cannot disable verification in FIPS JVM", inFipsJvm());
         final List<Thread> threads = new ArrayList<>();
         final Settings settings = Settings.builder()
             .put("path.home", createTempDir())

Original file line number	Diff line number	Diff line change
`@@ -143,9 +143,8 @@ public void testClientSucceedsWithCertificateAuthorities() throws IOException {`
`143`	`143`	`}`
`144`	`144`	`}`
`145`	`145`
`146`		`- @AwaitsFix(bugUrl = "https://github.com/elastic/elasticsearch/issues/38212")`
`147`	`146`	`public void testClientSucceedsWithVerificationDisabled() throws IOException {`
`148`		`- assertFalse("Cannot disable verification in FIPS JVM", inFipsJvm());`
	`147`	`+ assumeFalse("Cannot disable verification in FIPS JVM", inFipsJvm());`
`149`	`148`	`final List<Thread> threads = new ArrayList<>();`
`150`	`149`	`final Settings settings = Settings.builder()`
`151`	`150`	`.put("path.home", createTempDir())`