Remove copy_settings flag from resize operations

This commit removes the `copy_settings` flag for shrink and split
operations. The flag was introduced in
elastic#30255 and the default
value from now onwards is for the settings to be copied.

Author: jkakavas

qa/full-cluster-restart/src/test/java/org/elasticsearch/upgrades/FullClusterRestartIT.java

@@ -381,9 +381,6 @@ public void testShrink() throws IOException {
             client().performRequest(updateSettingsRequest);
 
             Request shrinkIndexRequest = new Request("PUT", "/" + index + "/_shrink/" + shrunkenIndex);
-            if (getOldClusterVersion().onOrAfter(Version.V_6_4_0)) {
-                shrinkIndexRequest.addParameter("copy_settings", "true");
-            }
             shrinkIndexRequest.setJsonEntity("{\"settings\": {\"index.number_of_shards\": 1}}");
             client().performRequest(shrinkIndexRequest);
 

rest-api-spec/src/main/resources/rest-api-spec/api/indices.shrink.json

@@ -18,10 +18,6 @@
         }
       },
       "params": {
-        "copy_settings": {
-          "type" : "boolean",
-          "description" : "whether or not to copy settings from the source index (defaults to false)"
-        },
         "timeout": {
           "type" : "time",
           "description" : "Explicit operation timeout"

rest-api-spec/src/main/resources/rest-api-spec/api/indices.split.json

@@ -18,10 +18,6 @@
         }
       },
       "params": {
-        "copy_settings": {
-          "type" : "boolean",
-          "description" : "whether or not to copy settings from the source index (defaults to false)"
-        },
         "timeout": {
           "type" : "time",
           "description" : "Explicit operation timeout"

rest-api-spec/src/main/resources/rest-api-spec/test/indices.shrink/30_copy_settings.yml

@@ -43,13 +43,10 @@
         target: "copy-settings-target"
         wait_for_active_shards: 1
         master_timeout: 10s
-        copy_settings: true
         body:
           settings:
             index.number_of_replicas: 0
             index.merge.scheduler.max_thread_count: 2
-      warnings:
-        - "parameter [copy_settings] is deprecated and will be removed in 8.0.0"
 
   - do:
       cluster.health:
@@ -99,7 +96,6 @@
         target: "explicit-no-copy-settings-target"
         wait_for_active_shards: 1
         master_timeout: 10s
-        copy_settings: false
         body:
           settings:
             index.number_of_replicas: 0

rest-api-spec/src/main/resources/rest-api-spec/test/indices.split/30_copy_settings.yml

@@ -44,14 +44,11 @@
         target: "copy-settings-target"
         wait_for_active_shards: 1
         master_timeout: 10s
-        copy_settings: true
         body:
           settings:
             index.number_of_replicas: 0
             index.number_of_shards: 2
             index.merge.scheduler.max_thread_count: 2
-      warnings:
-        - "parameter [copy_settings] is deprecated and will be removed in 8.0.0"
 
 
   - do:
@@ -102,7 +99,6 @@
         target: "explicit-no-copy-settings-target"
         wait_for_active_shards: 1
         master_timeout: 10s
-        copy_settings: false
         body:
           settings:
             index.number_of_replicas: 0

server/src/main/java/org/elasticsearch/rest/action/admin/indices/RestResizeHandler.java

@@ -19,15 +19,10 @@
 
 package org.elasticsearch.rest.action.admin.indices;
 
-import org.apache.logging.log4j.Logger;
-import org.apache.logging.log4j.LogManager;
-import org.elasticsearch.Version;
 import org.elasticsearch.action.admin.indices.shrink.ResizeRequest;
 import org.elasticsearch.action.admin.indices.shrink.ResizeType;
 import org.elasticsearch.action.support.ActiveShardCount;
 import org.elasticsearch.client.node.NodeClient;
-import org.elasticsearch.common.Booleans;
-import org.elasticsearch.common.logging.DeprecationLogger;
 import org.elasticsearch.common.settings.Settings;
 import org.elasticsearch.rest.BaseRestHandler;
 import org.elasticsearch.rest.RestController;
@@ -37,8 +32,6 @@
 import java.io.IOException;
 
 public abstract class RestResizeHandler extends BaseRestHandler {
-    private static final Logger logger = LogManager.getLogger(RestResizeHandler.class);
-    private static final DeprecationLogger deprecationLogger = new DeprecationLogger(logger);
 
     RestResizeHandler(final Settings settings) {
         super(settings);
@@ -53,24 +46,6 @@ public abstract class RestResizeHandler extends BaseRestHandler {
     public final RestChannelConsumer prepareRequest(final RestRequest request, final NodeClient client) throws IOException {
         final ResizeRequest resizeRequest = new ResizeRequest(request.param("target"), request.param("index"));
         resizeRequest.setResizeType(getResizeType());
-        // copy_settings should be removed in Elasticsearch 8.0.0; cf. https://github.com/elastic/elasticsearch/issues/28347
-        assert Version.CURRENT.major < 8;
-        final String rawCopySettings = request.param("copy_settings");
-        final Boolean copySettings;
-        if (rawCopySettings == null) {
-            copySettings = resizeRequest.getCopySettings();
-        } else {
-            if (rawCopySettings.isEmpty()) {
-                copySettings = true;
-            } else {
-                copySettings = Booleans.parseBoolean(rawCopySettings);
-                if (copySettings == false) {
-                    throw new IllegalArgumentException("parameter [copy_settings] can not be explicitly set to [false]");
-                }
-            }
-            deprecationLogger.deprecated("parameter [copy_settings] is deprecated and will be removed in 8.0.0");
-        }
-        resizeRequest.setCopySettings(copySettings);
         request.applyContentParser(resizeRequest::fromXContent);
         resizeRequest.timeout(request.paramAsTime("timeout", resizeRequest.timeout()));
         resizeRequest.masterNodeTimeout(request.paramAsTime("master_timeout", resizeRequest.masterNodeTimeout()));