Skip to content

Commit 829fa63

Browse files
committed
debugging - make the ci fail if the driver is not available
1 parent 4e8e1bc commit 829fa63

File tree

3 files changed

+5
-9
lines changed

3 files changed

+5
-9
lines changed

java/src/org/openqa/selenium/chrome/ChromeDriverInfo.java

+2-4
Original file line numberDiff line numberDiff line change
@@ -74,12 +74,10 @@ public boolean isSupportingBiDi() {
7474

7575
@Override
7676
public boolean isAvailable() {
77-
try {
77+
for (int i = 0; i < 100; i++) {
7878
DriverFinder.getPath(ChromeDriverService.createDefaultService(), getCanonicalCapabilities());
79-
return true;
80-
} catch (IllegalStateException | WebDriverException e) {
81-
return false;
8279
}
80+
return true;
8381
}
8482

8583
@Override

java/src/org/openqa/selenium/firefox/GeckoDriverInfo.java

+2-4
Original file line numberDiff line numberDiff line change
@@ -67,12 +67,10 @@ public boolean isSupportingBiDi() {
6767

6868
@Override
6969
public boolean isAvailable() {
70-
try {
70+
for (int i = 0; i < 100; i++) {
7171
DriverFinder.getPath(GeckoDriverService.createDefaultService(), getCanonicalCapabilities());
72-
return true;
73-
} catch (IllegalStateException | WebDriverException e) {
74-
return false;
7572
}
73+
return true;
7674
}
7775

7876
@Override

java/test/org/openqa/selenium/testing/drivers/DefaultDriverSupplier.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,8 @@ public WebDriver get() {
4646

4747
return ServiceLoader.load(WebDriverInfo.class).stream()
4848
.map(ServiceLoader.Provider::get)
49-
.filter(WebDriverInfo::isAvailable)
5049
.filter(info -> info.isSupporting(capabilities))
50+
.filter(WebDriverInfo::isAvailable)
5151
.findFirst()
5252
.orElseThrow(
5353
() ->

0 commit comments

Comments
 (0)