Skip to content

Add a cibuildwheel test step - to verify the wheels can be installed and used #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
adamserafini opened this issue Feb 22, 2023 · 2 comments

Comments

@adamserafini
Copy link

fyi: I'm trying to use this recipe in my own project and finding I get this error in my CI for the mac osx abi3 build, but only when I try and test/install it:

https://github.com/adamserafini/zaml/actions/runs/4242743620/jobs/7374627494

ERROR: zaml-0.0.8-cp36-abi3-macosx_11_0_x86_64.whl is not a supported wheel on this platform.

I'm not asking to fix that bug or get support here, but I do think it would be good to add a 'test' step to the cibuildwheel config as a sort of 'proof' that this approach definitely works.

Happy to add one btw. if this proposal is likely to be accepted.

@joerick
Copy link
Owner

joerick commented Feb 22, 2023

I beleive this isn't an issue with the abi3 bit, but actually the macosx_11_0.

This is an issue with pip/macOS, where older pythons think they're on 10.16, rather than the actual version. See this issue for more info - pypa/cibuildwheel#1410

You might be able to get the build to work by setting SYSTEM_VERSION_COMPAT=0 during the build/test. However, Python 3.6 users are unlikely to be able to use the wheels either, without that flag. Perhaps you could reduce the macos minimum version?

@adamserafini
Copy link
Author

adamserafini commented Feb 22, 2023

🙇 OK, thanks a lot for the hint. I will investigate that.

I do agree it cannot be about abi3, because I added this to a pyproject.toml in a local checkout of this project and it passes fine!

[tool.cibuildwheel]
test-command = "python -c 'import spam; spam.system(\"exit 0\")'"

@joerick joerick closed this as completed Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants